[Bug 30493] New: Pending archived suggestions appear on intranet home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 Bug ID: 30493 Summary: Pending archived suggestions appear on intranet home page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org If suggestions are archived before their status is changed to something other than "Pending", they still appear on the intranet home page and the acquisitions home page as suggestions to be managed. 1. Go to Acquisitions > Suggestions 2. Click on New purchase suggestion 3. Fill in the form (title only is fine) 4. Click on Submit your suggestion 5. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 6. Go to Acquisitions --> Notice it says that there is 1 pending suggestion 7. Go to Suggestions 8. Click on the up arrow to the right of the Edit button and choose Archive --> There are no more pending suggestions 9. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 10. Go to Acquisitions --> Notice it says that there is 1 pending suggestion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 Thibault Keromnès <thibault.keromnes@univ-paris8.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #1 from Thibault Keromnès <thibault.keromnes@univ-paris8.fr> --- *** Bug 27462 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 --- Comment #2 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 167686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167686&action=edit Bug 30493: Pending archived suggestions appear on intranet home page If suggestions are archived before their status is changed to something other than "Pending", they still appear on the intranet home page and the acquisitions home page as suggestions to be managed. WITHOUT PATCH: 1. Go to Acquisitions > Suggestions 2. Click on New purchase suggestion 3. Fill in the form (title only is fine) 4. Click on Submit your suggestion 5. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 6. Go to Acquisitions --> Notice it says that there is 1 pending suggestion 7. Go to Suggestions 8. Click on the up arrow to the right of the Edit button and choose Archive --> There are no more pending suggestions 9. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 10. Go to Acquisitions --> Notice it says that there is 1 pending suggestion The search function was fetching suggestions without considering the "archived" field. I now pick only suggestion that are pending AND not archived. WITH PATCH: 9. Go to the home page (click the Koha logo) --> Notice it says that there is no pending suggestion 10. Go to Acquisitions --> Notice it says that there is no pending suggestion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- The change for acqui-home.pl is missing here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167686|0 |1 is obsolete| | --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 167687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167687&action=edit Bug 30493: Pending archived suggestions appear on intranet home page If suggestions are archived before their status is changed to something other than "Pending", they still appear on the intranet home page and the acquisitions home page as suggestions to be managed. WITHOUT PATCH: 1. Go to Acquisitions > Suggestions 2. Click on New purchase suggestion 3. Fill in the form (title only is fine) 4. Click on Submit your suggestion 5. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 6. Go to Acquisitions --> Notice it says that there is 1 pending suggestion 7. Go to Suggestions 8. Click on the up arrow to the right of the Edit button and choose Archive --> There are no more pending suggestions 9. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 10. Go to Acquisitions --> Notice it says that there is 1 pending suggestion The search function was fetching suggestions without considering the "archived" field. I now pick only suggestion that are pending AND not archived. WITH PATCH: 9. Go to the home page (click the Koha logo) --> Notice it says that there is no pending suggestion 10. Go to Acquisitions --> Notice it says that there is no pending suggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167687|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167689&action=edit Bug 30493: Pending archived suggestions appear on intranet home page If suggestions are archived before their status is changed to something other than "Pending", they still appear on the intranet home page and the acquisitions home page as suggestions to be managed. WITHOUT PATCH: 1. Go to Acquisitions > Suggestions 2. Click on New purchase suggestion 3. Fill in the form (title only is fine) 4. Click on Submit your suggestion 5. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 6. Go to Acquisitions --> Notice it says that there is 1 pending suggestion 7. Go to Suggestions 8. Click on the up arrow to the right of the Edit button and choose Archive --> There are no more pending suggestions 9. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 10. Go to Acquisitions --> Notice it says that there is 1 pending suggestion The search function was fetching suggestions without considering the "archived" field. I now pick only suggestion that are pending AND not archived. WITH PATCH: 9. Go to the home page (click the Koha logo) --> Notice it says that there is no pending suggestion 10. Go to Acquisitions --> Notice it says that there is no pending suggestion Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167689|0 |1 is obsolete| | --- Comment #6 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 167760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167760&action=edit Bug 30493: Pending archived suggestions appear on intranet home page If suggestions are archived before their status is changed to something other than "Pending", they still appear on the intranet home page and the acquisitions home page as suggestions to be managed. WITHOUT PATCH: 1. Go to Acquisitions > Suggestions 2. Click on New purchase suggestion 3. Fill in the form (title only is fine) 4. Click on Submit your suggestion 5. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 6. Go to Acquisitions --> Notice it says that there is 1 pending suggestion 7. Go to Suggestions 8. Click on the up arrow to the right of the Edit button and choose Archive --> There are no more pending suggestions 9. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 10. Go to Acquisitions --> Notice it says that there is 1 pending suggestion The search function was fetching suggestions without considering the "archived" field. I now pick only suggestion that are pending AND not archived. WITH PATCH: 9. Go to the home page (click the Koha logo) --> Notice it says that there is no pending suggestion 10. Go to Acquisitions --> Notice it says that there is no pending suggestion Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 --- Comment #7 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 167761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167761&action=edit Bug 30493: (QA follow-up) Fix for the only_my_library case as well Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #8 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Looks good, and QA tool passes. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Pending archived |Pending archived |suggestions appear on |suggestions appear on staff |intranet home page |interface home page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.02 released in| | Status|Pushed to main |Pushed to stable --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.02 |24.11.00,24.05.02,23.11.07 released in| | Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the list of release notes| |pending suggestions to | |remove archived suggestions | |with a "Pending" status. If | |suggestions were archived | |and their status was left | |as "Pending", they were | |still appearing as | |suggestions to manage on | |the staff interface and | |acquisitions home pages. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Version(s)|24.11.00,24.05.02,23.11.07 |24.11.00,24.05.02,23.11.07, released in| |23.05.1 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #12 from wainuiwitikapark@catalyst.net.nz --- Backported to 23.05.x for 23.05.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30493 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org