https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|emmi.takkinen@koha-suomi.fi |johanna.raisa@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hammat.wele@inlibro.com Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe this would be another candidate to be moved to the REST API? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30660 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30660 [Bug 30660] Add cancellation reason to holds delete endpoint -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- *** Bug 37705 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 --- Comment #5 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- (In reply to Pedro Amorim from comment #4)

(In reply to Emmi Takkinen from comment #2)

...

(In reply to Katrin Fischer from comment #1)

...

Maybe this would be another candidate to be moved to the REST API?

Johanna has actually worked on this (but is currently absent) and we've been using it for awhile now https://github.com/KohaSuomi/Koha-22x/commit/ c26f53eeac4c12e13e1e595931b4ec279f054da7

However, this depends on bug 30660 and bug 30661.

Hi all, is this still the most up to date work in progress? Would you please add the relevant git repo branch URL to this bug's URL? I'm available to help out here.

Yes, I working on it at the moment. We have our tweaked version and I'm trying to improve it to work in main. I will add a URL tomorrow, after I have cleaned some code. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 --- Comment #6 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- I added a branch URL to this bug. Still needs testing that everything works correctly with permissions, multiple records etc. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 --- Comment #8 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- (In reply to Pedro Amorim from comment #7)

Hi Johanna, thank you. If this is ready for testing please set the bug as "Needs Signoff".

I will improve it a bit and add a patch for testing after. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 --- Comment #9 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 173770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173770&action=edit Bug 23269: use REST API for patron_holds_table This patch uses the REST API to populate the holds table Test plan: 1) Apply the patch 2) Go to a record with holds 3) Check that the holds table is populated correctly 4) Check that hold tables functions work correctly 5) Change HoldsSplitQueue and HoldsSplitQueueNumbering system preference, try all variations 6) Repeat steps 3 and 4 7) Search for records and place holds to multiple records 8) Repeat steps 3 and 4 9) Try with lesser permissions Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- This is really impressive work. It works great from what I can tell. I have some observations, though I don't think any one in particular is a blocker, and some may not need a follow-up and are simply observations: - Entering an expiration date triggers the same API call twice - Entering "suspend on" date triggers the same API call twice - Date inputs are missing the "x" to clear the input - Entering "suspend on" date immediately suspends the hold. On the previous table you'd have to click the 'suspend' button after inserting the date to effectively suspend it. - The label for a suspended hold is "Resume", previously was "Unsuspend". - Trash icon for "delete" icon missing hover pointer cursor. - If all actions now update holds in real-time, do we still need the "Update hold(s)" button at the top? Previously this was needed to save the changes, but it's not anymore. - "Print slip" button now always shows, previously it only showed if hold.intransit || hold.atdestination. - Deleting a hold is triggering table redraw API call multiple times, to reproduce: -- Place 3 or 4 holds on a patron. -- Move the priority around multiple times for all holds. -- Delete one of the holds. -- Notice the network tab calling the same API endpoint multiple times (sometimes over 10 times) I think at least the "Update holds" button question and the multiple API calls issues should be addressed. What do you think Johanna? Do you agree? Up to you how best we should follow-up here. I think this is really good as is already. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Bug 23269 depends on bug 30660, which changed state. Bug 30660 Summary: Add cancellation reason to holds delete endpoint https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30660 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #15 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Now all those that Pedro pointed out should be fixed. API endpoints changed a bit so running build-resources.PL is needed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176705|0 |1 is obsolete| | --- Comment #17 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 177151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177151&action=edit Bug 23269: use REST API for patron_holds_table This patch uses the REST API to populate the holds table Test plan: 1) Apply the patch 2) Go to a record with holds 3) Check that the holds table is populated correctly 4) Check that hold tables functions work correctly 5) Change HoldsSplitQueue and HoldsSplitQueueNumbering system preference, try all variations 6) Repeat steps 3 and 4 7) Search for records and place holds to multiple records 8) Repeat steps 3 and 4 9) Try with lesser permissions Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177151|0 |1 is obsolete| | --- Comment #18 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181244&action=edit Bug 23269: use REST API for patron_holds_table This patch uses the REST API to populate the holds table Test plan: 1) Apply the patch 2) Go to a record with holds 3) Check that the holds table is populated correctly 4) Check that hold tables functions work correctly 5) Change HoldsSplitQueue and HoldsSplitQueueNumbering system preference, try all variations 6) Repeat steps 3 and 4 7) Search for records and place holds to multiple records 8) Repeat steps 3 and 4 9) Try with lesser permissions Sponsored-by: Koha-Suomi Oy Pedro rebased and tidied after bug 38664 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Hi Johanna, thank you for your patience here. I've rebased and tidied the patch on top of bug 38664. I believe the integrity of the patch was kept but apologies in advance if some regression was introduced here, my intention is to help move this forward. Here are my notes: Previously mentioned regressions that are still occurring (but not critical): 1) Setting an expiration date still triggers 2 pairs of API requests (the update + table rerender) 2) The button label for a suspended hold is "Resume", previously was "Unsuspend". New regressions (worth investigating): 1) Before, if a hold is "in transit" (found = T), the priority column shows a disabled dropdown with value 'In transit'. Now, the dropdown contains 'In transit' but it's not disabled. Changing the value here for a hold triggers a table re-render but seemingly doesn't update any value. 2) Table columns were sortable before, they are no longer. This may be tricky but if at least some of them are easy to make sortable we should consider this. Observation (not critical) The table now shows: Showing 1 to 4 of 4 entries (filtered from 5 total entries) This is the standard behavior of API based tables. But the '5' from the above example is referring to the total holds number of the database.I wonder if it will ever be relevant to show the total number of holds in the database in this screen? Provided patch if you agree. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181247|0 |1 is obsolete| | --- Comment #22 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 182729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182729&action=edit Bug 23269: Remove 'filtered from x total entries' Signed-off-by: Johanna Räisä <johanna.raisa@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #24 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- (In reply to Pedro Amorim from comment #20)

Hi Johanna, thank you for your patience here. I've rebased and tidied the patch on top of bug 38664. I believe the integrity of the patch was kept but apologies in advance if some regression was introduced here, my intention is to help move this forward. Here are my notes:

Previously mentioned regressions that are still occurring (but not critical): 1) Setting an expiration date still triggers 2 pairs of API requests (the update + table rerender) 2) The button label for a suspended hold is "Resume", previously was "Unsuspend".

I made fixes to these. Those should be ok now.

New regressions (worth investigating): 1) Before, if a hold is "in transit" (found = T), the priority column shows a disabled dropdown with value 'In transit'. Now, the dropdown contains 'In transit' but it's not disabled. Changing the value here for a hold triggers a table re-render but seemingly doesn't update any value.

For some reason I didn't notice this. I compared to current main and both were disabled.

2) Table columns were sortable before, they are no longer. This may be tricky but if at least some of them are easy to make sortable we should consider this.

I added sortable to columns were it would make sense.

Observation (not critical) The table now shows: Showing 1 to 4 of 4 entries (filtered from 5 total entries)

This is the standard behavior of API based tables. But the '5' from the above example is referring to the total holds number of the database.I wonder if it will ever be relevant to show the total number of holds in the database in this screen? Provided patch if you agree.

This was a good addition. It looked a bit silly there. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182728|0 |1 is obsolete| | --- Comment #25 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 182754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182754&action=edit Bug 23269: use REST API for patron_holds_table This patch uses the REST API to populate the holds table Test plan: 1) Apply the patch 2) Go to a record with holds 3) Check that the holds table is populated correctly 4) Check that hold tables functions work correctly 5) Change HoldsSplitQueue and HoldsSplitQueueNumbering system preference, try all variations 6) Repeat steps 3 and 4 7) Search for records and place holds to multiple records 8) Repeat steps 3 and 4 9) Try with lesser permissions Sponsored-by: Koha-Suomi Oy Pedro rebased and tidied after bug 38664 Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182730|0 |1 is obsolete| | --- Comment #27 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 182756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182756&action=edit Bug 23269: Add datatable fixes Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|pedro.amorim@openfifth.co.u |nick@bywatersolutions.com |k | --- Comment #29 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Thank you, Johanna. Adding Nick as QA contact here as I've signed-off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31698 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 [Bug 31698] Add ability to move a hold to a new bibliographic record/item -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31698 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 [Bug 31698] Add ability to move a hold to a new bibliographic record/item -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41416 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #33 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Now I hopefully have fixed the issues and this works with new hold features. Was bit of a nightmare to check the related features again since there were lot of refactoring made. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191669|0 |1 is obsolete| | --- Comment #35 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 191670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191670&action=edit Bug 23269: use REST API for patron_holds_table Added a minor fix for showing the cancel alert box. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41801 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #37 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- This works great, I tested in combination with 41801 and was able to quickly move holds and adjust priorities. I added a follow-up as the condition for showing the lowest priority toggle was incorrect - we can still toggle on item level holds, but not on found holds. The only issue I found was that clicking the 'move to top' or 'move to bottom' arrow on a record with hundreds of holds was slow and there was no spinner - if you can add that I will sign off. Excellent work! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 --- Comment #39 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 192850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192850&action=edit Bug 23269: (follow-up) Fix suspend date change This patch fixes suspend date change, so changing the suspend will save the new suspend date. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191670|0 |1 is obsolete| | Attachment #192849|0 |1 is obsolete| | Attachment #192850|0 |1 is obsolete| | Attachment #192851|0 |1 is obsolete| | --- Comment #41 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 192939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192939&action=edit Bug 23269: use REST API for patron_holds_table This patch uses the REST API to populate the holds table Test plan: 1) Apply the patch 2) Go to a record with holds 3) Check that the holds table is populated correctly 4) Check that hold tables functions work correctly 5) Change HoldsSplitQueue and HoldsSplitQueueNumbering system preference, try all variations 6) Repeat steps 3 and 4 7) Search for records and place holds to multiple records 8) Repeat steps 3 and 4 9) Try with lesser permissions Sponsored-by: Koha-Suomi Oy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 --- Comment #43 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 192941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192941&action=edit Bug 23269: (follow-up) Fix suspend date change This patch fixes suspend date change, so changing the suspend will save the new suspend date. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 --- Comment #45 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 192943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192943&action=edit Bug 23269: (follow-up) Check if hold item_level before grabbing barcode Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192940|0 |1 is obsolete| | --- Comment #47 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193101&action=edit Bug 23269: (follow-up) Show lowest priority toggle unless hold is 'found' Signed-off-by: Johanna Räisä <johanna.raisa@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192942|0 |1 is obsolete| | --- Comment #49 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193103&action=edit Bug 23269: (follow-up) Add spinner and fix details column This patch adds a spinner to moving priorities and fixes the details column to show the correct information. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 --- Comment #51 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Passing QA as everything appears to be working as intended and this adds great value to Koha. I have some minor comments which I don't think are blockers and up to you Johanna if you feel they're worth following up on or not! 1) FIXME: in holds_table.inc I think we can remove this about form-submit.js as is included in js_includes.inc so should be always available everywhere. 2) request.tt and request.pl It appears 'total_holds' is replacing 'reserveloop'. If this is the case, we should cleanup the remaining instances of reserveloop in both files. 3) Could use new API tests under 'edit' in t/db_dependent/api/v1/holds.t to test new params (item_level, item_id) 4) Hold::item_level_holds missing tests, possibly better renamed to item_level_holds_count -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 --- Comment #53 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 193199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193199&action=edit Bug 23269: (follow-up) Add tests for item_level and item_id in holds API This patch adds tests for the item_level and item_id parameters in the holds API. It also updates the C4/Reserves.pm module to handle these parameters correctly. Test plan: 1. prove t/db_dependent/api/v1/holds.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 --- Comment #55 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- I implemented the changes that Pedro suggested and added more tests. The QA tool is complaining about tidiness. I fixed the issues in the files I modified, but it wants to fix more lines especially in t/db_dependent/api/v1/holds.t" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193200|0 |1 is obsolete| | --- Comment #57 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 193201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193201&action=edit Bug 23269: (follow-up) Rename to item_level_holds_count and add tests I fixed the trailing whitespace, hope it will work now. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 --- Comment #59 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- (In reply to Pedro Amorim from comment #58)

Still not applying for me, when trying: git apply --reject <patch_file_name> I see error on holds.js not hold.yaml despite the sha1 error.

Do you have Nick's patch applied? Bug 23269: (follow-up) Check if hold item_level before grabbing barcode

Oh, I missed that. Thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 --- Comment #61 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Thank you so much for following up with my suggestions. I think this is ready to go. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 --- Comment #64 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- *** Bug 28964 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 --- Comment #65 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 194518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194518&action=edit Bug 23269: (RM follow-up): Tidy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 --- Comment #67 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 194617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194617&action=edit Bug 23269: (follow-up) Remove form action from existing_holds This patch removes the form action from extisting_holds form. The actions are made with REST API and the form action is not needed anymore. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41801 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41801 [Bug 41801] FixPriority recursive calls for lowestPriority holds can be removed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42343 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42343 [Bug 42343] JS error holdsQueueTable is undefined when no holds exist -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42909 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42909 [Bug 42909] Suspend class missing from suspended holds on request.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42916 [Bug 42916] Cannot modify hold expiration date with only place_holds permission -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #71 from Jonathan Druart <jonathan.druart@gmail.com> --- There are some things that are not done correctly here. 1. JS variables not escaped 2. Global search not working. Reported on bug 42915 for the patron but there is also the date and the library. 3. Use of $.ajax directly, now the use of HttpClient is required (see js/fetch/*) 4. "Loading..." not translatable 5. Tests are missing (for embeds). Cypress tests should be provided for such big UI change. Not sure the changes to Koha::Hold->store (and _set_default_expirationdate) are covered by test. 6. What's that for? 1318 language: { 1319 infoFiltered: "", 1320 }, -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.