https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 AspenCat Team <aspencatteam@clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam@clicweb.org --- Comment #1 from AspenCat Team <aspencatteam@clicweb.org> --- This would be very helpful for our libraries that are accustomed to using the advanced search. - Bob Bennhoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 99650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99650&action=edit Bug 24155: Make wieghting an option on advanced search Currently we apply weighting to all searches except advanced search. The theory being that when selecting indexes we don't want to apply weights. When searching in ES weights are only applied to relevant results so it doesn't matter. i.e. if weighting author*100 but searching subject, a term matching the subject search in author is not boosted. Given this, we should always apply weights, unless the user wishes not to To test: 1 - Set some weighting 2 - Do some searches 3 - Note your terms and results, try advanced and regular searches specifying indexes or not 4 - Apply patch 5 - Note that opac and staff advanced search have option to apply weights 6 - Compare searches after the patch to see how weighting affects, it should be beneficial or not at all -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com, | |ere.maijala@helsinki.fi, | |mkstephens@lancasterseminar | |y.edu Summary|Weights should be applied |Weights should be |to Advanced search if no |(optionally) applied to |indexes have been selected |Advanced search -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99650|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 99667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99667&action=edit Bug 24155: Make wieghting an option on advanced search Currently we apply weighting to all searches except advanced search. The theory being that when selecting indexes we don't want to apply weights. When searching in ES weights are only applied to relevant results so it doesn't matter. i.e. if weighting author*100 but searching subject, a term matching the subject search in author is not boosted. Given this, we should always apply weights, unless the user wishes not to To test: 1 - Set some weighting 2 - Do some searches 3 - Note your terms and results, try advanced and regular searches specifying indexes or not 4 - Apply patch 5 - Note that opac and staff advanced search have option to apply weights 6 - Compare searches after the patch to see how weighting affects, it should be beneficial or not at all -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #5 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- I would also like to add that as I was doing my base-line testing for this bug, I found something interesting. When clicking on a record in the result list, then clicking on the button to return to the results, the search re-executes and applies weights. If a user had performed a search using advanced search where weights are not applied, then used the button to return to the results list, they would find that the results were in a different order. The work-around is to just use the browser's back button to return to the advanced search results list. If we're giving people the option to apply weights to the advanced search, however, this inconsistency will continue to happen unless there's a way to specify the return to results link to go back to the previous results instead of launching a new search. I did notice that there is a search_id value in the URL when the search re-executes that is not there in the URL for the advanced search: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?advsearch=1&idx=kw&q=computer&op=and&idx=kw&q=program*&op=and&idx=kw&sort_by=relevance vs. http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=kw&q=computer&op=and&idx=kw&q=program*&op=and&idx=kw&searchid=scs_1583197470738&offset=0 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99667|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100959&action=edit Bug 24155: Make wieghting an option on advanced search Currently we apply weighting to all searches except advanced search. The theory being that when selecting indexes we don't want to apply weights. When searching in ES weights are only applied to relevant results so it doesn't matter. i.e. if weighting author*100 but searching subject, a term matching the subject search in author is not boosted. Given this, we should always apply weights, unless the user wishes not to To test: 1 - Set some weighting 2 - Do some searches 3 - Note your terms and results, try advanced and regular searches specifying indexes or not 4 - Apply patch 5 - Note that opac and staff advanced search have option to apply weights 6 - Compare searches after the patch to see how weighting affects, it should be beneficial or not at all -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100959|0 |1 is obsolete| | --- Comment #7 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Created attachment 104441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104441&action=edit Bug 24155: Make wieghting an option on advanced search Currently we apply weighting to all searches except advanced search. The theory being that when selecting indexes we don't want to apply weights. When searching in ES weights are only applied to relevant results so it doesn't matter. i.e. if weighting author*100 but searching subject, a term matching the subject search in author is not boosted. Given this, we should always apply weights, unless the user wishes not to To test: 1 - Set some weighting 2 - Do some searches 3 - Note your terms and results, try advanced and regular searches specifying indexes or not 4 - Apply patch 5 - Note that opac and staff advanced search have option to apply weights 6 - Compare searches after the patch to see how weighting affects, it should be beneficial or not at all Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- With this patch, weights don't seem to be applied in a basic search. To recreate (in the default data for master): 1 - verify you're using ES and have no weights set 2 - do a basic search for "music" 3 - Note your top three results are "New Musical Express," "Miles Davis," and "All Music Guide to Soul" 4 - Enter 100 in weights for title index 5 - Reload your search 6 - Note your top three results are now "New Musical Express," "All Music Guide to Soul," and "Music Theory for Dummies." 7 - Apply patch 8 - Reload search and see you're back to your results ordering from step 3 9 - go to advanced search, perform a keyword search for "music" with "Apply field weightings to search" box checked 10 - Note these results match what's in step 6 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 105033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105033&action=edit Bug 24155: Apply wieghts if not advanced search -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105033|0 |1 is obsolete| | --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 105039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105039&action=edit Bug 24155: Apply wieghts if not advanced search Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105039|0 |1 is obsolete| | --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 105042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105042&action=edit Bug 24155: Apply wieghts if not advanced search Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109264&action=edit OPAC advanced search with weight search option -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Do you have some suggestions for a good weighting configuration to test with? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #19)

When I try to add weights, I have:

An error occurred when updating Elasticsearch index mappings: Unable to update mappings for index "koha_kohadev_biblios". Reason was: "Can't parse [index] value [] for field [copynumber__sort], expected [true] or [false]". Index needs to be recreated and reindexed. An error occurred when updating Elasticsearch index mappings: Unable to update mappings for index "koha_kohadev_authorities". Reason was: "Can't parse [index] value [] for field [personal-name-heading__sort], expected [true] or [false]". Index needs to be recreated and reindexed. Index '' needs to be recreated. Index '' needs to be recreated.

I've tried resetting the mappings, but same errors.

I do not recreate, it sounds like your indexes aren't there, have you indexed in ES? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, giving this another go: - Testing on kohadevbox - reset_all - nice and fresh database - kshell - Reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -r - Preference SearchEngine set to Elasticsearch - Searching in staff - successful - Administration > Elasticsearch - Trying to set the suggested weight configuration, starting with: title: 32 On first tab, only entered the number and then hit Save. An error occurred when updating Elasticsearch index mappings: Unable to update mappings for index "koha_kohadev_biblios". Reason was: "Can't parse [index] value [] for field [date-of-publication__sort], expected [true] or [false]". Index needs to be recreated and reindexed. An error occurred when updating Elasticsearch index mappings: Unable to update mappings for index "koha_kohadev_authorities". Reason was: "Can't parse [index] value [] for field [match-heading-see-from__sort], expected [true] or [false]". Index needs to be recreated and reindexed. Index '' needs to be recreated. Index '' needs to be recreated. :( -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109360&action=edit Bug 24155: (follow-up) Add span with id to wieghted search option -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105041|0 |1 is obsolete| | Attachment #105042|0 |1 is obsolete| | Attachment #109360|0 |1 is obsolete| | Attachment #110405|0 |1 is obsolete| | --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 110406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110406&action=edit Bug 24155: Make wieghting an option on advanced search Currently we apply weighting to all searches except advanced search. The theory being that when selecting indexes we don't want to apply weights. When searching in ES weights are only applied to relevant results so it doesn't matter. i.e. if weighting author*100 but searching subject, a term matching the subject search in author is not boosted. Given this, we should always apply weights, unless the user wishes not to To test: 1 - Set some weighting 2 - Do some searches 3 - Note your terms and results, try advanced and regular searches specifying indexes or not 4 - Apply patch 5 - Note that opac and staff advanced search have option to apply weights 6 - Compare searches after the patch to see how weighting affects, it should be beneficial or not at all Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #29 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 110408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110408&action=edit Bug 24155: (follow-up) Add span with id to wieghted search option -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110432&action=edit Bug 24155: Apply weights if not advanced search Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110434&action=edit Bug 24155: (follow-up) Template fixes and updates This patch makes a few minor changes to the OPAC and staff interface templates: - In both, the "Apply field weights" checkbox will only appear after the "More options" button has been clicked. Otherwise a hidden input sets the value to 1. - In both, the checkbox now appears below the search fields. - Checkboxes are now wrapped in the <label> tag to ensure the label is clickable. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We have a failure, can you have a look please? t/db_dependent/www/search_utf8.t .. 24/99 # Failed test 'Base is like "(?^u:opac-search.pl\?(idx=&)?q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)"' # at t/db_dependent/www/search_utf8.t line 300. # got: "http://koha:8080/cgi-bin/koha/opac-search.pl?weigh"... # length: 93 # doesn't match '(?^u:opac-search.pl\?(idx=&)?q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)' t/db_dependent/www/search_utf8.t .. 57/99 # Failed test 'Base is like "(?^u:opac-search.pl\?(idx=&)?q=Ram%C3%B2n)"' # at t/db_dependent/www/search_utf8.t line 300. # got: "http://koha:8080/cgi-bin/koha/opac-search.pl?weigh"... # length: 73 # doesn't match '(?^u:opac-search.pl\?(idx=&)?q=Ram%C3%B2n)' t/db_dependent/www/search_utf8.t .. 89/99 # Failed test 'Base is like "(?^u:opac-search.pl\?(idx=&)?q=%F0%A0%BB%BAtomasito%F0%A0%BB%BA)"' # at t/db_dependent/www/search_utf8.t line 300. # got: "http://koha:8080/cgi-bin/koha/opac-search.pl?weigh"... # length: 95 # doesn't match '(?^u:opac-search.pl\?(idx=&)?q=%F0%A0%BB%BAtomasito%F0%A0%BB%BA) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #39 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.