[Bug 39810] New: Use select2 to select library limitations in credit and debit type administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39810 Bug ID: 39810 Summary: Use select2 to select library limitations in credit and debit type administration Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Like Bug 39099. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39810 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181968&action=edit Bug 39810: Use select2 to select library limitations in credit and debit type administration This patch updates the credit and debit type administration templates so that library selection uses a Select2-styled menu instead of a standard <select>. Both pages offer a "library limitation" option, and Select2 will make library selection behave like item search options do. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Credit types edit a credit type. - On the "Library limitation" line, click the field to trigger the Select2 menu. Confirm that it works as expected. - Save your changes to confirm that the data is saved correctly. - Edit the credit type again to clear all your selections and confirm that it saves correctly. - Repeat the same process on the debit types page. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39810 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39810 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181968|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 182132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182132&action=edit Bug 39810: Use select2 to select library limitations in credit and debit type administration This patch updates the credit and debit type administration templates so that library selection uses a Select2-styled menu instead of a standard <select>. Both pages offer a "library limitation" option, and Select2 will make library selection behave like item search options do. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Credit types edit a credit type. - On the "Library limitation" line, click the field to trigger the Select2 menu. Confirm that it works as expected. - Save your changes to confirm that the data is saved correctly. - Edit the credit type again to clear all your selections and confirm that it saves correctly. - Repeat the same process on the debit types page. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39810 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This improves the selection release notes| |of the valuses for the | |'Libraries limitation' | |field when adding and | |editing: | |- Debit types | |- | |Credit types | | | |(Instead of | |selecting multiple values | |from a dropdown list using | |the Ctrl key, you can | |either select or start | |typing the value, select or | |press enter, then repeat to | |select additional values.) CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39810 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This improves the selection |This improves the selection release notes|of the valuses for the |of the values for the |'Libraries limitation' |'Libraries limitation' |field when adding and |field when adding and |editing: |editing: |- Debit types |- Debit types |- |- |Credit types |Credit types | | |(Instead of |(Instead of |selecting multiple values |selecting multiple values |from a dropdown list using |from a dropdown list using |the Ctrl key, you can |the Ctrl key, you can |either select or start |either select or start |typing the value, select or |typing the value, select or |press enter, then repeat to |press enter, then repeat to |select additional values.) |select additional values.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39810 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182132|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182521&action=edit Bug 39810: Use select2 to select library limitations in credit and debit type administration This patch updates the credit and debit type administration templates so that library selection uses a Select2-styled menu instead of a standard <select>. Both pages offer a "library limitation" option, and Select2 will make library selection behave like item search options do. To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Credit types edit a credit type. - On the "Library limitation" line, click the field to trigger the Select2 menu. Confirm that it works as expected. - Save your changes to confirm that the data is saved correctly. - Edit the credit type again to clear all your selections and confirm that it saves correctly. - Repeat the same process on the debit types page. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39810 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk CC| |martin.renvoize@openfifth.c | |o.uk Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39810 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39810 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |jonathan.druart@gmail.com --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- With ktd sample data: http://localhost:8081//cgi-bin/koha/admin/debit_types.pl Uncaught TypeError: $(...)[0] is undefined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39810 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39957 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39957 [Bug 39957] Fix JS error on credit and debit types administration pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39810 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> ---
Uncaught TypeError: $(...)[0] is undefined
See Bug 39957 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This improves the selection |This improves the selection release notes|of the values for the |of the values for the |'Libraries limitation' |'Libraries limitation' |field when adding and |field when adding and |editing: |editing: |- Debit types |- Debit types |- |- |Credit types |Credit types | | |(Instead of |Instead of |selecting multiple values |selecting multiple values |from a dropdown list using |from a dropdown list using |the Ctrl key, you can |the Ctrl key, you can |either select or start |either select or start |typing the value, select or |typing the value, select or |press enter, then repeat to |press enter, then repeat to |select additional values.) |select additional values. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39810 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org