[Bug 21522] New: Labels incorrectly inheriting some default Bootstrap style properties
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21522 Bug ID: 21522 Summary: Labels incorrectly inheriting some default Bootstrap style properties Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Our global staff client CSS should override more of Bootstrap's default label styling than it does at the moment. This is causing problems because part of the Bootstrap style is "white-space: nowrap" which prevents long text from wrapping. From the mailing list: "I’ve noticed that there’s a translation too long in french in catalogue/moredetail.pl so it’s unreadable. Cf image. Is there’s something to change in the code to allow a longer but clearer translation : Accession date -> Date d'entrée dans les collections" http://lists.koha-community.org/pipermail/koha-devel/2018-October/044845.htm... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21522 e.betemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21522 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset@biblibre.co | |m --- Comment #1 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Is the CSS that you proposed in the mailing list enough to fix this in a patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21522 --- Comment #2 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Thanks for this by the way :) I confirm that it works. In intranetUserCSS syspref: // To remove when the following bugzilla ticket will be finished and deployed // https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21522 ol.bibliodetails li { clear: left; } .label { white-space: normal; border-radius: 0; text-align: left; line-height: inherit; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21522 --- Comment #3 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 82913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82913&action=edit new CSS fix The previous intranetUserCSS workaround was causing a minor issue. Here is a simpler one which doesn't cause the wrapped text to cross the delimiter of the next line. /* To remove when the following bugzilla ticket will be finished and deployed */ /* https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21522 */ body#catalog_moredetail ol.bibliodetails span.label { width: 18em; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21522 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #4 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- @Oleonard: Is the visual result okay for you? (attached screenshot) If so, I can try to add that in Koha's CSS to submit a patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21522 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Still valid ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21522 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|In Discussion |RESOLVED --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- This issue appears to have been fixed. The labels discussed in the original question are now wrapping correctly. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org