[Bug 41987] New: addbooks.tt has duplicate IDs searchresult-breeding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 Bug ID: 41987 Summary: addbooks.tt has duplicate IDs searchresult-breeding Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl In addbooks.tt there can be two instances of the ID #searchresult-breeding in the generated html. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 Artur Mickiewicz <davno_pora@mail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |davno_pora@mail.com --- Comment #1 from Artur Mickiewicz <davno_pora@mail.com> --- Created attachment 197960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197960&action=edit Remove duplicate searchresult-breeding id in addbooks.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@openfifth.co.uk Assignee|koha-bugs@lists.koha-commun |davno_pora@mail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Thanks for looking at this Artur. Owen, is this one you could take a look at signing off please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 198207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198207&action=edit Bug 41987: Remove duplicate searchresult-breeding id The searchresult-breeding id was present on both the wrapper div and the "no results" alert element, causing duplicate id usage in the DOM. This patch ensures the id is only used once on the parent container and keeps the anchor link functional. Signed-off-by: Artur Mickiewicz <davno_pora@mail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #197960|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Comment on attachment 197960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197960 Remove duplicate searchresult-breeding id in addbooks.tt Have "converted"/attached the .patch file into something that can be used with koha-testing-docker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198207|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 198208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198208&action=edit Bug 41987: Remove duplicate searchresult-breeding id The searchresult-breeding id was present on both the wrapper div and the "no results" alert element, causing duplicate id usage in the DOM. This patch ensures the id is only used once on the parent container and keeps the anchor link functional. Signed-off-by: Artur Mickiewicz <davno_pora@mail.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 --- Comment #6 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Not sure how to actually generate the alert so that I can check the HTML source for duplicate IDs. 2. Instead, I used: git grep "searchresult-breeding" 3. Before the patch, there were four results (all for addbooks.tt), with two results with an ID. 4. After the patch, there were three results, now with only one with an ID. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 --- Comment #7 from David Nind <david@davidnind.com> --- Additional notes: 1. To process the original .patch file, I: - Downloaded the attachment - Saved in my koha git clone - In the ktd shell: git am 0001-Bug-41987-Remove-duplicate-searchresult-breeding-id.patch - Attached to the bug: git bz attach 41987 HEAD - Obsoleted the .patch file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |blawlor@clamsnet.org |y.org | Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA --- Comment #8 from Brendan Lawlor <blawlor@clamsnet.org> --- Simple fix, passing QA! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198208|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 --- Comment #9 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 199970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199970&action=edit Bug 41987: Remove duplicate searchresult-breeding id The searchresult-breeding id was present on both the wrapper div and the "no results" alert element, causing duplicate id usage in the DOM. This patch ensures the id is only used once on the parent container and keeps the anchor link functional. Signed-off-by: Artur Mickiewicz <davno_pora@mail.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 --- Comment #10 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #12 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Not sure if this patch should be backported to 25.11.x, code looks different, do you know if the bug is old or was introduced recently. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.01 |26.11.00,26.05.01,25.11.07 released in| | --- Comment #13 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.07 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41987 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- This is minor, lets skip backport on older versions -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org