[Bug 11242] New: fix opac-MARCdetail.pl bizarre ordering of data and noisy warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11242 Bug ID: 11242 Summary: fix opac-MARCdetail.pl bizarre ordering of data and noisy warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org If the framework used by an MARC record does not have fields defined which were imported (e.g. imported 852$9, but BKS does not have that defined), the missing information generates a '--' as part of the OPAC description in 'MARC view', but separated from data to be displayed which is defined. This is in part due to the choice of || 0, instead of calculating the tab based on the tag (e.g. 852 => tab 8). Additionally, this || 0 part happens in part because of a variable being undef, which causes some noisiness in the logs. So any undef potentially setting code related to $sf_def will be made less noisy. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11242 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11183 Assignee|oleonard@myacpl.org |mtompset@hotmail.com Severity|enhancement |minor --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- This bug deals with the opac-MARCdetail noisiness that was found while trying to clean up OPAC noise in bug 11183. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11242 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 22915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22915&action=edit Bug 11242 - fix opac-MARCdetail.pl display and warnings BACK UP YOUR DATABASE! 1) Search for an item in OPAC 2) Open OPAC detail 3) Click 'MARC View' link 4) Look for something with multiple lines (e.g. 260 or 942) 5) In another tab, Go to staff client and log in 6) Go to the /cgi-bin/koha/catalogue/detail.pl?biblionumber=##### page 7) Edit -> record 8) Note the framework used. 9) More -> Administration 10) MARC bibliographic frameworks 11) Click 'MARC structure' for the framework used by the item shown in OPAC. 12) Find the tag (e.g. 260 or 942) and click 'Subfields' 13) Delete of the matching subfields shown in the OPAC tab -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11242 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22915|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 22916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22916&action=edit Bug 11242 - fix opac-MARCdetail.pl display and warnings BACK UP YOUR DATABASE! 1) Search for an item in OPAC 2) Open OPAC detail 3) Click 'MARC View' link 4) Look for something with multiple lines (e.g. 260 or 942) 5) In another tab, Go to staff client and log in 6) Go to the /cgi-bin/koha/catalogue/detail.pl?biblionumber=##### page 7) Edit -> record 8) Note the framework used. 9) More -> Administration 10) MARC bibliographic frameworks 11) Click 'MARC structure' for the framework used by the item shown in OPAC. 12) Find the tag (e.g. 260 or 942) and click 'Subfields' 13) Delete of the matching subfields (e.g. 260$b) shown in the OPAC tab 14) Refresh OPAC tab. The tag subfields are split. 15) Apply patch 16) Refresh OPAC tab. The tag subfields are no longer split strangely. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11242 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22916|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 22922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22922&action=edit Bug 11242 - fix opac-MARCdetail.pl display and warnings BACK UP YOUR DATABASE! 1) Search for an item in OPAC 2) Open OPAC detail 3) Click 'MARC View' link 4) Look for something with multiple lines (e.g. 260 or 942) 5) In another tab, Go to staff client and log in 6) Go to the staff client URL similar to: /cgi-bin/koha/catalogue/detail.pl?biblionumber=##### page where ##### is the biblionumber. 7) Edit -> record 8) Note the framework used. 9) More -> Administration 10) MARC bibliographic frameworks 11) Click 'MARC structure' for the framework used by the item shown in OPAC. 12) Find the tag (e.g. 260 or 942) and click 'Subfields' 13) Delete of the matching subfields (e.g. 260$b) shown in the OPAC tab 14) Clear your opac error log. 15) Refresh OPAC tab. The tag subfields are split. 16) There are opac-MARCdetail.pl warnings. 17) Apply patch 18) Clear your opac error log. 19) Refresh OPAC tab. The tag subfields are no longer split strangely. 20) There are no opac-MARCdetail.pl warnings. RESTORE YOUR DATABASE. This also silences a series of warnings triggered by catching undef hash references. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11242 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11242 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11242 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22922|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 22969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22969&action=edit [SIGNED-OFF] Bug 11242 - fix opac-MARCdetail.pl display and warnings BACK UP YOUR DATABASE! 1) Search for an item in OPAC 2) Open OPAC detail 3) Click 'MARC View' link 4) Look for something with multiple lines (e.g. 260 or 942) 5) In another tab, Go to staff client and log in 6) Go to the staff client URL similar to: /cgi-bin/koha/catalogue/detail.pl?biblionumber=##### page where ##### is the biblionumber. 7) Edit -> record 8) Note the framework used. 9) More -> Administration 10) MARC bibliographic frameworks 11) Click 'MARC structure' for the framework used by the item shown in OPAC. 12) Find the tag (e.g. 260 or 942) and click 'Subfields' 13) Delete of the matching subfields (e.g. 260$b) shown in the OPAC tab 14) Clear your opac error log. 15) Refresh OPAC tab. The tag subfields are split. 16) There are opac-MARCdetail.pl warnings. 17) Apply patch 18) Clear your opac error log. 19) Refresh OPAC tab. The tag subfields are no longer split strangely. 20) There are no opac-MARCdetail.pl warnings. RESTORE YOUR DATABASE. This also silences a series of warnings triggered by catching undef hash references. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11242 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Not sure to reproduce correctly the issue: - choose a biblio, edit and add a value in 686$a - delete the subfield 686$a in the framework - go at the OPAC (marc view), I get: 686 ## - classification -- existe pas 101 ## - Langue langue doc. Français I apply the patch, I get: 101 ## - Langue langue doc. Français 686 ## - classification -- existe pas I certainly miss something... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11242 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 23071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23071&action=edit Screenshots of my tests. I have attached a zip file of 5 screen shots. Framework_Before.jpg - display showing a, b, and c subfields for 260. Framework_After.jpg - display showing that 'b' was deleted. OPAC_BeforeBreak.jpg - initial OPAC display (only 1 260 block displayed) OPAC_AfterBreak.jpg - display after 'b' is deleted (2 260 blocks displayed). OPAC_AfterPatch.jpg - display after patch is applied (1 260 block displayed). This 'deleting' of 260$b, would be the same if one changed the framework to not include something which is in the MARC for that record. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11242 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11242 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22969|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23100&action=edit Bug 11242 - fix opac-MARCdetail.pl display and warnings BACK UP YOUR DATABASE! 1) Search for an item in OPAC 2) Open OPAC detail 3) Click 'MARC View' link 4) Look for something with multiple lines (e.g. 260 or 942) 5) In another tab, Go to staff client and log in 6) Go to the staff client URL similar to: /cgi-bin/koha/catalogue/detail.pl?biblionumber=##### page where ##### is the biblionumber. 7) Edit -> record 8) Note the framework used. 9) More -> Administration 10) MARC bibliographic frameworks 11) Click 'MARC structure' for the framework used by the item shown in OPAC. 12) Find the tag (e.g. 260 or 942) and click 'Subfields' 13) Delete of the matching subfields (e.g. 260$b) shown in the OPAC tab 14) Clear your opac error log. 15) Refresh OPAC tab. The tag subfields are split. 16) There are opac-MARCdetail.pl warnings. 17) Apply patch 18) Clear your opac error log. 19) Refresh OPAC tab. The tag subfields are no longer split strangely. 20) There are no opac-MARCdetail.pl warnings. RESTORE YOUR DATABASE. This also silences a series of warnings triggered by catching undef hash references. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11242 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Mark! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11242 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #10 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- This patch has been pushed to 3.14.x, will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11242 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org