[Bug 27252] New: ES5 no longer supported (since 20.11.00)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Bug ID: 27252 Summary: ES5 no longer supported (since 20.11.00) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: nick@bywatersolutions.com Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Since 20.11.00 and bug 27070 we dropped the support for ES5. We should add a warning on the about page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27070 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27070 [Bug 27070] Elasticsearch - with Elasticsearch 6 searches failing unless all terms are in the same field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114466&action=edit Bug 27252: Add deprecation warning, cross_fields pref, and add version to ES info This patch prepares Koha to officially no longer support Elasticsearch 5.X It adds a new system preference 'ElasticsearchCrossFields' to allow users to choose whether or not to enable this feature It updates the about page to add a deprecation warning if a site is running ES5 To test: 1 - Be running Koha with Elasticsearch 5.X 2 - Attempt to search Error: Unable to perform your search. Please try again. 3 - Apply patch 4 - Update database 5 - Searching works 6 - Find syspref 'ElasticsearchCrossFields' 7 - Enable it 8 - Searching is now broken 9 - Check the about page 10 - you can now see the Elasticsearch version 11 - The systeminformation tab has a deprectaion warning 12 - Set SearchEngine preference to 'Zebra' 13 - View the about page - no warnings 14 - Test again with ES6 - searching should "work" with either pref setting 15 - There should be no warning on about pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Shouldn't we turn the feature on for master and 20.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It's seems that all the CI jobs are using ES6 so the tests should fail with this off by default. prove -r t/Koha/SearchEngine/Elasticsearch* t/db_dependent/Koha_Elasticsearch.t t/Koha_SearchEngine_Elasticsearch_Browse.t t/db_dependent/Koha/SearchEngine/ It turns out not :o -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Bug 27070 did not add tests so I don't know which tests would be supposed to fail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I thought searching with ES6 would be broken by default. And thus that some tests would fail. Because the syspref would allow to choose to have ES 6 working or ES 5 working and would default to ES 5. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #5)
I thought searching with ES6 would be broken by default. And thus that some tests would fail. Because the syspref would allow to choose to have ES 6 working or ES 5 working and would default to ES 5.
After bug 27070 ES5 searching was broken. This patch retores the ability to use ES5 - since Jenkins was using 6 everywhere, there was no problem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Alright, I missed «with ES6 - searching should "work" with either pref setting» Thanks for the explanations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114466|0 |1 is obsolete| | --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 114553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114553&action=edit Bug 27252: Add deprecation warning, cross_fields pref, and add version to ES info This patch prepares Koha to officially no longer support Elasticsearch 5.X It adds a new system preference 'ElasticsearchCrossFields' to allow users to choose whether or not to enable this feature It updates the about page to add a deprecation warning if a site is running ES5 To test: 1 - Be running Koha with Elasticsearch 5.X 2 - Attempt to search Error: Unable to perform your search. Please try again. 3 - Apply patch 4 - Update database 5 - Searching works 6 - Find syspref 'ElasticsearchCrossFields' 7 - Enable it 8 - Searching is now broken 9 - Check the about page 10 - you can now see the Elasticsearch version 11 - The systeminformation tab has a deprectaion warning 12 - Set SearchEngine preference to 'Zebra' 13 - View the about page - no warnings 14 - Test again with ES6 - searching should "work" with either pref setting 15 - There should be no warning on about pages Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Nice changes thanks :) Should it be recommended to enable ElasticsearchCrossFields when using ES 6? To not have bug 27070 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Victor Grousset/tuxayo from comment #9)
Should it be recommended to enable ElasticsearchCrossFields when using ES 6? To not have bug 27070
Yes, see comment 2. I think it should be turned on by default. Nick, what do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114553|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114672&action=edit Bug 27252: Add deprecation warning, cross_fields pref, and add version to ES info This patch prepares Koha to officially no longer support Elasticsearch 5.X It adds a new system preference 'ElasticsearchCrossFields' to allow users to choose whether or not to enable this feature It updates the about page to add a deprecation warning if a site is running ES5 To test: 1 - Be running Koha with Elasticsearch 5.X 2 - Attempt to search Error: Unable to perform your search. Please try again. 3 - Apply patch 4 - Update database 5 - Searching works 6 - Find syspref 'ElasticsearchCrossFields' 7 - Enable it 8 - Searching is now broken 9 - Check the about page 10 - you can now see the Elasticsearch version 11 - The systeminformation tab has a deprectaion warning 12 - Set SearchEngine preference to 'Zebra' 13 - View the about page - no warnings 14 - Test again with ES6 - searching should "work" with either pref setting 15 - There should be no warning on about pages Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114673&action=edit Bug 27252: [20.05 and earlier] Default to cross fields off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #2)
Shouldn't we turn the feature on for master and 20.11?
Yes, amended patch and attached followup for earlier versions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114672|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 114878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114878&action=edit Bug 27252: Add deprecation warning, cross_fields pref, and add version to ES info This patch prepares Koha to officially no longer support Elasticsearch 5.X It adds a new system preference 'ElasticsearchCrossFields' to allow users to choose whether or not to enable this feature It updates the about page to add a deprecation warning if a site is running ES5 To test: 1 - Be running Koha with Elasticsearch 5.X 2 - Attempt to search Error: Unable to perform your search. Please try again. 3 - Apply patch 4 - Update database 5 - Searching works 6 - Find syspref 'ElasticsearchCrossFields' 7 - Enable it 8 - Searching is now broken 9 - Check the about page 10 - you can now see the Elasticsearch version 11 - The systeminformation tab has a deprectaion warning 12 - Set SearchEngine preference to 'Zebra' 13 - View the about page - no warnings 14 - Test again with ES6 - searching should "work" with either pref setting 15 - There should be no warning on about pages Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114673|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 114881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114881&action=edit [20.05 and earlier] Bug 27252: Add deprecation warning, cross_fields pref, and add version to ES info This patch prepares Koha to officially no longer support Elasticsearch 5.X It adds a new system preference 'ElasticsearchCrossFields' to allow users to choose whether or not to enable this feature It updates the about page to add a deprecation warning if a site is running ES5 To test: 1 - Be running Koha with Elasticsearch 5.X 2 - Attempt to search Error: Unable to perform your search. Please try again. 3 - Apply patch 4 - Update database 5 - Searching works 6 - Find syspref 'ElasticsearchCrossFields' 7 - Enable it 8 - Searching is now broken 9 - Check the about page 10 - you can now see the Elasticsearch version 11 - The systeminformation tab has a deprectaion warning 12 - Set SearchEngine preference to 'Zebra' 13 - View the about page - no warnings 14 - Test again with ES6 - searching should "work" with either pref setting 15 - There should be no warning on about pages Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 114882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114882&action=edit [20.05 and earlier] Bug 27252: Default to cross fields off Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Text to go in the| |This prepares Koha to release notes| |officially no longer | |support Elasticsearch 5.X. | | | |It adds a new system | |preference | |'ElasticsearchCrossFields' | |to allow users to choose | |whether or not to enable | |this feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.02 released in| | --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.02 |21.05.00,20.11.02,20.05.07 released in| | --- Comment #19 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 19.11.x branch for 19.11.14 After some testing, the syspref has the expected effect with ES 5 and 6 However I can't see the deprecation warning. With ES 5 and syspref SearchEngine = elasticsearch, the about page shows "Version: 5.6.16" but no warning in the System information tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.02,20.05.07 |21.05.00,20.11.02,20.05.07, released in| |19.11.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #21 from Victor Grousset/tuxayo <victor@tuxayo.net> --- No warning in 20.05.x either but the warning is here in 20.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Victor Grousset/tuxayo from comment #21)
No warning in 20.05.x either but the warning is here in 20.11
You need bug 19542. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #23 from Victor Grousset/tuxayo <victor@tuxayo.net> --- We have the commits in 19.11.x and 20.05.x , since 18.05. The ES version info is here in the "Server information" tab of the about page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27770 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27448 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27448 [Bug 27448] Update ElasticsearchCrossFields description to explain consequences of setting in Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/575 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org