https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lisette Scheer from comment #24)

(In reply to Martin Renvoize from comment #23)

...

As for the --- digest thing, I feel like the logic for that one is backwards and strange.. we should be generating the notice all in one hit at a later point in time rather than queuing a notice and then munging extra stuff into it after the fact at various times.

The --- digest thing also doesn't make much sense to me. With putting it together at one point in time, would that mean that say for hold notices when notices send every hour that before that happened it would build and check for the patron any waiting holds that had been set to waiting since the last one?

Or perhaps we could set some sort of flag when the hold is trapped that gets cleared when the notice is sent?

I'd love to change the mechanic on how these notices are generated, but we should move this to a separate bug: Bug 36470 - Generate CHECKOUT, CHECKIN and HOLD digest notices should be generated at once, not amended over time When talking about the loops, I was actually thinking of the ACQORDER notice, as I had recently worked on that one :) It also has a weird way to detect repeatable sections, that does not even rely on the <order> tags, as you would think. Problem for another bug too. -- You are receiving this mail because: You are watching all bug changes.