[Bug 5429] New: Enable Koha to fetch book covers from openlibrary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5429 Summary: Enable Koha to fetch book covers from openlibrary Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: chris@bigballofwax.co.nz QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Openlibrary has an API very similair to google books, we should enable Koha to use it to fetch book covers -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5429 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Version|rel_3_4 |rel_3_6 Patch Status|--- |Needs Signoff --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-07-23 07:57:57 UTC --- Patch sent to the mailing list -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5429 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6624 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5429 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6625 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5429 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-07-23 08:11:23 UTC --- Created attachment 4723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4723 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5429 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-07-23 08:11:48 UTC --- Created attachment 4724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4724 Follow up patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5429 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4724|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-07-23 08:17:33 UTC --- Created attachment 4725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4725 Follow up patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5429 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |nengard@gmail.com Patch Status|Needs Signoff |Signed Off AssignedTo|oleonard@myacpl.org |chris@bigballofwax.co.nz --- Comment #5 from Nicole C. Engard <nengard@gmail.com> 2011-07-23 11:55:12 UTC --- I have signed off on these patches since they do what they say they do - but if there is any way to have bigger cover images I'd love to see a follow up patch that does that. The covers do appear a bit too small compared to other cover image services. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5429 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4723|0 |1 is obsolete| | --- Comment #6 from Magnus Enger <magnus@enger.priv.no> 2011-07-23 12:39:52 UTC --- Created attachment 4726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4726 Signed-off patch 1/2 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5429 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4725|0 |1 is obsolete| | --- Comment #7 from Magnus Enger <magnus@enger.priv.no> 2011-07-23 12:43:33 UTC --- Created attachment 4727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4727 Signed-off patch 2/2 The patches work as advertised, so I'm signing off. However, I think the "small" version of the covers is too small to be of much use, at least for the examples I have seen, e.g.: http://covers.openlibrary.org/b/id/227938-S.jpg The "medium" version is of course too big: http://covers.openlibrary.org/b/id/227938-S.jpg but would it be possible to use the medium version and scale it down somewhat, with CSS or dimensions set on the img tag? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5429 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #8 from Magnus Enger <magnus@enger.priv.no> 2011-07-23 12:44:44 UTC --- That last URL should of course be: http://covers.openlibrary.org/b/id/227938-M.jpg -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5429 --- Comment #9 from Nicole C. Engard <nengard@gmail.com> 2011-07-23 13:21:23 UTC --- Magnus, You repeated exactly what I said :) Glad I'm not alone. I did not however attach my signed off patches here ... just FYI. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5429 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4726|0 |1 is obsolete| | --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-03 14:23:07 UTC --- Created attachment 4822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4822 proposed patch (passed QA) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5429 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4727|0 |1 is obsolete| | --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-03 14:24:17 UTC --- Created attachment 4823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4823 proposed patch 2 (passed QA) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5429 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-03 14:26:08 UTC --- Created attachment 4824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4824 proposed patch 3 (passed QA) QA comment No comment, works fine, nothing to notice, except, as others, the size of the image, that is quite small. I've added a 3rd patch, with the version number (chris : 006, take care of applying the 005 i've validated a few hours ago before) I also have rebased the first one, for a small/easy to fix updatedatabase glitch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5429 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5429 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-04 01:34:17 UTC --- Have pushed, For future reference, it is easier/better for me if you leave the updatedabase as XXX and don't change the kohaversion I don't always apply them in the order you have numbered them, and its easier for me to just set the version when they are applied to master. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5429 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #14 from Nicole C. Engard <nengard@gmail.com> 2011-08-05 11:48:22 UTC --- opening a new ticket to recommend that the cover images be bigger, but this patch works as expected. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5429 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6672 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org