http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43161&action=edit Bug 14964 - Email notices will be queued for patrons with no email address If a patron has email messaging preferences set but no email address, a message will be added to the message queue anyway, but will always end up 'failed'. This could be resolved by modifying C4::Letters::enqueue to not enqueue call EnqueueLetter if the transport is email or sms and no to address is returned. Test Plan: 1) Set up patron with checkout messaging preference and no email address 2) Check out an item to the patron 3) Note the message in the message queue with no email address 4) Apply this patch 5) Check out an item to the patron 6) Note no message was queued this time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43161|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43162&action=edit Bug 14964 - Email notices will be queued for patrons with no email address If a patron has email messaging preferences set but no email address, a message will be added to the message queue anyway, but will always end up 'failed'. This could be resolved by modifying C4::Letters::enqueue to not enqueue call EnqueueLetter if the transport is email or sms and no to address is returned. Test Plan: 1) Set up patron with checkout messaging preference and no email address 2) Check out an item to the patron 3) Note the message in the message queue with no email address 4) Apply this patch 5) Check out an item to the patron 6) Note no message was queued this time -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Wondering... should we queue a message of the type 'print' if there is no e-mail address? I think this might be what we do for overdues -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- I cringe at the lack of test coverage for C4::Message. *sigh* -- You are receiving this mail because: You are watching all bug changes.