[Bug 20472] New: Working title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Bug ID: 20472 Summary: Working title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Working title |Add digital scan as | |optional format to Article | |Requests --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Have this patch set in test stage on 16.11. Plan to move them upwards after the 18.05 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20468 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 [Bug 20468] Multiselect on staff article requests form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20570 [Bug 20570] Add script to complete scanned article requests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Bug 20472 depends on bug 20468, which changed state. Bug 20468 Summary: Multiselect on staff article requests form https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20468 |20469 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 [Bug 20468] Multiselect on staff article requests form https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 [Bug 20469] Add item status to staff article requests form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 107506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107506&action=edit Bug 20472: Add new fields article_requests.format and urls The field 'format' will allow to make a distinction between requests for photocopies and digital scans. The field 'urls' will be used to save the URLs that allow the client to download the scanned materials. Test plan: Run new install or upgrade existing install with atomic update. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 107507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107507&action=edit Bug 20472: Db rev for new preference ArticleRequestsSupportedFormats This preference controls which formats are actually offered to patrons of the library via the Article Request feature. By default, it only contains PHOTOCOPY. This is default behavior. The request format SCAN will be made possible by this report and can be added by changing the preference. Test plan: Run the dbrev. Check the new pref on Administration. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 107508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107508&action=edit Bug 20472: Add format field to the interface We need to add the format to the forms entering new requests: opac/opac-request-article circ/request-article If the pref contains multiple formats like SCAN|PHOTOCOPY, the first listed format will be preselected on the request form. If there is only one option, we should not disable the select however. (Possibly hide it.) If we have no mandatory fields, we should not allow the submit of a complete empty form (check on OPAC). And we need to show the format of pending requests on forms: opac/opac-user circ/request-article (biblio detail tab) circ/article-requests (staff form to handle requests) members/moremember (Article requests tab at the bottom) circ/circulation (Checkout/Article requests tab) Note: The last two forms use the same include file. Test plan: [1] Add an article request via opac or staff. Choose Scan. [2] Verify that you see the Scan format on opac-user and the above-mentioned staff forms. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 107509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107509&action=edit Bug 20472: Add format to sample notices NOTE: We are only changing English here. A follow-up will care for the translated languages. (English is in yml format, the remainder not yet.) We need to change the following notices: AR_SLIP, AR_CANCELED, AR_PROCESSING, AR_PENDING and AR_COMPLETED. In AR_COMPLETED the last sentence about picking up has been modified too. Test plan: Reinstall Koha. Choose English. Check notice text. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 107510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107510&action=edit Bug 20472: Edit URL field on staff form This patch makes the following changes: Add menu option Edit URLs. Edit modal form to edit URLs. Save URLs via ajax call to svc/article_request (Add action update_urls). Add URL column to pending and processing table. Allow Edit URLs for pending table too (just as Complete). Do not allow 'Complete request' if a scan request has no URL(s). Test plan: [1] Add a few scan and photocopy requests. [2] Fill url-A and url-B in two separate scan requests. [3] Verify that these two urls are really saved (refresh form). [4] Check that you cannot complete a scan request without URL and that you cannot add a URL to a photocopy request. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 107511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107511&action=edit DO_NOT_PUSH: Change DBIx schema file ArticleRequest -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 107512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107512&action=edit Bug 20472: Update translated AR notices de-DE/mandatory/sample_notices.sql fr-CA/obligatoire/sample_notices.sql fr-FR/1-Obligatoire/sample_notices.sql it-IT/necessari/notices.sql nb-NO/1-Obligatorisk/sample_notices.sql pl-PL/mandatory/sample_notices.sql ru-RU/mandatory/sample_notices.sql uk-UA/mandatory/sample_notices.sql Test plan: Reinstall notices for one of the languages above. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Have run all sql files thru mysql on the command line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #1)
Have this patch set in test stage on 16.11. Plan to move them upwards after the 18.05 release.
The plan changed ;) This patch set has run in production on 16.11 and 18.05. And I rebased for 19.11 and master now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26088 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Adding bug 26088 as a see also (for now) on this report in order to address financial follow-up for such a service. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Can you explain more about how the URL field is supposed to be used? Where do the URLs come from? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Owen Leonard from comment #11)
Can you explain more about how the URL field is supposed to be used? Where do the URLs come from?
Good question. I leave some room for customization here too. (We use the AR slip and OCR to tag scanned files with the article request number. And then use opac/svc/requests (see bug 20570 follow-up) to add a Dropbox link to the request.) But bug 20570 also contains complete_article_requests.pl to match uploaded files in Koha with article requests. Apart from bug 20570, this development here allows you to manually add links (without saying how they were created indeed). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107506|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 111473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111473&action=edit Bug 20472: Add new fields article_requests.format and urls The field 'format' will allow to make a distinction between requests for photocopies and digital scans. The field 'urls' will be used to save the URLs that allow the client to download the scanned materials. Test plan: Run new install or upgrade existing install with atomic update. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107507|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 111474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111474&action=edit Bug 20472: Db rev for new preference ArticleRequestsSupportedFormats This preference controls which formats are actually offered to patrons of the library via the Article Request feature. By default, it only contains PHOTOCOPY. This is default behavior. The request format SCAN will be made possible by this report and can be added by changing the preference. Test plan: Run the dbrev. Check the new pref on Administration. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107508|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 111475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111475&action=edit Bug 20472: Add format field to the interface We need to add the format to the forms entering new requests: opac/opac-request-article circ/request-article If the pref contains multiple formats like SCAN|PHOTOCOPY, the first listed format will be preselected on the request form. If there is only one option, we should not disable the select however. (Possibly hide it.) If we have no mandatory fields, we should not allow the submit of a complete empty form (check on OPAC). And we need to show the format of pending requests on forms: opac/opac-user circ/request-article (biblio detail tab) circ/article-requests (staff form to handle requests) members/moremember (Article requests tab at the bottom) circ/circulation (Checkout/Article requests tab) Note: The last two forms use the same include file. Test plan: [1] Add an article request via opac or staff. Choose Scan. [2] Verify that you see the Scan format on opac-user and the above-mentioned staff forms. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107509|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 111476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111476&action=edit Bug 20472: Add format to sample notices NOTE: We are only changing English here. A follow-up will care for the translated languages. (English is in yml format, the remainder not yet.) We need to change the following notices: AR_SLIP, AR_CANCELED, AR_PROCESSING, AR_PENDING and AR_COMPLETED. In AR_COMPLETED the last sentence about picking up has been modified too. Test plan: Reinstall Koha. Choose English. Check notice text. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107510|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 111477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111477&action=edit Bug 20472: Edit URL field on staff form This patch makes the following changes: Add menu option Edit URLs. Edit modal form to edit URLs. Save URLs via ajax call to svc/article_request (Add action update_urls). Add URL column to pending and processing table. Allow Edit URLs for pending table too (just as Complete). Do not allow 'Complete request' if a scan request has no URL(s). Test plan: [1] Add a few scan and photocopy requests. [2] Fill url-A and url-B in two separate scan requests. [3] Verify that these two urls are really saved (refresh form). [4] Check that you cannot complete a scan request without URL and that you cannot add a URL to a photocopy request. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107511|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 111478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111478&action=edit DO_NOT_PUSH: Change DBIx schema file ArticleRequest -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107512|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 111479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111479&action=edit Bug 20472: Update translated AR notices de-DE/mandatory/sample_notices.sql fr-CA/obligatoire/sample_notices.sql fr-FR/1-Obligatoire/sample_notices.sql it-IT/necessari/notices.sql nb-NO/1-Obligatorisk/sample_notices.sql pl-PL/mandatory/sample_notices.sql ru-RU/mandatory/sample_notices.sql uk-UA/mandatory/sample_notices.sql Test plan: Reinstall notices for one of the languages above. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Have run all sql files thru mysql on the command line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Rebased. Please test ! Last submit waited three months. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27944 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This development is actually very important for us and received no interest from anyone since 2018. Obviously it did and does not apply anymore at some point in time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- CONFLICT (modify/delete): installer/data/mysql/uk-UA/mandatory/sample_notices.sql deleted in HEAD and modified in Bug 20472: Update translated AR notices. Version Bug 20472: Update translated AR notices of installer/data/mysql/uk-UA/mandatory/sample_notices.sql left in tree. CONFLICT (modify/delete): installer/data/mysql/ru-RU/mandatory/sample_notices.sql deleted in HEAD and modified in Bug 20472: Update translated AR notices. Version Bug 20472: Update translated AR notices of installer/data/mysql/ru-RU/mandatory/sample_notices.sql left in tree. CONFLICT (modify/delete): installer/data/mysql/pl-PL/mandatory/sample_notices.sql deleted in HEAD and modified in Bug 20472: Update translated AR notices. Version Bug 20472: Update translated AR notices of installer/data/mysql/pl-PL/mandatory/sample_notices.sql left in tree. I will leave these out now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- CONFLICT (modify/delete): installer/data/mysql/it-IT/necessari/notices.sql deleted in HEAD and modified in Bug 20472: Update translated AR notices. Version Bug 20472: Update translated AR notices of installer/data/mysql/it-IT/necessari/notices.sql left in tree. CONFLICT (modify/delete): installer/data/mysql/de-DE/mandatory/sample_notices.sql deleted in HEAD and modified in Bug 20472: Update translated AR notices. Version Bug 20472: Update translated AR notices of installer/data/mysql/de-DE/mandatory/sample_notices.sql left in tree. Could be added back later on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111473|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111474|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111475|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111476|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111477|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111478|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111479|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #9)
The plan changed ;) This patch set has run in production on 16.11 and 18.05. And I rebased for 19.11 and master now.
So I had this stuff on 16.11, 18.05, 19.11, 20.06 and 21.06 now :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Note for QA: Should we try to update existing notices here too ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122366&action=edit Bug 20472: Add new fields article_requests.format and urls The field 'format' will allow to make a distinction between requests for photocopies and digital scans. The field 'urls' will be used to save the URLs that allow the client to download the scanned materials. Test plan: Run new install or upgrade existing install with atomic update. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122367&action=edit Bug 20472: Db rev for new preference ArticleRequestsSupportedFormats This preference controls which formats are actually offered to patrons of the library via the Article Request feature. By default, it only contains PHOTOCOPY. This is default behavior. The request format SCAN will be made possible by this report and can be added by changing the preference. Test plan: Run the dbrev. Check the new pref on Administration. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122368&action=edit Bug 20472: Add format field to the interface We need to add the format to the forms entering new requests: opac/opac-request-article circ/request-article If the pref contains multiple formats like SCAN|PHOTOCOPY, the first listed format will be preselected on the request form. If there is only one option, we should not disable the select however. (Possibly hide it.) If we have no mandatory fields, we should not allow the submit of a complete empty form (check on OPAC). And we need to show the format of pending requests on forms: opac/opac-user circ/request-article (biblio detail tab) circ/article-requests (staff form to handle requests) members/moremember (Article requests tab at the bottom) circ/circulation (Checkout/Article requests tab) Note: The last two forms use the same include file. Test plan: [1] Add an article request via opac or staff. Choose Scan. [2] Verify that you see the Scan format on opac-user and the above-mentioned staff forms. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122369&action=edit Bug 20472: Edit URL field on staff form This patch makes the following changes: Add menu option Edit URLs. Edit modal form to edit URLs. Save URLs via ajax call to svc/article_request (Add action update_urls). Add URL column to pending and processing table. Allow Edit URLs for pending table too (just as Complete). Do not allow 'Complete request' if a scan request has no URL(s). Test plan: [1] Add a few scan and photocopy requests. [2] Fill url-A and url-B in two separate scan requests. [3] Verify that these two urls are really saved (refresh form). [4] Check that you cannot complete a scan request without URL and that you cannot add a URL to a photocopy request. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122370&action=edit Bug 20472: Add format to sample notices NOTE: We are only changing English here. A follow-up will care for the translated languages. (English is in yml format, the remainder not yet.) We need to change the following notices: AR_SLIP, AR_CANCELED, AR_PROCESSING, AR_PENDING and AR_COMPLETED. In AR_COMPLETED the last sentence about picking up has been modified too. Test plan: Reinstall Koha. Choose English. Check notice text. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122371&action=edit Bug 20472: Update translated AR notices Originally, we had: de-DE/mandatory/sample_notices.sql fr-CA/obligatoire/sample_notices.sql fr-FR/1-Obligatoire/sample_notices.sql it-IT/necessari/notices.sql nb-NO/1-Obligatorisk/sample_notices.sql pl-PL/mandatory/sample_notices.sql ru-RU/mandatory/sample_notices.sql uk-UA/mandatory/sample_notices.sql Obviously, the landscape changed in the meantime. We still have: fr-CA, fr-FR, nb-NO. Test plan: Reinstall notices for one of the languages above. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Have run all sql files thru mysql on the command line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122372&action=edit Bug 20472: [DO NOT PUSH] DBIx schema changes Refreshed 24-06-21 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122366|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122373&action=edit Bug 20472: Add new fields article_requests.format and urls The field 'format' will allow to make a distinction between requests for photocopies and digital scans. The field 'urls' will be used to save the URLs that allow the client to download the scanned materials. Test plan: Run new install or upgrade existing install with atomic update. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122367|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122374&action=edit Bug 20472: Db rev for new preference ArticleRequestsSupportedFormats This preference controls which formats are actually offered to patrons of the library via the Article Request feature. By default, it only contains PHOTOCOPY. This is default behavior. The request format SCAN will be made possible by this report and can be added by changing the preference. Test plan: Run the dbrev. Check the new pref on Administration. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122368|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122375&action=edit Bug 20472: Add format field to the interface We need to add the format to the forms entering new requests: opac/opac-request-article circ/request-article If the pref contains multiple formats like SCAN|PHOTOCOPY, the first listed format will be preselected on the request form. If there is only one option, we should not disable the select however. (Possibly hide it.) If we have no mandatory fields, we should not allow the submit of a complete empty form (check on OPAC). And we need to show the format of pending requests on forms: opac/opac-user circ/request-article (biblio detail tab) circ/article-requests (staff form to handle requests) members/moremember (Article requests tab at the bottom) circ/circulation (Checkout/Article requests tab) Note: The last two forms use the same include file. Test plan: [1] Add an article request via opac or staff. Choose Scan. [2] Verify that you see the Scan format on opac-user and the above-mentioned staff forms. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122369|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122376&action=edit Bug 20472: Edit URL field on staff form This patch makes the following changes: Add menu option Edit URLs. Edit modal form to edit URLs. Save URLs via ajax call to svc/article_request (Add action update_urls). Add URL column to pending and processing table. Allow Edit URLs for pending table too (just as Complete). Do not allow 'Complete request' if a scan request has no URL(s). Test plan: [1] Add a few scan and photocopy requests. [2] Fill url-A and url-B in two separate scan requests. [3] Verify that these two urls are really saved (refresh form). [4] Check that you cannot complete a scan request without URL and that you cannot add a URL to a photocopy request. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122370|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122377&action=edit Bug 20472: Add format to sample notices NOTE: We are only changing English here. A follow-up will care for the translated languages. (English is in yml format, the remainder not yet.) We need to change the following notices: AR_SLIP, AR_CANCELED, AR_PROCESSING, AR_PENDING and AR_COMPLETED. In AR_COMPLETED the last sentence about picking up has been modified too. Test plan: Reinstall Koha. Choose English. Check notice text. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122371|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122378&action=edit Bug 20472: Update translated AR notices Originally, we had: de-DE/mandatory/sample_notices.sql fr-CA/obligatoire/sample_notices.sql fr-FR/1-Obligatoire/sample_notices.sql it-IT/necessari/notices.sql nb-NO/1-Obligatorisk/sample_notices.sql pl-PL/mandatory/sample_notices.sql ru-RU/mandatory/sample_notices.sql uk-UA/mandatory/sample_notices.sql Obviously, the landscape changed in the meantime. We still have: fr-CA, fr-FR, nb-NO. Test plan: Reinstall notices for one of the languages above. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Have run all sql files thru mysql on the command line. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122372|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122379&action=edit Bug 20472: [DO NOT PUSH] DBIx schema changes Refreshed 24-06-21 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This works really nicely and the code is nice and clean.. Signing off. However.. QA script highlights some missing filters.. a quick follow-up should resolve those ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122379|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122382&action=edit Bug 20472: (QA follow-up) Add few TT filters Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> No more warns from qa tools. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #42 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122383&action=edit Bug 20472: [DO NOT PUSH] DBIx schema changes Refreshed 24-06-21 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #25)
Note for QA:
Should we try to update existing notices here too ?
No we have logs for notices changes, we could theoretically try.. but I don't see that as a blocker for this either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122373|0 |1 is obsolete| | --- Comment #44 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122699&action=edit Bug 20472: Add new fields article_requests.format and urls The field 'format' will allow to make a distinction between requests for photocopies and digital scans. The field 'urls' will be used to save the URLs that allow the client to download the scanned materials. Test plan: Run new install or upgrade existing install with atomic update. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122374|0 |1 is obsolete| | --- Comment #45 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122700&action=edit Bug 20472: Db rev for new preference ArticleRequestsSupportedFormats This preference controls which formats are actually offered to patrons of the library via the Article Request feature. By default, it only contains PHOTOCOPY. This is default behavior. The request format SCAN will be made possible by this report and can be added by changing the preference. Test plan: Run the dbrev. Check the new pref on Administration. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122375|0 |1 is obsolete| | --- Comment #46 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122701&action=edit Bug 20472: Add format field to the interface We need to add the format to the forms entering new requests: opac/opac-request-article circ/request-article If the pref contains multiple formats like SCAN|PHOTOCOPY, the first listed format will be preselected on the request form. If there is only one option, we should not disable the select however. (Possibly hide it.) If we have no mandatory fields, we should not allow the submit of a complete empty form (check on OPAC). And we need to show the format of pending requests on forms: opac/opac-user circ/request-article (biblio detail tab) circ/article-requests (staff form to handle requests) members/moremember (Article requests tab at the bottom) circ/circulation (Checkout/Article requests tab) Note: The last two forms use the same include file. Test plan: [1] Add an article request via opac or staff. Choose Scan. [2] Verify that you see the Scan format on opac-user and the above-mentioned staff forms. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122376|0 |1 is obsolete| | --- Comment #47 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122702&action=edit Bug 20472: Edit URL field on staff form This patch makes the following changes: Add menu option Edit URLs. Edit modal form to edit URLs. Save URLs via ajax call to svc/article_request (Add action update_urls). Add URL column to pending and processing table. Allow Edit URLs for pending table too (just as Complete). Do not allow 'Complete request' if a scan request has no URL(s). Test plan: [1] Add a few scan and photocopy requests. [2] Fill url-A and url-B in two separate scan requests. [3] Verify that these two urls are really saved (refresh form). [4] Check that you cannot complete a scan request without URL and that you cannot add a URL to a photocopy request. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122377|0 |1 is obsolete| | --- Comment #48 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122703&action=edit Bug 20472: Add format to sample notices NOTE: We are only changing English here. A follow-up will care for the translated languages. (English is in yml format, the remainder not yet.) We need to change the following notices: AR_SLIP, AR_CANCELED, AR_PROCESSING, AR_PENDING and AR_COMPLETED. In AR_COMPLETED the last sentence about picking up has been modified too. Test plan: Reinstall Koha. Choose English. Check notice text. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122378|0 |1 is obsolete| | --- Comment #49 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122704&action=edit Bug 20472: Update translated AR notices Originally, we had: de-DE/mandatory/sample_notices.sql fr-CA/obligatoire/sample_notices.sql fr-FR/1-Obligatoire/sample_notices.sql it-IT/necessari/notices.sql nb-NO/1-Obligatorisk/sample_notices.sql pl-PL/mandatory/sample_notices.sql ru-RU/mandatory/sample_notices.sql uk-UA/mandatory/sample_notices.sql Obviously, the landscape changed in the meantime. We still have: fr-CA, fr-FR, nb-NO. Test plan: Reinstall notices for one of the languages above. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Have run all sql files thru mysql on the command line. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122382|0 |1 is obsolete| | --- Comment #50 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122705&action=edit Bug 20472: (QA follow-up) Add few TT filters Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> No more warns from qa tools. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122383|0 |1 is obsolete| | --- Comment #51 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122706&action=edit Bug 20472: [DO NOT PUSH] DBIx schema changes Refreshed 24-06-21 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #52 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #44)
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Great! Thx -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #53 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122775&action=edit Bug 20472: Make DB rev idempotent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #54 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122781&action=edit Bug 20472: Add kohastructure changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #55 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #56 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #54)
Created attachment 122781 [details] [review] Bug 20472: Add kohastructure changes
Thanks. Is that really true :) Somewhere it has got lost in the rebase. The first obsolete patch included it, aarg. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |FIXED --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Enhancement not backported for 21.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch set adds an release notes| |additional (optional) | |format to Article Requests. | |Allowing a user to request | |a digital copy. | |In staff | |the request can be | |processed by entering a | |download URL. This serves | |as a base for further | |automation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36081 [Bug 36081] ArticleRequestsSupportedFormats not enforced server-side -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #58 from David Cook <dcook@prosentient.com.au> --- It's unfortunate that the SCAN can only be completed by inputting a URL. Emailing a copy of the scan would also be a reasonable way to complete a request. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #59 from David Cook <dcook@prosentient.com.au> --- Note also that "Pickup library" still shows for SCAN format... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #60 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #58)
It's unfortunate that the SCAN can only be completed by inputting a URL. Emailing a copy of the scan would also be a reasonable way to complete a request.
Hmm. Depends on size and volume. We found mailing a download link more practical. But you are welcome to open a new report.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36202 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36202 [Bug 36202] Article requests: a SCAN request has no pickup location -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40427 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40427 [Bug 40427] An article request for a digital scan shouldn't ask for a "Pickup library" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40428 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40428 [Bug 40428] Article request digital scan shouldn't refuse to complete without URL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #61 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #60)
(In reply to David Cook from comment #58)
It's unfortunate that the SCAN can only be completed by inputting a URL. Emailing a copy of the scan would also be a reasonable way to complete a request.
Hmm. Depends on size and volume. We found mailing a download link more practical. But you are welcome to open a new report..
I raised bug 40427 and 40428 the other day heh. For now, I've advised the library of some workarounds (like dummy URLs), or they might just choose not to use the feature anymore. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org