[Bug 34978] New: Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Bug ID: 34978 Summary: Add --include and --exclude options to install_plugins.pl to choose the plugins to install Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: emily-rose.francoeur@inLibro.com QA Contact: testopia@bugs.koha-community.org It would be great to be able to choose which plugins to install and which ones not to install when using the install_plugins.pl script([Koha]/misc/devel/install_plugins.pl). The --include option would take a list of plugins and only install those. The --exclude option would take a list of plugins and install all plugins except those. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |emily-rose.francoeur@inLibr | |o.com, | |philippe.blouin@inlibro.com Assignee|koha-bugs@lists.koha-commun |emily-rose.francoeur@inLibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #1 from Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 156539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156539&action=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It’s possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include Test1 --include Koha::Plugin::Test2 TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command : "./misc/devel/install_plugins.pl --include <package::pluginClass> --include <anotherPluginClass>" (Replace <package::pluginClass> and <anotherPluginClass> with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project : "./misc/devel/install_plugins.pl --exclude <package::pluginClass> --exclude <anotherPluginClass>” 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156539|0 |1 is obsolete| | --- Comment #2 from Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 156555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156555&action=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It's possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include <package::pluginClass> --include <anotherPluginClass>" TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command "./misc/devel/install_plugins.pl --include <package::pluginClass> --include <anotherPluginClass>" (Replace <package::pluginClass> and <anotherPluginClass> with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project"./misc/devel/install_plugins.pl --exclude <package::pluginClass> --exclude <anotherPluginClass>" 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156555|0 |1 is obsolete| | --- Comment #3 from Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 156557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156557&action=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It's possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include <package::pluginClass> --include <anotherPluginClass>" TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command "./misc/devel/install_plugins.pl --include <package::pluginClass> --include <anotherPluginClass>" (Replace <package::pluginClass> and <anotherPluginClass> with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project"./misc/devel/install_plugins.pl --exclude <package::pluginClass> --exclude <anotherPluginClass>" 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156557|0 |1 is obsolete| | --- Comment #4 from Salah Ghedda <salah.ghedda@inlibro.com> --- Created attachment 160210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160210&action=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It's possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include <package::pluginClass> --include <anotherPluginClass>" TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command "./misc/devel/install_plugins.pl --include <package::pluginClass> --include <anotherPluginClass>" (Replace <package::pluginClass> and <anotherPluginClass> with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project"./misc/devel/install_plugins.pl --exclude <package::pluginClass> --exclude <anotherPluginClass>" 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160210|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 160239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160239&action=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It's possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include <package::pluginClass> --include <anotherPluginClass>" TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command "./misc/devel/install_plugins.pl --include <package::pluginClass> --include <anotherPluginClass>" (Replace <package::pluginClass> and <anotherPluginClass> with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project"./misc/devel/install_plugins.pl --exclude <package::pluginClass> --exclude <anotherPluginClass>" 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 160240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160240&action=edit Bug 34978: (QA follow-up): - Rebased tests patch (62->51) - tidy - spelling ( paramater -> parameter ) Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- What is the use case for this ? Why would you add plugins in the plugins path if you do not want to install them ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #8 from Blou <philippe.blouin@inlibro.com> --- We manage a hundred personnalized koha installations and we don't want to manually install all the plugins. Plus we have multiple in-house plugins, but not all of them go to all clients. It's much simpler for certain plugins to be in the koha git rather than floating in their standalone plugin in github, most of them because anyway they depend on a personnalised codebase. Some depend on the level of support the user has, etc... What was the use case for install_plugins.pl ? Shouldn't people just use the UI ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> ---
What was the use case for install_plugins.pl ? Shouldn't people just use the UI ? It would be nice to be able to install plugins from the UI (and by "install" I do not mean "upload and install", only "install") but I believe plugins don't even appear in the UI until misc/devel/install_plugins.pl is run.
We manage a hundred personnalized koha installations and we don't want to manually install all the plugins. One option you have is to keep in $KOHA_CONF only the plugins that should be enabled for that Koha installation. You can still have all plugins in the same git repository. That way you also cannot install the wrong plugins by accident (by forgetting --exclude or --include)
I'm not against --include and --exclude options, as they could be useful for testing/debugging purposes, but I'm not sure if it's the best solution for your use case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160239|0 |1 is obsolete| | --- Comment #10 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 163800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163800&action=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It's possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include <package::pluginClass> --include <anotherPluginClass>" TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command "./misc/devel/install_plugins.pl --include <package::pluginClass> --include <anotherPluginClass>" (Replace <package::pluginClass> and <anotherPluginClass> with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project"./misc/devel/install_plugins.pl --exclude <package::pluginClass> --exclude <anotherPluginClass>" 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160240|0 |1 is obsolete| | --- Comment #11 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 163801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163801&action=edit Bug 34978: (QA follow-up): - Rebased tests patch (62->51) - tidy - spelling ( paramater -> parameter ) Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I agree with Julian we should have a way to install things from the UI. Would be happy to help on a follow-up bug! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163800|0 |1 is obsolete| | Attachment #163801|0 |1 is obsolete| | --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166560&action=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It's possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include <package::pluginClass> --include <anotherPluginClass>" TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command "./misc/devel/install_plugins.pl --include <package::pluginClass> --include <anotherPluginClass>" (Replace <package::pluginClass> and <anotherPluginClass> with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project"./misc/devel/install_plugins.pl --exclude <package::pluginClass> --exclude <anotherPluginClass>" 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166561&action=edit Bug 34978: (QA follow-up) Fix rebase issues - Rebased tests patch (62->51) - tidy - spelling ( paramater -> parameter ) Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166562&action=edit Bug 34978: Add new parameters to POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166576&action=edit Bug 34978: (QA follow-up) Simplify code and make it stricter This patch simplifies the code a bit, removing duplicated pieces of code and making it slightly more readable. The main change is that it now just filters the `@plugin_classes` list as required, and leaves the original codebase for dealing with loading the plugins untouched. A BIG change it implements is that it now requires full class names. I don't see the use case for partial names, and I generally think we should be stricter in this area. If there's the need for partial class names, this should be handled with specific parameters, etc. It also makes it explicit that the `include` and `exclude` parameters are mutually exclusive. A minor idiomatic issue is fixed as well. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi, I attached a patch making this look what I believe it should. I'm failing it until we have the tests fixed by the authors. Notes: * The patchset introduces 'warn' calls on a package, which are not covered by tests. This should not be the case * We might need to revisit if `warn` plus `return` is the right thing to do here. I'm tempted to suggest it should just be an exception properly handled on the `install_plugins.pl` script. * My follow-up adds an exception for explicitly forbidding both `include` and `exclude` being used simultaneously. This... needs a test as well! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #18 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 166736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166736&action=edit Bug 34978: (follow-up) Add exception when plugin to install is not found and fix unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166560|0 |1 is obsolete| | --- Comment #19 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 166738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166738&action=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It's possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include <package::pluginClass> --include <anotherPluginClass>" TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command "./misc/devel/install_plugins.pl --include <package::pluginClass> --include <anotherPluginClass>" (Replace <package::pluginClass> and <anotherPluginClass> with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project"./misc/devel/install_plugins.pl --exclude <package::pluginClass> --exclude <anotherPluginClass>" 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166561|0 |1 is obsolete| | --- Comment #20 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 166739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166739&action=edit Bug 34978: (QA follow-up) Fix rebase issues - Rebased tests patch (62->51) - tidy - spelling ( paramater -> parameter ) Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166562|0 |1 is obsolete| | --- Comment #21 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 166740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166740&action=edit Bug 34978: Add new parameters to POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166576|0 |1 is obsolete| | --- Comment #22 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 166741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166741&action=edit Bug 34978: (QA follow-up) Simplify code and make it stricter This patch simplifies the code a bit, removing duplicated pieces of code and making it slightly more readable. The main change is that it now just filters the `@plugin_classes` list as required, and leaves the original codebase for dealing with loading the plugins untouched. A BIG change it implements is that it now requires full class names. I don't see the use case for partial names, and I generally think we should be stricter in this area. If there's the need for partial class names, this should be handled with specific parameters, etc. It also makes it explicit that the `include` and `exclude` parameters are mutually exclusive. A minor idiomatic issue is fixed as well. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166736|0 |1 is obsolete| | --- Comment #23 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 166742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166742&action=edit Bug 34978: (follow-up) Add exception when plugin to install is not found and fix unit test Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166738|0 |1 is obsolete| | --- Comment #24 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 179887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179887&action=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It's possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include <package::pluginClass> --include <anotherPluginClass>" TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command "./misc/devel/install_plugins.pl --include <package::pluginClass> --include <anotherPluginClass>" (Replace <package::pluginClass> and <anotherPluginClass> with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project"./misc/devel/install_plugins.pl --exclude <package::pluginClass> --exclude <anotherPluginClass>" 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166739|0 |1 is obsolete| | --- Comment #25 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 179888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179888&action=edit Bug 34978: (QA follow-up) Fix rebase issues - Rebased tests patch (62->51) - tidy - spelling ( paramater -> parameter ) Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166740|0 |1 is obsolete| | --- Comment #26 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 179889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179889&action=edit Bug 34978: Add new parameters to POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166741|0 |1 is obsolete| | --- Comment #27 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 179890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179890&action=edit Bug 34978: (QA follow-up) Simplify code and make it stricter This patch simplifies the code a bit, removing duplicated pieces of code and making it slightly more readable. The main change is that it now just filters the `@plugin_classes` list as required, and leaves the original codebase for dealing with loading the plugins untouched. A BIG change it implements is that it now requires full class names. I don't see the use case for partial names, and I generally think we should be stricter in this area. If there's the need for partial class names, this should be handled with specific parameters, etc. It also makes it explicit that the `include` and `exclude` parameters are mutually exclusive. A minor idiomatic issue is fixed as well. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166742|0 |1 is obsolete| | --- Comment #28 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 179891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179891&action=edit Bug 34978: (follow-up) Add exception when plugin to install is not found and fix unit test Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |shi-yao.wang@inLibro.com --- Comment #29 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|emily-rose.francoeur@inLibr |shi-yao.wang@inLibro.com |o.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Amaury GAU <amaury.gau@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179887|0 |1 is obsolete| | --- Comment #30 from Amaury GAU <amaury.gau@bulac.fr> --- Created attachment 180584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180584&action=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It's possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include <package::pluginClass> --include <anotherPluginClass>" TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command "./misc/devel/install_plugins.pl --include <package::pluginClass> --include <anotherPluginClass>" (Replace <package::pluginClass> and <anotherPluginClass> with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project"./misc/devel/install_plugins.pl --exclude <package::pluginClass> --exclude <anotherPluginClass>" 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> Signed-off-by: Amaury GAU <amaurygau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Amaury GAU <amaury.gau@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179888|0 |1 is obsolete| | --- Comment #31 from Amaury GAU <amaury.gau@bulac.fr> --- Created attachment 180585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180585&action=edit Bug 34978: (QA follow-up) Fix rebase issues - Rebased tests patch (62->51) - tidy - spelling ( paramater -> parameter ) Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> Signed-off-by: Amaury GAU <amaurygau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Amaury GAU <amaury.gau@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179889|0 |1 is obsolete| | --- Comment #32 from Amaury GAU <amaury.gau@bulac.fr> --- Created attachment 180586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180586&action=edit Bug 34978: Add new parameters to POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> Signed-off-by: Amaury GAU <amaurygau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Amaury GAU <amaury.gau@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179890|0 |1 is obsolete| | --- Comment #33 from Amaury GAU <amaury.gau@bulac.fr> --- Created attachment 180587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180587&action=edit Bug 34978: (QA follow-up) Simplify code and make it stricter This patch simplifies the code a bit, removing duplicated pieces of code and making it slightly more readable. The main change is that it now just filters the `@plugin_classes` list as required, and leaves the original codebase for dealing with loading the plugins untouched. A BIG change it implements is that it now requires full class names. I don't see the use case for partial names, and I generally think we should be stricter in this area. If there's the need for partial class names, this should be handled with specific parameters, etc. It also makes it explicit that the `include` and `exclude` parameters are mutually exclusive. A minor idiomatic issue is fixed as well. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> Signed-off-by: Amaury GAU <amaurygau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Amaury GAU <amaury.gau@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179891|0 |1 is obsolete| | --- Comment #34 from Amaury GAU <amaury.gau@bulac.fr> --- Created attachment 180588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180588&action=edit Bug 34978: (follow-up) Add exception when plugin to install is not found and fix unit test Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> Signed-off-by: Amaury GAU <amaurygau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #35 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Seems signed-off since rebase (comment #29). Changing status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #36 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Tests seem to be failing with this applied: Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/Koha/Plugins/Plugins.t FAIL # Failed test 'Excluded plugins are not returned' # at /kohadevbox/koha/t/db_dependent/Koha/Plugins/Plugins.t line 213. # Failed test 'Excluded plugins are not installed' # at /kohadevbox/koha/t/db_dependent/Koha/Plugins/Plugins.t line 221. # Looks like you failed 2 tests of 6. # Failed test 'InstallPlugins() tests' # at /kohadevbox/koha/t/db_dependent/Koha/Plugins/Plugins.t line 260. # Looks like you failed 1 test of 20. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180584|0 |1 is obsolete| | Attachment #180585|0 |1 is obsolete| | Attachment #180586|0 |1 is obsolete| | Attachment #180587|0 |1 is obsolete| | Attachment #180588|0 |1 is obsolete| | --- Comment #37 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 184818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184818&action=edit Bug 34978: Add --include and --exclude options to install_plugins.pl I have added the options --include and --exclude to the install_plugins.pl script. When running the script, you can now specify which plugins you want to install (--include) and which ones you do not want to install (--exclude). --include installs only the plugins from the specified classes. --exclude installs all plugins except those from the specified classes. It's possible to specify the package to install a specific plugin. --include and --exclude cannot be used simultaneously. Usage example: ./misc/devel/install_plugins --include <package::pluginClass> --include <anotherPluginClass>" TEST PLAN 1) Apply the patch 2) Add at least three plugins to the plugin directory ([Koha]/plugins/Koha/Plugin/) 3) Empty the "plugin_data" and "plugin_methods" tables (SQL command: "delete from plugin_data; delete from plugin_methods;") 4) In a terminal, execute this command "./misc/devel/install_plugins.pl --include <package::pluginClass> --include <anotherPluginClass>" (Replace <package::pluginClass> and <anotherPluginClass> with the class and package of your plugins) 5) In your Koha intranet, go to "Koha administration > Manage plugins" 6) Verify that only the specified plugins are installed 7) Repeat step 3 8) In a terminal, execute this command from your Koha project"./misc/devel/install_plugins.pl --exclude <package::pluginClass> --exclude <anotherPluginClass>" 9) Verify that all plugins except the specified ones are installed 10) Run the tests from the Plugins.t file ([Koha]/t/db_dependent/Koha/Plugins/Plugins.t) 11) Ensure that all tests are successful Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> Signed-off-by: Amaury GAU <amaurygau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #38 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 184819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184819&action=edit Bug 34978: (QA follow-up) Fix rebase issues - Rebased tests patch (62->51) - tidy - spelling ( paramater -> parameter ) Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> Signed-off-by: Amaury GAU <amaurygau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #39 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 184820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184820&action=edit Bug 34978: Add new parameters to POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> Signed-off-by: Amaury GAU <amaurygau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #40 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 184821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184821&action=edit Bug 34978: (QA follow-up) Simplify code and make it stricter This patch simplifies the code a bit, removing duplicated pieces of code and making it slightly more readable. The main change is that it now just filters the `@plugin_classes` list as required, and leaves the original codebase for dealing with loading the plugins untouched. A BIG change it implements is that it now requires full class names. I don't see the use case for partial names, and I generally think we should be stricter in this area. If there's the need for partial class names, this should be handled with specific parameters, etc. It also makes it explicit that the `include` and `exclude` parameters are mutually exclusive. A minor idiomatic issue is fixed as well. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> Signed-off-by: Amaury GAU <amaurygau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #41 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 184822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184822&action=edit Bug 34978: (follow-up) Add exception when plugin to install is not found and fix unit test Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> Signed-off-by: Amaury GAU <amaurygau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #42 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 184823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184823&action=edit Bug 34978: Simplify tests logic Joining the plugin classes strings and then performing regex checks on it might be a bit fragile. I had hard time understanding the ands the conditions for truth. I rewrote it in a more intuitive way just using `none` and the tests are easy to understand and pass. The failure is probably because new plugins were added that make the resulting string not match the expected structure. The new new tests design is more readable anyway and not subject to this errors in future additions. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #43 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #44 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Please add release notes! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds new release notes| |parameters to the | |install_plugins.pl script | |to specify which plugins to | |install. | | | |New parameters : | |--include <PluginClass> | |(repeatable) install ONLY | |the plugins specified | | | |--exclude <PluginClass> | |(repeatable) install all | |the plugins EXCEPT the ones | |specified | | | |The parameters require the | |full plugin class (e.g. | |Koha::Plugin::PluginName). | | | |The parameters *cannot* be | |used simultaneously. --- Comment #45 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I tried to write a release note text, but I don't understand the difference between a "full" plugin class as added but Tomás in comment 16 and a package::pluginClass. The doc inside the script says we can use either the plugin class or the package + plugin class. =item B<--include> Retrieve the list of plugin classes and install only those. It's possible to specify the package of a class to install a specific plugin (e.g. --include <package::pluginClass> --include <anotherPluginClass>). =item B<--exclude> Retrieve the list of plugin classes and install all plugins except those. It's possible to specify the package of a class to install a specific plugin (e.g. --exclude <package::pluginClass> --exclude <anotherPluginClass>). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #46 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #47 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #48 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Non-cron scripts are not in the manual, as far as I know. Nothing to change in the manual for this. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org