[Bug 29318] New: OverDrive search page should not require edit_borrowers permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29318 Bug ID: 29318 Summary: OverDrive search page should not require edit_borrowers permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org This seems to have been introduced with the feature in bug 10320, and updated with bug 18403 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29318 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29318 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126840&action=edit Bug 29318: Remove permission check from overdrive search page This removes the 'edit_borrowers' permission from OverDrive search To test: 1 - Enable OverDrive via koha system preferences 2 - Sign in to opac with a user with no permissions 3 - Perform a search that will return OD results, 'love' works 4 - Click thje "Found XX results in the library's OverDrive collection" 5 - Note you are logged out of Koha 6 - Apply patch 7 - Repeat 8 - Success -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29318 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126841&action=edit Bug 29318: Tidy the code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29318 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126840|0 |1 is obsolete| | Attachment #126841|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 126842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126842&action=edit Bug 29318: Remove permission check from overdrive search page This removes the 'edit_borrowers' permission from OverDrive search To test: 1 - Enable OverDrive via koha system preferences 2 - Sign in to opac with a user with no permissions 3 - Perform a search that will return OD results, 'love' works 4 - Click thje "Found XX results in the library's OverDrive collection" 5 - Note you are logged out of Koha 6 - Apply patch 7 - Repeat 8 - Success Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29318 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 126843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126843&action=edit Bug 29318: Tidy the code Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29318 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29318 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126842|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126849&action=edit Bug 29318: Remove permission check from overdrive search page This removes the 'edit_borrowers' permission from OverDrive search To test: 1 - Enable OverDrive via koha system preferences 2 - Sign in to opac with a user with no permissions 3 - Perform a search that will return OD results, 'love' works 4 - Click thje "Found XX results in the library's OverDrive collection" 5 - Note you are logged out of Koha 6 - Apply patch 7 - Repeat 8 - Success Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29318 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126843|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126850&action=edit Bug 29318: Tidy the code Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29318 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Couldn't test with Overdrive, but trusting Owen has. Code reads well and a permission check definitely makes no sense in an OPAC script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29318 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- So basically this script has never been used? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29318 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29318 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org