[Bug 30928] New: Add interface to statistics table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Bug ID: 30928 Summary: Add interface to statistics table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: hebah@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Many libraries are interested in seeing stats on the interfaces where transactions took place (staff intranet vs sip checkout, for example). Currently the only way to find that information is via action_logs, which means that data drops off eventually. It would be nice to have this information as part of statistics for ease of reporting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 James Donaldson <james.donaldson@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |james.donaldson@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 raymond.bryson@montgomerycountymd.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |raymond.bryson@montgomeryco | |untymd.gov --- Comment #1 from raymond.bryson@montgomerycountymd.gov --- It would be incredibly useful to have the interface added to the statistics table. Our use case is this - We need to calculate self-checkout percentage, by library location. At the system-wide level (all branches), we can do this using the action_logs table. However, if we need granularity at the library branch level, we currently cannot provide accurate data for reporting/comparisons. For our use case, we would use the interface to compare Intranet (staff) vs SIP (self-checkouts), at the branch level. There are other use cases where the interface (context) at the branch level might be useful too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7021 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbrown@bywatersolutions.com --- Comment #2 from Sara Brown <sbrown@bywatersolutions.com> --- This would be great! Once it's added to statistics, it would be helpful to have it added to the pseudonymization options too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 145982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145982&action=edit Bug 30928: Add interface column: DB update, schema changes, and UpdateStats -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 146042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146042&action=edit Bug 30928: Update Accounts.pm and Recalls.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145982|0 |1 is obsolete| | Attachment #146042|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 146171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146171&action=edit Bug 30928: Add interface column: DB update, schema changes, and UpdateStats To test: Apply patch, updatedatabase, and restart_all Do each of the following actions and check the statistics table making sure the interface is properly being recorded: RENEWALS: -Renewal from staff client -Renew from OPAC -Renew from API. You could add something like this to IntranetUSerJS: $.ajax({ url: '/api/v1/checkouts/338/renewal', method: 'POST', contentType: 'application/json', success: function(result) { console.log('renewed') }, }); -Renewal from automatic_renewals -Renewal from SIP ( can use sip_cli_emulator.pl ) CHECKOUTS: -Checkout from staff client -Checkout from SCO -Checkout from API -Checkout from SIP ( can use sip_cli_emulator.pl ) CHECKIN: -Checkin from staff client -Check in from batch -Check in from API -Check in from SCI -Check in from SIP ( can use sip_cli_emulator.pl ) RECALLS: -OPAC recall -Staff client recall ACCOUNTING: -Make a payment -Make a payemnt from SIP ( can use sip_cli_emulator.pl ) prove -v /kohadevbox/koha/t/db_dependent/Circulation.t Tests should all pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 146172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146172&action=edit Bug 30928: Add tests prove -v t/db_dependent/Koha/Statistics.t prove -v t/db_dependent/Stats.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #7 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Testing Notes (KTD): 1 error: ACCOUNTING - When a payment was made from the staff interface, the Statistics table incorrectly logged that the transaction was made through the OPAC 2 unable to test: - I'm not sure how to test CHECKIN and CHECKOUT via REST API. Any chance you can include JS snippets for that in your test plan, like you did for a renewal? - Everything else, including prove commands, worked as expected :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> ---
1 error: ACCOUNTING - When a payment was made from the staff interface, the Statistics table incorrectly logged that the transaction was made through the OPAC
Hi, Emily. I am not recreating this. Can you provide some specific steps you use to log the transaction as OPAC via the staff client? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #9 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Suddenly I wasn't able to reproduce it either...it turned out to be a very specific interaction between the intranet, OPAC, and SCO logins. It also looks like a separate bug that has nothing to do with your patch. (It didn't occur to me yesterday to compare with the system logs - but having checked them, the logs show the same error, both with and without the patch. Sorry for missing that yesterday!) Moved it to bug 32965. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #10 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 146653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146653&action=edit Bug 30642: (follow-up) Remove use of deleted file Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146171|0 |1 is obsolete| | --- Comment #11 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 146654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146654&action=edit Bug 30928: Add interface column: DB update, schema changes, and UpdateStats To test: Apply patch, updatedatabase, and restart_all Do each of the following actions and check the statistics table making sure the interface is properly being recorded: RENEWALS: -Renewal from staff client -Renew from OPAC -Renew from API. You could add something like this to IntranetUSerJS: $.ajax({ url: '/api/v1/checkouts/338/renewal', method: 'POST', contentType: 'application/json', success: function(result) { console.log('renewed') }, }); -Renewal from automatic_renewals -Renewal from SIP ( can use sip_cli_emulator.pl ) CHECKOUTS: -Checkout from staff client -Checkout from SCO -Checkout from API -Checkout from SIP ( can use sip_cli_emulator.pl ) CHECKIN: -Checkin from staff client -Check in from batch -Check in from API -Check in from SCI -Check in from SIP ( can use sip_cli_emulator.pl ) RECALLS: -OPAC recall -Staff client recall ACCOUNTING: -Make a payment -Make a payemnt from SIP ( can use sip_cli_emulator.pl ) prove -v /kohadevbox/koha/t/db_dependent/Circulation.t Tests should all pass Signed-off-by: emlam <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146654|0 |1 is obsolete| | Attachment #146654|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146654|1 |0 is obsolete| | Attachment #146654|0 |1 is patch| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146653|1 |0 is patch| | Attachment #146653|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #12 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Testing Notes: Couldn't find any routes for checkin/checkout in the API documentation. All other use cases behave as expected, and tests pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #13 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Patch no longer applies - merge conflict in C4/Circulation.pm Please rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146172|0 |1 is obsolete| | --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 147838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147838&action=edit Bug 30928: Add tests prove -v t/db_dependent/Koha/Statistics.t prove -v t/db_dependent/Stats.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146654|0 |1 is obsolete| | --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 147839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147839&action=edit Bug 30928: Add interface column: DB update, schema changes, and UpdateStats To test: Apply patch, updatedatabase, and restart_all Do each of the following actions and check the statistics table making sure the interface is properly being recorded: RENEWALS: -Renewal from staff client -Renew from OPAC -Renew from API. You could add something like this to IntranetUSerJS: $.ajax({ url: '/api/v1/checkouts/338/renewal', method: 'POST', contentType: 'application/json', success: function(result) { console.log('renewed') }, }); -Renewal from automatic_renewals -Renewal from SIP ( can use sip_cli_emulator.pl ) CHECKOUTS: -Checkout from staff client -Checkout from SCO -Checkout from API -Checkout from SIP ( can use sip_cli_emulator.pl ) CHECKIN: -Checkin from staff client -Check in from batch -Check in from API -Check in from SCI -Check in from SIP ( can use sip_cli_emulator.pl ) RECALLS: -OPAC recall -Staff client recall ACCOUNTING: -Make a payment -Make a payemnt from SIP ( can use sip_cli_emulator.pl ) prove -v /kohadevbox/koha/t/db_dependent/Circulation.t Tests should all pass Signed-off-by: emlam <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Rebased for current master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |aleisha@catalyst.net.nz |y.org | CC| |aleisha@catalyst.net.nz Status|Signed Off |Failed QA --- Comment #17 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Please move schema update to a separate patch. Once fixed I'll be happy to pass QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147839|0 |1 is obsolete| | --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 150386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150386&action=edit Bug 30928: Add interface to statistics -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 150387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150387&action=edit Bug 30928: DB and Schema updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Aleisha Amohia from comment #17)
Please move schema update to a separate patch. Once fixed I'll be happy to pass QA.
Thanks Aleisha! I have separated them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33013, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33608, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33636 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147838|0 |1 is obsolete| | Attachment #150387|0 |1 is obsolete| | --- Comment #21 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 150433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150433&action=edit Bug 30928: Add tests prove -v t/db_dependent/Koha/Statistics.t prove -v t/db_dependent/Stats.t Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150386|0 |1 is obsolete| | --- Comment #22 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 150434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150434&action=edit Bug 30928: Add interface to statistics Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #23 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 150435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150435&action=edit Bug 30928: (QA follow-up) DB updates Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #24 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 150436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150436&action=edit Bug 30928: (QA follow-up) Schema updates Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Gentle message from the RM: the QA script tells the atomicupdate doesn't have the right permissions. I'm pushing this already, but keep in mind for future submissions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I am rebasing now bug 33608 on top of this one. We have a failure after this patch set on Koha/Pseudonymization.t Will add a follow-up here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hmm. It may come from another pushed patch set.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #28)
Hmm. It may come from another pushed patch set..
It must be the authority relinking stuff that was pushed too. That makes sample_biblio crash in Pseudonymization.t. So not caused here definitely. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #29)
(In reply to Marcel de Rooy from comment #28)
Hmm. It may come from another pushed patch set..
It must be the authority relinking stuff that was pushed too. That makes sample_biblio crash in Pseudonymization.t. So not caused here definitely.
Opened bug 33718 for these issues. Disabling AutoLinkBiblios helps to get it passing again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #31 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #32 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- It looks like only backend changes. Nothing to add/change in the manual. Closing, but feel free to include more details if this needs to be documented in the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Will add a follow-up for this development on 33608. It would be good to default to C4::Context->interface instead of NULL, or always needing to pass it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #33)
Will add a follow-up for this development on 33608. It would be good to default to C4::Context->interface instead of NULL, or always needing to pass it.
But much harder to spot missed/wrong values this way :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #34)
(In reply to Marcel de Rooy from comment #33)
Will add a follow-up for this development on 33608. It would be good to default to C4::Context->interface instead of NULL, or always needing to pass it.
But much harder to spot missed/wrong values this way :)
Please explain what you mean. NULL would be a missing value, I suppose, that we fix there. If C4::Context->interface would provide a wrong value, we should address that elsewhere. But that should not be possible, since it already contains a list of valid options. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org