[Bug 32769] New: Standardize structure around action fieldsets in administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32769 Bug ID: 32769 Summary: Standardize structure around action fieldsets in administration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 32743 Blocks: 32744 As per Bug 32744: Fieldsets with the class "action" should be placed outside of the fieldset containing the main body of the form. This report covers templates in administration. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32743 [Bug 32743] Reindent the invoice details page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32744 [Bug 32744] [OMNIBUS] Standardize structure around action fieldsets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32769 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32769 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 145904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145904&action=edit Bug 32769: Standardize structure around action fieldsets in administration This patch updates administration templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and check the following pages to confirm that the forms look correct: - Administration -> Keyboard shortcuts -> Audio alerts -> Share content with Mana KB - When the ManaToken system preference is empty, the page should have two forms with updated fieldsets: the form with the "Use Mana KB..." field and a "Configure Mana KB" form. - With a ManaToken defined the second form should be one labeled "Mana KB token." -> Budgets - Click on a budget which has existing funds. - In the page toolbar click Planning -> Plan by libraries. - Check the forms in the sidebar. -> System preferences -> OverDriveAuthName - Follow the link to "OverDrive library authnames table" and check the form on that page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32769 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32769 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145904|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 145956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145956&action=edit Bug 32769: Standardize structure around action fieldsets in administration This patch updates administration templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and check the following pages to confirm that the forms look correct: - Administration -> Keyboard shortcuts -> Audio alerts -> Share content with Mana KB - When the ManaToken system preference is empty, the page should have two forms with updated fieldsets: the form with the "Use Mana KB..." field and a "Configure Mana KB" form. - With a ManaToken defined the second form should be one labeled "Mana KB token." -> Budgets - Click on a budget which has existing funds. - In the page toolbar click Planning -> Plan by libraries. - Check the forms in the sidebar. -> System preferences -> OverDriveAuthName - Follow the link to "OverDrive library authnames table" and check the form on that page. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32769 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This does what it says on the tin, but we still have some display inconsistencies, as sometimes the button is outside the page-section (shortcuts) and other times it's within (aqplan). Is this something we should look at now or better for later? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32769 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32769 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145956|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146213&action=edit Bug 32769: Standardize structure around action fieldsets in administration This patch updates administration templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and check the following pages to confirm that the forms look correct: - Administration -> Keyboard shortcuts -> Audio alerts -> Share content with Mana KB - When the ManaToken system preference is empty, the page should have two forms with updated fieldsets: the form with the "Use Mana KB..." field and a "Configure Mana KB" form. - With a ManaToken defined the second form should be one labeled "Mana KB token." -> Budgets - Click on a budget which has existing funds. - In the page toolbar click Planning -> Plan by libraries. - Check the forms in the sidebar. -> System preferences -> OverDriveAuthName - Follow the link to "OverDrive library authnames table" and check the form on that page. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32769 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32769 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32769 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32769 --- Comment #6 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32769 Bug 32769 depends on bug 32743, which changed state. Bug 32743 Summary: Reindent the invoice details page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32743 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32769 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org