[Bug 25473] New: Can't add order from MARC file, save button does nothing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Bug ID: 25473 Summary: Can't add order from MARC file, save button does nothing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: victor@tuxayo.net QA Contact: testopia@bugs.koha-community.org tl;dr it seems form error handling can break it. (when not ticking a record to import) == Test plan == 1. stage a marc record 2. acquisitions: have a basket 3. click on "Add to basket" 4. "From a staged file" 5. "Add orders" button 6. Optional open JavaScript console - You see twice the error "$ is not defined" - not sure if related though 7. Don't tick the record 8. Save (at least try) 9. You should see an expected error message 10. Tick the record 11. Choose a fund 12. Save (at least try) 13. Nothing happens :< -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11500 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500 [Bug 11500] Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- So basically we have the plugin (cataloguing/value_builder/dateaccessioned.pl) that is using the jQuery selector '$' but it is not defined yet as we have it at the bottom (jsinclude). This can be a serious problems for other pages as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11500 |22734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500 [Bug 11500] Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 [Bug 22734] Fund not marked as mandatory when ordering from a staged file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Caused by 22734 in which I moved JavaScript to the footer, ignoring the work I did in Bug 21989, in which I moved JavaScript OUT of the footer because it broke JavaScript. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 104878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104878&action=edit Bug 25473: Move JavaScript out of the footer of addorderiso2709.tt This patch undoes the move of the JavaScript block to the footer made in Bug 22734. The item information tab can include embedded JavaScript for cataloging plugins, and these don't currently work with JS in the footer. To test, apply the patch and test the JavaScript driven features of the "Add to basket from a staged file" page: - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - MARC and Card previews, select all/clear all - Item information tab: Cataloging plugins for fields like date acquired, barcode - Default accounting details tab: Show inactive control -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | QA Contact|testopia@bugs.koha-communit |jonathan.druart@bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- After testing. == Good news == No more JS errors :D == Some things couldn't be tested. ==
Item information tab: Cataloging plugins for fields like date acquired, barcode
- date acquired ok - barcode: nothing happens, no error. Does it depends on other data/config?
Default accounting details tab: Show inactive control
I couldn't find how to make a fund inactive ^^" == Bad news == test plan of comment 0 fails -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Item information tab: Cataloging plugins for fields like date acquired, barcode
- date acquired ok - barcode: nothing happens, no error. Does it depends on other data/config?
This one depends on the AutoBarcode system preference. You possible need to activate the feature first - it's off by default.
Default accounting details tab: Show inactive control
I couldn't find how to make a fund inactive ^^"
Go to: Acquisition > Budets Edit the budget to set it not active (first checkbox, not the locked one) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks Katrin :) Issue of comment 0 is still happening unfortunately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (but the rest is fixed, nice catch Owen for the cataloging plugins, they indeed where broken) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25563 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Victor Grousset/tuxayo from comment #6)
Issue of comment 0 is still happening unfortunately.
This is something different, see bug 25563. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104878|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 105174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105174&action=edit Bug 25473: Move JavaScript out of the footer of addorderiso2709.tt This patch undoes the move of the JavaScript block to the footer made in Bug 22734. The item information tab can include embedded JavaScript for cataloging plugins, and these don't currently work with JS in the footer. To test, apply the patch and test the JavaScript driven features of the "Add to basket from a staged file" page: - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - MARC and Card previews, select all/clear all - Item information tab: Cataloging plugins for fields like date acquired, barcode - Default accounting details tab: Show inactive control Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I guess this can be safely ignored here? :) FAIL js_in_body A <script> tag found inside head, must be moved to the body (see bug 17858) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105174|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105178&action=edit Bug 25473: Move JavaScript out of the footer of addorderiso2709.tt This patch undoes the move of the JavaScript block to the footer made in Bug 22734. The item information tab can include embedded JavaScript for cataloging plugins, and these don't currently work with JS in the footer. To test, apply the patch and test the JavaScript driven features of the "Add to basket from a staged file" page: - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - MARC and Card previews, select all/clear all - Item information tab: Cataloging plugins for fields like date acquired, barcode - Default accounting details tab: Show inactive control Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Jonathan Druart from comment #8)
(In reply to Victor Grousset/tuxayo from comment #6)
Issue of comment 0 is still happening unfortunately.
This is something different, see bug 25563.
That was the initial bug report and the title this bug still reflects it XD Anyway, thank you that you moved to bug 25563. So, everything go fixed in the end 🥳🥳 Thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords|rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.07 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #14 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.07 |20.05.00, 19.11.07, released in| |19.05.12 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org