[Bug 16033] New: Quotes upload preview broken for 973 days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16033 Bug ID: 16033 Summary: Quotes upload preview broken for 973 days Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/quotes-upload.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Tools Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org In my follow-up patch to Bug 10558 I made some changes to the way DataTables displayed which broke the preview of quotes uploaded to the Quote of the Day manager. 2 years, 7 months, and 28 days later I have returned to fix it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16033 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16033 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48896&action=edit Bug 16033 - Quotes upload preview broken for 973 days A missing snippet of DataTable configuration means that when you upload a CSV of quotes to the Quotes of the Day feature the table previewing your import is not visible. This patch corrects it. To test, apply the patch and go to Tools -> Quote editor -> Import quotes. - Upload a CSV file containing data in two columns, "source","text" - When your upload completes you should see a DataTable previewing the data from your CSV. - Check that deletion of individual quotes works from the preview. - Check that quotes are correctly imported. - Ponder the long 2.66 years during which this page was broken. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16033 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16033 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48896|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 48927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48927&action=edit Bug 16033 - Quotes upload preview broken for 973 days A missing snippet of DataTable configuration means that when you upload a CSV of quotes to the Quotes of the Day feature the table previewing your import is not visible. This patch corrects it. To test, apply the patch and go to Tools -> Quote editor -> Import quotes. - Upload a CSV file containing data in two columns, "source","text" - When your upload completes you should see a DataTable previewing the data from your CSV. - Check that deletion of individual quotes works from the preview. - Check that quotes are correctly imported. - Ponder the long 2.66 years during which this page was broken. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Quote of the day: Serenity of mind comes with patience. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16033 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16033 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48927|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48950&action=edit Bug 16033 - Quotes upload preview broken for 973 days A missing snippet of DataTable configuration means that when you upload a CSV of quotes to the Quotes of the Day feature the table previewing your import is not visible. This patch corrects it. To test, apply the patch and go to Tools -> Quote editor -> Import quotes. - Upload a CSV file containing data in two columns, "source","text" - When your upload completes you should see a DataTable previewing the data from your CSV. - Check that deletion of individual quotes works from the preview. - Check that quotes are correctly imported. - Ponder the long 2.66 years during which this page was broken. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Quote of the day: Serenity of mind comes with patience. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16033 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10558 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16033 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16033 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16033 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.10. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org