[Bug 33313] New: TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Bug ID: 33313 Summary: TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org While I think IntranetBaseURL is a better name for it, the system preference is still called staffClientBaseURL ;) To reproduce 1: 1. Go to Tools > Notices and slips 2. Look for TICKET_NOTIFY 3. Click 'Edit' next to TICKET_NOTIFY 4. Click 'Email' --> In the message body is this line a href='[%- Koha.Preference('IntranetBaseURL') -%]/cgi-bin/koha/cataloguing/concerns.pl To reproduce 2: 1. Make sure staffClientBaseURL is filled correctly 2. Enable CatalogConcerns 3. Enter an email address in CatalogerEmails 4. Go to a bibliographic record in the staff interface 5. Click New > New catalog concern 6. Fill out the form and click Submit 7. Check the message_queue table for the message --> In the message, the link base is empty <br><br>You can mark this concern as resolved from the concern management <a href='/cgi-bin/koha/cataloguing/concerns.pl'>page</a> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31028 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33314 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33315 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Bug 33313 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Bug 33313 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wanted to have a look at this, but bug 31028 needs a rebase. Adding Martin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #1)
I wanted to have a look at this, but bug 31028 needs a rebase. Adding Martin.
It's because 31028 is pretty much all pushed.. you don't need to apply it.. it's in master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Should I still put the 'depends on' when it's pushed? I just wanted to alert the people who worked on 31028 of related bugs that I found while documenting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Depends on is good.. it's just that in this case the bug was a bit messy and ended up going backwards in bugzilla states.. as such git bz ignore it as is should. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150130&action=edit Bug 33313: Fix catalog links in TICKET_NOTIFY This fixes the system preference name from IntranetBaseURL to staffClientBaseURL. Also makes some small typo fixes. As this feature has just been pushed I chose to fix the database updates that will be run when installing 23.05. To test: * Verify the wrong link in TICKET_NOTIFY * Drop database, create database, run web installer * Verify the link is now correct in the notice Bonus: Test update from 22.11 to 23.05 and verify the notices are correct there as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- This fixes the link to the cataloging concerns management page, so happy to sign it off. In addition, should the link to the record title be fixed as well, or should I log that as a separate bug? For example: I used Programming Perl - the link for this in the email is to http://cgi-bin/koha/catalogue/detail.pl?biblionumber=262 (in the notice it is <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=262" class="title">), which is an invalid link without the domain name. Testing notes (using KTD): 1. After applying the patch, reset_all refreshes everything with the updated notice. (Need to set the required system preferences - enable CatalogConcerns, have a value for set CatalogerEmails, have a valid value for staffClientBaseURL, and have a valid email for the patron submitting the concern). 2. I'm not sure of the right steps using KTD to do the bonus test (test update from 22.11 to 23.05), so I haven't done that. 3. I set up email to test the actual emails received.[1] [1] To test sending emails using a Google account, edit /etc/koha/sites/kohadev/koha-conf.xml file and add this configuration near the end (where <user_name> = your Google email address; <password> = your APP password, not your Google account password): <smtp_server> <host>smtp.gmail.com</host> <port>587</port> <timeout>5</timeout> <ssl_mode>STARTTLS</ssl_mode> <user_name>GOOGLEACCOUNTUSER</user_name> <password>GOOGLEAPPPASSWORD</password> <debug>1</debug> </smtp_server> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to David Nind from comment #6)
In addition, should the link to the record title be fixed as well, or should I log that as a separate bug? For example: I used Programming Perl - the link for this in the email is to http://cgi-bin/koha/catalogue/detail.pl?biblionumber=262 (in the notice it is <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=262" class="title">), which is an invalid link without the domain name.
This is already logged as bug 33314. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150130|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 150135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150135&action=edit Bug 33313: Fix catalog links in TICKET_NOTIFY This fixes the system preference name from IntranetBaseURL to staffClientBaseURL. Also makes some small typo fixes. As this feature has just been pushed I chose to fix the database updates that will be run when installing 23.05. To test: * Verify the wrong link in TICKET_NOTIFY * Drop database, create database, run web installer * Verify the link is now correct in the notice Bonus: Test update from 22.11 to 23.05 and verify the notices are correct there as well. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #9 from David Nind <david@davidnind.com> --- Additional testing note (using KTD): 1. When applying the patch, DON'T follow 31028 (the main patch is pushed to master, some follow-up patches have not yet been pushed). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Nind from comment #7)
(In reply to David Nind from comment #6)
In addition, should the link to the record title be fixed as well, or should I log that as a separate bug? For example: I used Programming Perl - the link for this in the email is to http://cgi-bin/koha/catalogue/detail.pl?biblionumber=262 (in the notice it is <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=262" class="title">), which is an invalid link without the domain name.
This is already logged as bug 33314.
I was not aware of the other bug, I fixed the issue as a follow-up and made it dependent on this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #11 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #10)
This is already logged as bug 33314.
I was not aware of the other bug, I fixed the issue as a follow-up and made it dependent on this one.
Thanks for creating a patch for bug 33314! I've signed it off as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There are 2 "Thankyou" left in installer/data/mysql/db_revs/221200010.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Bug 33313 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I didn't get back to this in time, maybe consider a follow-up next time? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150135|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151384&action=edit Bug 33313: Fix catalog links in TICKET_NOTIFY This fixes the system preference name from IntranetBaseURL to staffClientBaseURL. As this feature has just been pushed I chose to fix the database updates that will be run when installing 23.05. To test: * Verify the wrong link in TICKET_NOTIFY * Drop database, create database, run web installer * Verify the link is now correct in the notice Bonus: Test update from 22.11 to 23.05 and verify the notices are correct there as well. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate Severity|enhancement |normal --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am moving the typo fixes to a different bug. I believe we might get away with pushing this as the string might not change in pootle now. It's currently: You can mark this concern as resolved from the concern management %spage%s. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151384|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151417&action=edit Bug 33313: Fix catalog links in TICKET_NOTIFY This fixes the system preference name from IntranetBaseURL to staffClientBaseURL. As this feature has just been pushed I chose to fix the database updates that will be run when installing 23.05. To test: * Verify the wrong link in TICKET_NOTIFY * Drop database, create database, run web installer * Verify the link is now correct in the notice Bonus: Test update from 22.11 to 23.05 and verify the notices are correct there as well. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- My mistake.. sure it was intranet at some point.. or I'm going mad. Passing QA anyway -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #19 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Missing dependencies - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org