https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17668 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17668 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13726 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17668 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57713|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57790&action=edit [SIGNED-OFF] Bug 17668: Fix typo in parcel.pl - listinct vs listincgst This typo has been introduced by commit eed14b080db8691f371b4c19f1a190b87fcc396a Bug 13001: Refactor VAT and price calculation - parcel page So before the tax rewrite (13321, 13323). It sounded weird to me that testers did not catch the bug on this page. To understand the logic: Conditions are listincgst, invoiceincgst Conditions | Before this patch | If we fix the typo | After this patch 0 0 | excluded | excluded | excluded 0 1 | included | included | included 1 0 | excluded | excluded | excluded 1 1 | included | included | included Test plan: Create 4 vendors with the difference combinations Create a basket, add an order (with a tax) and receive it Confirm that the different values displayed on the parcel page are correct Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17668 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 58011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58011&action=edit Bug 17668: Fix typo in parcel.pl - listinct vs listincgst This typo has been introduced by commit eed14b080db8691f371b4c19f1a190b87fcc396a Bug 13001: Refactor VAT and price calculation - parcel page So before the tax rewrite (13321, 13323). It sounded weird to me that testers did not catch the bug on this page. To understand the logic: Conditions are listincgst, invoiceincgst Conditions | Before this patch | If we fix the typo | After this patch 0 0 | excluded | excluded | excluded 0 1 | included | included | included 1 0 | excluded | excluded | excluded 1 1 | included | included | included Test plan: Create 4 vendors with the difference combinations Create a basket, add an order (with a tax) and receive it Confirm that the different values displayed on the parcel page are correct Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17668 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.