[Bug 29982] New: Show itemtype in holds table on patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 Bug ID: 29982 Summary: Show itemtype in holds table on patron details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If possible, display the name of the item type in the "holds" table on the following tabs in patron details: - Check out - Details This will only be possible when holds are item level, or they are found/waiting. It might still be relevant to be able to see the item type at a glance in these tables. This should not be confused with the changes from "Bug 15533 - Allow patrons and librarians to select itemtype when placing hold", which makes it possible to select a preferred itemtype for a hold, if there are different item types attached to the same record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- This feature has been requested by Swedish libraries, in order to make it easier to distinguish holds related to inter library loans in the holds tables. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 129995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129995&action=edit Bug 29982 - Show itemtype in holds table on patron details Show item type in the holds tables on "Check out" and "Details" tabs in the intranet. To test: - Add an item level hold - Go to patron details and look at the "Check out" tab - Click on the "Holds" horizontal tab and verify the item type is shown in a column between "Title" and "Call number" - Go to the "Details" tab - Click on the "Holds" horizontal tab and verify the display is the same as above - Make a record level hold and verify the item type is not shown in the tables described above - Check in an item from the record level hold, so it is "waiting" for the patron - Verify the item type is now shown in the same way as for the item level hold, as described above -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- When I apply this patch and look at the table on either Check out or Details subsequent columns do not look right. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 130020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130020&action=edit screenshot of columns after patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- (In reply to Lucas Gass from comment #4)
Created attachment 130020 [details] screenshot of columns after patch
Yeah, that is not how it was supposed to look... What page is that on? I thought I fixed that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Magnus Enger from comment #5)
(In reply to Lucas Gass from comment #4)
Created attachment 130020 [details] screenshot of columns after patch
Yeah, that is not how it was supposed to look... What page is that on? I thought I fixed that.
Magnus, it looks like that for me on both pages: http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=5 http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 --- Comment #7 from Magnus Enger <magnus@libriotech.no> ---
Magnus, it looks like that for me on both pages:
http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=5 http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=5
Looks OK when I test... From your screenshot, it looks like the header row is created ok, but then the cells in the column below it are not created, resulting in cells not being under their proper headings. Those cells are created from JavaScript. Did you make a hard reload (Ctrl+Shift+R)? Could you verify you have this code in http://localhost:8081/intranet-tmpl/prog/js/holds_21.1200011.js: { "mDataProp": function( oObj ) { return oObj.itemtype_descr && oObj.itemtype_descr.escapeHtml() || ""; } }, Thanks for testing! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- OK, my apologies Magnus. As soon as I cleared my cache everything looks fine. It must have been the JS. The only thing now is the QA tool would git you to rename your commit message: "Bug 29982 - Show itemtype in holds table on patron details" * Commit title does not start with 'Bug XXXXX: ' - 55787708a3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 --- Comment #9 from Magnus Enger <magnus@libriotech.no> --- Created attachment 130144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130144&action=edit Bug 29982: Show itemtype in holds table on patron details Show item type in the holds tables on "Check out" and "Details" tabs in the intranet. To test: - Add an item level hold - Go to patron details and look at the "Check out" tab - Click on the "Holds" horizontal tab and verify the item type is shown in a column between "Title" and "Call number" - Go to the "Details" tab - Click on the "Holds" horizontal tab and verify the display is the same as above - Make a record level hold and verify the item type is not shown in the tables described above - Check in an item from the record level hold, so it is "waiting" for the patron - Verify the item type is now shown in the same way as for the item level hold, as described above -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129995|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 --- Comment #10 from Magnus Enger <magnus@libriotech.no> --- Sorry, bad habit of copying from Bugzilla. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130144|0 |1 is obsolete| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 130147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130147&action=edit Bug 29982: Show itemtype in holds table on patron details Show item type in the holds tables on "Check out" and "Details" tabs in the intranet. To test: - Add an item level hold - Go to patron details and look at the "Check out" tab - Click on the "Holds" horizontal tab and verify the item type is shown in a column between "Title" and "Call number" - Go to the "Details" tab - Click on the "Holds" horizontal tab and verify the display is the same as above - Make a record level hold and verify the item type is not shown in the tables described above - Check in an item from the record level hold, so it is "waiting" for the patron - Verify the item type is now shown in the same way as for the item level hold, as described above Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This looks like a perfect duplicate of bug 30081 - can you please check? *** This bug has been marked as a duplicate of bug 30081 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org