[Bug 11371] New: Add a new report : Orders by budget
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Bug ID: 11371 Summary: Add a new report : Orders by budget Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: fcapovilla@live.ca QA Contact: testopia@bugs.koha-community.org Created attachment 23381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23381&action=edit Add the "Orders by budget" report. This patch adds the "Orders by budget" report to the reports page. This report can generate the list of all orders on a specific budget. The "All budgets" and "All active budgets" options are also available to have different views of all your orders. A "[i]" is also added before the names of inactive budgets in the budget selection box. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 marjorie barry-vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Don't forget to provide unit tests for new routines. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |fcapovilla@live.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23381|0 |1 is obsolete| | --- Comment #2 from Frédérick Capovilla <fcapovilla@live.ca> --- Created attachment 25397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25397&action=edit New patch version with unit tests. Here is a new version of the patch with unit tests for the added subroutines. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron@veron.ch --- Comment #3 from Marc Véron <veron@veron.ch> --- Merge conflict in t/db_dependent/Acquisition.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25397|0 |1 is obsolete| | --- Comment #4 from Frédérick Capovilla <fcapovilla@live.ca> --- Created attachment 25913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25913&action=edit New version of the patch, fixes merge conflict and a small bug. Here is a new version of the patch, fixing the merge conflict and a small bug we found with the biblio titles. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 25915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25915&action=edit [Signed-off]Add the "Orders by budget" report. http://bugs.koha-community.org/show_bug.cgi?id=11371 How I tested: Go to Home > Reports > Orders by budget Select one or all budgets Output to Scrren or CSV file Set a budget to inactive Verify that this budget is marked wit [i] in drop down list (Filters) Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25913|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 25915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25915 [Signed-off]Add the "Orders by budget" report. Review of attachment 25915: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11371&attachment=25915) ----------------------------------------------------------------- Hi Frederick, I know this has been in the loop for a while already, but I found some things that I feel should be addressed. I hope my comments are understandable. I. The QA script points out some things: QA SCRIPT testing 1 commit(s) (applied to 7408fa5 'Bug 8168: (follow-up) Use semicolon a') OK C4/Budgets.pm OK pod OK forbidden patterns OK valid OK critic FAIL reports/orders_by_budget.pl OK pod FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 10) FAIL valid Scalar value @filtered_budgets[0] better written as $filtered_budgets[0] FAIL critic I/O layer ":utf8" used at line 154, column 9. Use ":encoding(UTF-8)" to get strict validation. FAIL t/db_dependent/Acquisition.t OK pod FAIL forbidden patterns forbidden pattern: tab char (line 135) forbidden pattern: tab char (line 136) forbidden pattern: tab char (line 134) forbidden pattern: tab char (line 137) OK valid OK critic FAIL t/db_dependent/Budgets.t OK pod FAIL forbidden patterns forbidden pattern: tab char (line 68) forbidden pattern: tab char (line 67) forbidden pattern: tab char (line 58) forbidden pattern: tab char (line 49) forbidden pattern: tab char (line 50) forbidden pattern: tab char (line 57) OK valid OK critic FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt FAIL forbidden patterns forbidden pattern: tab char (line 36) forbidden pattern: tab char (line 99) forbidden pattern: tab char (line 88) forbidden pattern: tab char (line 90) forbidden pattern: tab char (line 95) forbidden pattern: tab char (line 98) forbidden pattern: tab char (line 100) forbidden pattern: tab char (line 58) forbidden pattern: tab char (line 101) forbidden pattern: tab char (line 15) forbidden pattern: tab char (line 62) forbidden pattern: tab char (line 61) forbidden pattern: tab char (line 77) forbidden pattern: tab char (line 83) forbidden pattern: tab char (line 78) forbidden pattern: tab char (line 57) forbidden pattern: tab char (line 96) forbidden pattern: tab char (line 14) forbidden pattern: tab char (line 82) forbidden pattern: tab char (line 107) forbidden pattern: tab char (line 80) forbidden pattern: tab char (line 89) forbidden pattern: tab char (line 59) OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt FAIL forbidden patterns forbidden pattern: tab char (line 65) OK tt_valid OK valid_template Please fix those. II. Testing the interface 1) I think the budgets should be funds in the interface, or fund (budget) for the pull down list. 2) There is a small display issue with the legend 'Filters' on the first fieldset. The legend shows inside the elemend, instead of above. 3) The list could be improved, showing only funds with orders. But that would be an enhancement. 4) Lots of the date and currency formatting could be handled in the template. But it works and dateformat is honored. III Code review Generally I think there is a bit of confusion about the terminology, visible in the interface and in the naming and documentation of the new routines. The hierarchies in Koha speak are something like: basket group - basket - order/order line budget - fund - child funds I have tried to point those out and also found a few other things: ::: C4/Budgets.pm @@ +476,4 @@
}
# ------------------------------------------------------------------- +sub GetBudgetPeriodDescription {
1) Please add complete documentation to the new routine - I know Budget.pm is a bit sparse on that, but it's still worth not making it worse :) (minor) 2) Please also document the return values (see also below) (minor) @@ +725,5 @@
+=head2 GetBudgetReport + + &GetBudgetReport(); + +Get one specific budget for reports without cancelled baskets.
3) Documentation could be a bit more clear: Get all orders for a specific fund, without cancelled orders. @@ +739,5 @@
+ FROM aqbudgets b + INNER JOIN aqorders o + ON b.budget_id = o.budget_id + WHERE b.budget_id=? + AND (o.datecancellationprinted IS NULL OR o.datecancellationprinted='0000-00-00')
4) The SQL could make use of the new orderstatus column in aqorders to filter out the cancelled orders now. (minor) @@ +755,5 @@
+=head2 GetBudgetsReport + + &GetBudgetsReport(); + +Get all budgets for reports without cancelled baskets.
5) This seems to be mostly a copy of GetActiveBudgetsReport but for the Active bit. Why not move those into one and use a parameter? Suggestion for improving the description: Get all but cancelled orders for all funds. @@ +779,5 @@
+ } + return @results; +} + +=head2 GetActiveBudgets
6) I think the name doesn't fit the use of the routine. GetActiveBudgets will give you inactive budgets when you call it with parameter 0? ::: koha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt @@ +35,5 @@
+ <th>Basket</th> + <th>Basket by</th> + <th>Title</th> + <th>Currency</th> + <th>Vendor Price</th>
7) Tiny thing: capitalization (trivial) ::: koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt @@ +61,4 @@
<h2>Other</h2> <ul> <li><a href="/cgi-bin/koha/reports/itemslost.pl">Items lost</a></li> + <li><a href="/cgi-bin/koha/reports/orders_by_budget.pl">Orders by budget</a></li>
8) Should be orders by fund. ::: reports/orders_by_budget.pl @@ +174,5 @@
+ print '"Total RRP"' . $sep; + print '"Total cost"' . $sep; + print '"Entry date"' . $sep; + print '"Date received"' . $sep; + print '"Notes"' . "\n";
9) These headers won't be translatable. It's an old problem we have solved recently using a TT include. Take a look at the other CSV export options in acquisitions especially. Could be an enhancement. @@ +204,5 @@
+ } +} +else { + # Set file export choices + my $CGIextChoice = CGI::scrolling_list(
10) CGI::scrolling_list shouldn't be used in new scripts, as we are trying to get rid of it totally - see bug 766. @@ +212,5 @@
+ -size => 1, + -multiple => 0 + ); + + my $CGIsepChoice = GetDelimiterChoices;
11) I am not sure there, but avoiding CGIsepChoice might also be preferrable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25915|0 |1 is obsolete| | --- Comment #7 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 30545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30545&action=edit Bug 11731 - Fixed QA warnings and merge conflicts -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #8 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 30546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30546&action=edit Bug 11371 - Follow-up to Comment 6 'Budgets' is now displayed as 'funds' in the Koha UI. Fixed the legend display issue. Improved POD. Use of the orderstatus column to filter canceled orders. GetActiveBudgetsReports has been merged with GetBudgetsReports( [$activity] ). GetActiveBudgets renamed to GetBudgetsByActivity Create templates for .CSV file generation. Removed CGI ui components. new file: koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/reports/orders_by_budget.tt new file: koha-tmpl/intranet-tmpl/prog/en/modules/reports/csv/orders_by_budget.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |maxime.beaulieu@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fcapovilla@live.ca |maxime.beaulieu@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com, | |francois.charbonnier@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simith.doliveira@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Thomas Wright <tomsStudy@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |tomsStudy@gmail.com --- Comment #9 from Thomas Wright <tomsStudy@gmail.com> --- Conflict in 3 files. Unable to resolve the conflict. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #10 from Ahmed <ahmed.sfayhi@inlibro.com> --- Created attachment 35385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35385&action=edit This patch adds the "Orders by budget" report to the reports page. This report can generate the list of all orders on a specific budget. The "All budgets" and "All active budgets" options are also available to have different views of all your orders. A "[i]" is also added before the names of inactive budgets in the budget selection box. How to test: Go to Home > Reports > Orders by budget Select one or all budgets Output to Scrren or CSV file Set a budget to inactive Verify that this budget is marked wit [i] in drop down list (Filters) Sponsored-by: ccsr Bug 11371 - Add a new report : Orders by budget -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Ahmed <ahmed.sfayhi@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |ahmed.sfayhi@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@pttk.fi --- Comment #11 from paxed <pasi.kallinen@pttk.fi> --- (In reply to Ahmed Sfayhi from comment #10)
A "[i]" is also added before the names of inactive budgets in the budget selection box.
That "[i]" is not translatable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- CONFLICT (content): Merge conflict in t/db_dependent/Budgets.t CONFLICT (content): Merge conflict in t/db_dependent/Acquisition.t CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35385|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #13 from simith.doliveira@inlibro.com --- Created attachment 36620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36620&action=edit Add a new report : Orders by budget This patch adds the "Orders by budget" report to the reports page. This report can generate the list of all orders on a specific budget. The "All budgets" and "All active budgets" options are also available to have different views of all your orders. A "[i]" is also added before the names of inactive budgets in the budget selection box. How to test: Go to Home > Reports > Orders by budget Select one or all budgets Output to Scrren or CSV file Set a budget to inactive Verify that this budget is marked wit [i] in drop down list (Filters) Sponsored-by: ccsr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30546|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30545|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #14 from simith.doliveira@inlibro.com --- Conflits fixes and old patchs squashed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nengard@gmail.com --- Comment #15 from Nicole C. Engard <nengard@gmail.com> --- It works great, but failed QA tests: Processing files before patches |========================>| 8 / 8 (100.00%) Processing files after patches |========================>| 8 / 8 (100.00%) FAIL C4/Budgets.pm OK critic OK forbidden patterns FAIL pod *** ERROR: Spurious text after =cut in file C4/Budgets.pm OK valid FAIL reports/orders_by_budget.pl OK critic OK forbidden patterns OK pod FAIL valid Possible attempt to separate words with commas -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #16 from simith.doliveira@inlibro.com --- Created attachment 36707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36707&action=edit QA fix -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36620|0 |1 is obsolete| | --- Comment #17 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 37010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37010&action=edit Add a new report : Orders by budget This patch adds the "Orders by budget" report to the reports page. This report can generate the list of all orders on a specific budget. The "All budgets" and "All active budgets" options are also available to have different views of all your orders. A "[i]" is also added before the names of inactive budgets in the budget selection box. How to test: Go to Home > Reports > Orders by budget Select one or all budgets Output to Scrren or CSV file Set a budget to inactive Verify that this budget is marked wit [i] in drop down list (Filters) Sponsored-by: ccsr http://bugs.koha-community.org/show_bug.cgi?id=11371 Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36707|0 |1 is obsolete| | --- Comment #18 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 37011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37011&action=edit QA fix http://bugs.koha-community.org/show_bug.cgi?id=11371 Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Patch complexity|Small patch |Medium patch --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: 1/ Please rename the script according to previous change (budget vs fund). 2/ Add basket name in the basket column 3/ Get rid of the warning: FAIL reports/orders_by_budget.pl FAIL valid Possible attempt to put comments in qw() list Possible attempt to separate words with commas The no warnings qw() is not a correct solution (and does not work) 4/ default separator should be chosen (syspref "delimiter") 5/ Add DataTables on the table could be useful and easy. 6/ Both tests fail: t/db_dependent/Budgets.t .. 58/120 DBIx::Class::Row::new(): No such column 'budget_description' on Koha::Schema::Result::Aqbudgetperiod at C4/Budgets.pm line 144 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37010|0 |1 is obsolete| | --- Comment #20 from Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> --- Created attachment 41463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41463&action=edit Add a new report : Orders by budget This patch adds the "Orders by budget" report to the reports page. This report can generate the list of all orders on a specific budget. The "All budgets" and "All active budgets" options are also available to have different views of all your orders. A "[i]" is also added before the names of inactive budgets in the budget selection box. How to test: Go to Home > Reports > Orders by budget Select one or all budgets Output to Scrren or CSV file Set a budget to inactive Verify that this budget is marked wit [i] in drop down list (Filters) Sponsored-by: ccsr http://bugs.koha-community.org/show_bug.cgi?id=11371 Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37011|0 |1 is obsolete| | --- Comment #21 from Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> --- Created attachment 41464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41464&action=edit Bug11371 - QA fix http://bugs.koha-community.org/show_bug.cgi?id=11371 Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |remi.mayrand-provencher@inL | |ibro.com Status|Failed QA |Needs Signoff --- Comment #22 from Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> --- Fixed Conflicts in first patch and updated QA fix -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust@univ-lyo | |n2.fr Status|Needs Signoff |Failed QA --- Comment #23 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- Everything seems ok except the csv file where some columns don't have the right datas : column "basket by" contains the name of the basket column "biblionumber" contains librarian id column title contains biblionumber currency contains Title Vendor price contains Currency etc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani@inlibro.com Assignee|maxime.beaulieu@inlibro.com |bouzid.fergani@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #24 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 45243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45243&action=edit Bug 11371 - Correct right data in each column and correct format date and tidying up in template file -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #25 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 45244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45244&action=edit Bug 11371 - Correct right data in each column and correct format date and tidying up in template file -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45243|0 |1 is obsolete| | Attachment #45244|0 |1 is obsolete| | --- Comment #26 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 45245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45245&action=edit Bug 11371 - fix problem with right data in each column in csv file fix problem with right data in each column correct format date tidying up in template file -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #27 from Marc Véron <veron@veron.ch> --- Applying the patches does some auto-merging: Auto-merging t/db_dependent/Budgets.t Auto-merging C4/Budgets.pm After that, t/db_dependent/Budgets.t fails (it passed OK without patches): Test Summary Report ------------------- t/db_dependent/Budgets.t (Wstat: 65280 Tests: 76 Failed: 1) Failed test: 76 Non-zero exit status: 255 Parse errors: Bad plan. You planned 122 tests but ran 76 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #28 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 45288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45288&action=edit Bug 11371 - QA fix 2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #29 from Bouzid <bouzid.fergani@inlibro.com> --- I fixed all tests for this patch, but a failed QA on the master before application of the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #30 from Marc Véron <veron@veron.ch> --- Sorry, t/db_dependent/Budgets.t fails with: Parse errors: Bad plan. You planned 122 tests but ran 126. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45288|0 |1 is obsolete| | --- Comment #31 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 45338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45338&action=edit Bug 11371 - QA fix, Parse errors: Bad plan -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41463|0 |1 is obsolete| | Attachment #41464|0 |1 is obsolete| | Attachment #45245|0 |1 is obsolete| | Attachment #45338|0 |1 is obsolete| | --- Comment #32 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 45887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45887&action=edit Bug 11371 - Add a new report : Orders by budget This patch adds the "Orders by budget" report to the reports page. This report can generate the list of all orders on a specific budget. The "All budgets" and "All active budgets" options are also available to have different views of all your orders. A "[i]" is also added before the names of inactive budgets in the budget selection box. How to test: Go to Home > Reports > Orders by budget Select one or all budgets Output to Scrren or CSV file Set a budget to inactive Verify that this budget is marked wit [i] in drop down list (Filters) Sponsored-by: ccsr http://bugs.koha-community.org/show_bug.cgi?id=11371 Author: bouzid <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #33 from Bouzid <bouzid.fergani@inlibro.com> --- In this patch, I fix many problems, most important is note not appear. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45887|0 |1 is obsolete| | --- Comment #34 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 45890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45890&action=edit Bug 11371 - Add a new report : Orders by budget This patch adds the "Orders by budget" report to the reports page. This report can generate the list of all orders on a specific budget. The "All budgets" and "All active budgets" options are also available to have different views of all your orders. A "[i]" is also added before the names of inactive budgets in the budget selection box. How to test: Go to Home > Reports > Orders by budget Select one or all budgets Output to Scrren or CSV file Set a budget to inactive Verify that this budget is marked wit [i] in drop down list (Filters) Sponsored-by: ccsr http://bugs.koha-community.org/show_bug.cgi?id=11371 Author: bouzid <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #35 from Marc Véron <veron@veron.ch> --- Without patch, t/db_dependent/Acquisition.t runs OK With patch there is an error: (...) DBIx::Class::ResultSet::create(): No such column budget_description on Koha::Schema::Result::Aqbudgetperiod at /usr/share/kohaclone/C4/Budgets.pm line 143 (...) (Wstat: 65280 Tests: 10 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 87 tests but ran 10. Note: The field budget_description was dropped in installer/data/mysql/updatedatabase.pl line 4277 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45890|0 |1 is obsolete| | --- Comment #36 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 45981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45981&action=edit Bug 11371 - Add a new report : Orders by budget This patch adds the "Orders by budget" report to the reports page. This report can generate the list of all orders on a specific budget. The "All budgets" and "All active budgets" options are also available to have different views of all your orders. A "[i]" is also added before the names of inactive budgets in the budget selection box. How to test: apply patch run updatedatabase.pl Go to Home > Reports > Orders by budget Select one or all budgets Output to Scrren or CSV file Set a budget to inactive Verify that this budget is marked wit [i] in drop down list (Filters) Sponsored-by: ccsr http://bugs.koha-community.org/show_bug.cgi?id=11371 Author: bouzid <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45981|0 |1 is obsolete| | --- Comment #37 from Marc Véron <veron@veron.ch> --- Created attachment 45982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45982&action=edit Bug 11371 - Add a new report : Orders by budget This patch adds the "Orders by budget" report to the reports page. This report can generate the list of all orders on a specific budget. The "All budgets" and "All active budgets" options are also available to have different views of all your orders. A "[i]" is also added before the names of inactive budgets in the budget selection box. How to test: apply patch run updatedatabase.pl Go to Home > Reports > Orders by budget Select one or all budgets Output to Scrren or CSV file Set a budget to inactive Verify that this budget is marked wit [i] in drop down list (Filters) Sponsored-by: ccsr http://bugs.koha-community.org/show_bug.cgi?id=11371 Author: bouzid <bouzid.fergani@inlibro.com> Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 45982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45982 Bug 11371 - Add a new report : Orders by budget Review of attachment 45982: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11371&attachment=45982) ----------------------------------------------------------------- I am not convinced by the new subroutines you add with this patch. There are usually too specific and could be done with existing subroutines from C4::Acquisition or C4::Budgets The main problem is that there is not real test coverage for them. ::: C4/Budgets.pm @@ +473,5 @@
+ Description is fetched from aqbudgetperiods, id is compared aqbudgets. (INNER JOIN on budget_period_id) + +=cut + +sub GetBudgetPeriodDescription {
This subroutine is too specific. It could be replaced with my $budget_period = GetBudgetPeriod( $budget->{budget_period_id} ) my $budget_period_description = $budget_period->{budget_period_description} -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart@bugs.koha-c | |ommunity.org | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org