[Bug 34101] New: Limit items types that can be checked out via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 Bug ID: 34101 Summary: Limit items types that can be checked out via SIP2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Some libraries have different types of SIP2 checkout stations - staffed or unstaffed. There are certin itemtypes (passes, equipment, etc.) that should not be checked out from unstaffed stations, This bug proposes to add the ability to define a list of item types in the SIP configuration for an account and prevent those items from being issued by that SIP account -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |samalau@gmail.com |ity.org | CC| |samalau@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 --- Comment #1 from Sam Lau <samalau@gmail.com> --- Created attachment 152773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152773&action=edit Bug 34101: Unit Tests prove t/db_dependent/SIP/Message.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 152774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152774&action=edit Bug 34101: Limit items types that can be checked out via SIP2 This bug adds the ability to define a list of item types that are blocked from being issued at that SIP account To test: 1) Apply this patch 2) Visit Administration->Item types and select edit on the music item type 3) Make the rental charge 0 and save changes (this allows for the item to be checked out via SIP) 4) In the terminal, vim /etc/koha/sites/kohadev/SIPconfig.xml 5) Edit the term1 account and add the following *inside* the login section: blocked_item_types="BK|MU" You should have something similar to this: <login id ="term1" ........... checked_in_ok="1" blocked_item_types="BK|MU" /> 6) Restart SIP (sudo koha-sip --restart <instancename>) 7) Run a checkout query for an item with the item type book. Here is an example you could use: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529001000463 --item 39999000011418-m checkout 8) Notice the checkout failed and you are given the screen msg "Item type cannot be checked out at this checkout location" 9) Run a checkout query for an item with the item type music. Here is an example you could use: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529001000463 --item 39999000008715 -m checkout 10) Notice the checkout failed and you are given the screen msg "Item type cannot be checked out at this checkout location" 11) vim /etc/koha/sites/kohadev/SIPconfig.xml and delete the BK from the blocked_item 12) Delete the BK from blocked_item_types. It should now look like : blocked_item_types="MU" 13) Restart SIP (sudo koha-sip --restart <instancename>) 14) Run a checkout query for the item with the item type book perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529001000463 --item 39999000011418 -m checkout 15) Checkout succesful 16) Run a checkout query for the item with the item type music perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529001000463 --item 39999000008715 -m checkout 17) Still fails (because it is blocked) 18) prove t/db_dependent/SIP/Message.t 19) Congratulate yourself for making it through the long test and sign-off :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152773|0 |1 is obsolete| | Attachment #152774|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 152798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152798&action=edit Bug 34101: Unit Tests prove t/db_dependent/SIP/Message.t Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 152799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152799&action=edit Bug 34101: Limit items types that can be checked out via SIP2 This bug adds the ability to define a list of item types that are blocked from being issued at that SIP account To test: 1) Apply this patch 2) Visit Administration->Item types and select edit on the music item type 3) Make the rental charge 0 and save changes (this allows for the item to be checked out via SIP) 4) In the terminal, vim /etc/koha/sites/kohadev/SIPconfig.xml 5) Edit the term1 account and add the following *inside* the login section: blocked_item_types="BK|MU" You should have something similar to this: <login id ="term1" ........... checked_in_ok="1" blocked_item_types="BK|MU" /> 6) Restart SIP (sudo koha-sip --restart <instancename>) 7) Run a checkout query for an item with the item type book. Here is an example you could use: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529001000463 --item 39999000011418-m checkout 8) Notice the checkout failed and you are given the screen msg "Item type cannot be checked out at this checkout location" 9) Run a checkout query for an item with the item type music. Here is an example you could use: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529001000463 --item 39999000008715 -m checkout 10) Notice the checkout failed and you are given the screen msg "Item type cannot be checked out at this checkout location" 11) vim /etc/koha/sites/kohadev/SIPconfig.xml and delete the BK from the blocked_item 12) Delete the BK from blocked_item_types. It should now look like : blocked_item_types="MU" 13) Restart SIP (sudo koha-sip --restart <instancename>) 14) Run a checkout query for the item with the item type book perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529001000463 --item 39999000011418 -m checkout 15) Checkout succesful 16) Run a checkout query for the item with the item type music perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529001000463 --item 39999000008715 -m checkout 17) Still fails (because it is blocked) 18) prove t/db_dependent/SIP/Message.t 19) Congratulate yourself for making it through the long test and sign-off :) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152798|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152924&action=edit Bug 34101: Unit Tests prove t/db_dependent/SIP/Message.t Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152799|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152925&action=edit Bug 34101: Limit items types that can be checked out via SIP2 This bug adds the ability to define a list of item types that are blocked from being issued at that SIP account To test: 1) Apply this patch 2) Visit Administration->Item types and select edit on the music item type 3) Make the rental charge 0 and save changes (this allows for the item to be checked out via SIP) 4) In the terminal, vim /etc/koha/sites/kohadev/SIPconfig.xml 5) Edit the term1 account and add the following *inside* the login section: blocked_item_types="BK|MU" You should have something similar to this: <login id ="term1" ........... checked_in_ok="1" blocked_item_types="BK|MU" /> 6) Restart SIP (sudo koha-sip --restart <instancename>) 7) Run a checkout query for an item with the item type book. Here is an example you could use: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529001000463 --item 39999000011418-m checkout 8) Notice the checkout failed and you are given the screen msg "Item type cannot be checked out at this checkout location" 9) Run a checkout query for an item with the item type music. Here is an example you could use: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529001000463 --item 39999000008715 -m checkout 10) Notice the checkout failed and you are given the screen msg "Item type cannot be checked out at this checkout location" 11) vim /etc/koha/sites/kohadev/SIPconfig.xml and delete the BK from the blocked_item 12) Delete the BK from blocked_item_types. It should now look like : blocked_item_types="MU" 13) Restart SIP (sudo koha-sip --restart <instancename>) 14) Run a checkout query for the item with the item type book perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529001000463 --item 39999000011418 -m checkout 15) Checkout succesful 16) Run a checkout query for the item with the item type music perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529001000463 --item 39999000008715 -m checkout 17) Still fails (because it is blocked) 18) prove t/db_dependent/SIP/Message.t 19) Congratulate yourself for making it through the long test and sign-off :) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work.. all looks good here. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 Christofer Zorn <christofer.zorn@ajaxlibrary.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christofer.zorn@ajaxlibrary | |.ca --- Comment #9 from Christofer Zorn <christofer.zorn@ajaxlibrary.ca> --- Thank you for your hard work on this everyone! Is it possible to have this back ported to either 23.05 or 22.11, or both? Thanks! Chris -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- As this requires serverside configuration changes to have any effect, I think we're safe to backport this one to 23.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35130 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marion.durand@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 --- Comment #13 from Marion Durand <marion.durand@biblibre.com> --- I documented this option in the wiki https://wiki.koha-community.org/wiki/SIP2_configuration#blocked_item_type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Marion Durand contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34101 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation|Marion Durand |marion.durand@biblibre.com contact| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org