http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7851 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|circ/circulation.pl plack |circ/circulation.pl plack |checkouts table empty |scoping --- Comment #1 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Variable "$totalprice" is not available at /srv/koha/circ/circulation.pl line 448. Variable "%renew_failed" is not available at /srv/koha/circ/circulation.pl line 456. Variable "$todaysdate" is not available at /srv/koha/circ/circulation.pl line 458. Variable "@todaysissues" is not available at /srv/koha/circ/circulation.pl line 459. Variable "@relissues" is not available at /srv/koha/circ/circulation.pl line 459. Variable "@previousissues" is not available at /srv/koha/circ/circulation.pl line 461. Variable "@relprevissues" is not available at /srv/koha/circ/circulation.pl line 461. Subroutine build_issue_data redefined at /srv/koha/circ/circulation.pl line 422. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7851 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7851 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8723|0 |1 is obsolete| | --- Comment #4 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 8766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8766&action=edit [Signed-off] Bug 7851 - circ/circulation.pl plack scoping Errors: Variable "$totalprice" is not available at /srv/koha/circ/circulation.pl line 448. Variable "%renew_failed" is not available at /srv/koha/circ/circulation.pl line 456. Variable "$todaysdate" is not available at /srv/koha/circ/circulation.pl line 458. Variable "@todaysissues" is not available at /srv/koha/circ/circulation.pl line 459. Variable "@relissues" is not available at /srv/koha/circ/circulation.pl line 459. Variable "@previousissues" is not available at /srv/koha/circ/circulation.pl line 461. Variable "@relprevissues" is not available at /srv/koha/circ/circulation.pl line 461. Test scenario: 1. go to circulation page 2. verify errors in console output of plack 3. apply patch 4. reload and verify that errors are gone Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7851 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> --- more rescoping 'my' to 'our'. Fixes issues caused by the nested build_issues_data subroutine... ideally this subroutine should be removed from circ/circulation.pl (and it's hideous twin brother from members/moremember.pl), but that's a larger project than just adjusting scopes. Passed QA. -- You are receiving this mail because: You are watching all bug changes.