[Bug 23429] New: ilsdi.pl GetRecords documentation does not match output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 Bug ID: 23429 Summary: ilsdi.pl GetRecords documentation does not match output Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: J.P.Knight@lboro.ac.uk QA Contact: testopia@bugs.koha-community.org The ILS-DI GetRecords self generated documentation no longer matches up with the output that the script generates. It probably should. :-) For example, the documentation says that the <item> element contains a <date_due> element. This was the case back in 16.x versions of Koha, but on our production 18.11.04 we no longer get this field, but we do get an <onloan> field in item instead (which luckily serves the same purpose as we need - we just need to know if each item is on loan or not). Here's the example format for the <item> part of the record generated by http://ourserver/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetRecords <items> <item> <biblioitemnumber>1</biblioitemnumber> <withdrawn>0</withdrawn> <holdingbranchname>Bibliothèque Jean Prunier</holdingbranchname> <notforloan>0</notforloan> <replacementpricedate>2008-08-20</replacementpricedate> <itemnumber>1</itemnumber> <location>Secteur Adulte</location> <itemcallnumber>R ABE</itemcallnumber> <date_due></date_due> <itemlost>0</itemlost> <datelastseen>2008-08-20</datelastseen> <homebranch>BIB</homebranch> <homebranchname>Bibliothèque Jean Prunier</homebranchname> <biblionumber>1</biblionumber> <holdingbranch>BIB</holdingbranch> <timestamp>2008-08-20 17:15:51</timestamp> <damaged>0</damaged> <cn_sort>R_ABE</cn_sort> <dateaccessioned>2008-08-20</dateaccessioned> </item> </items> And here's what we get out for an actual search: <items> <item> <onloan>2019-10-01</onloan> <holdingbranch>MAINLIB</holdingbranch> <location>MAIN</location> <datelastborrowed>2019-07-18</datelastborrowed> <biblioitemnumber>526315</biblioitemnumber> <permanent_location>MAIN</permanent_location> <datelastseen>2019-07-18</datelastseen> <withdrawn>0</withdrawn> <itype>LONG</itype> <notforloan>0</notforloan> <biblionumber>526315</biblionumber> <itemnumber>847332</itemnumber> <price>22.17</price> <dateaccessioned>2016-09-13</dateaccessioned> <issues>10</issues> <homebranchname>Main Library</homebranchname> <homebranch>MAINLIB</homebranch> <timestamp>2019-07-18 17:03:03</timestamp> <cn_sort>005_550000000000000_SPS_BRA</cn_sort> <itemlost>0</itemlost> <renewals>28</renewals> <barcode>040444587X</barcode> <damaged>0</damaged> <replacementpricedate>2018-02-01</replacementpricedate> <itemcallnumber>005.55 SPS/BRA</itemcallnumber> <holdingbranchname>Main Library</holdingbranchname> </item> </items> Note the <date_due></date_due> in the example is missing from the real output, which has <onloan>...</onloan> instead. I guess we need to decide if the documentation is just out of date with the code, or if the code should be generating things it isn't any more. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 --- Comment #1 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 92405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92405&action=edit Bug 23429: ilsdi.pl GetRecords documentation does not match output Updated contents of Describe for GetRecords to match current behaviour. To test, ensure ILSDI is configured and then compare the output of: http://yourserver/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetRecords before and after applying the patch. Note that afterwards it includes things like <onloan> and has removed elements such as <date_due> that no longer get returned. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92405|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94978&action=edit Bug 23429: ilsdi.pl GetRecords documentation does not match output Updated contents of Describe for GetRecords to match current behaviour. To test, ensure ILSDI is configured and then compare the output of: http://yourserver/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetRecords before and after applying the patch. Note that afterwards it includes things like <onloan> and has removed elements such as <date_due> that no longer get returned. https://bugs.koha-community.org/show_bug.cgi?id=23429 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Nice improvement, Thx Jon! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | Assignee|koha-bugs@lists.koha-commun |J.P.Knight@lboro.ac.uk |ity.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94978|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 94979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94979&action=edit Bug 23429: ilsdi.pl GetRecords documentation does not match output Updated contents of Describe for GetRecords to match current behaviour. To test, ensure ILSDI is configured and then compare the output of: http://yourserver/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetRecords before and after applying the patch. Note that afterwards it includes things like <onloan> and has removed elements such as <date_due> that no longer get returned. https://bugs.koha-community.org/show_bug.cgi?id=23429 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org