[Bug 28119] New: Use full description in layout type selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 Bug ID: 28119 Summary: Use full description in layout type selection Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I noticed that in C4::Creators::Lib.pm descriptions are defined for layout types. The label layout template uses layout type "names" instead of these descriptions, which I don't think is as helpful. I propose to copy the description text from Lib.pm to use in label-edit-layout.tt as the text for the layout type <option> labels. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119372&action=edit Bug 28119: Use full description in layout type selection This patch changes the template for editing label layout so that a full description of label types is shown to the user rather than brief names. To test, apply the patch and go to Tools -> Label creator -> New -> Layout. - On the "Choose layout type" line you should see selections with full descriptions, e.g. "Only the barcode is printed." - Choose a layout type and save the layout. Confirm that your choice was saved correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119372|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 119439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119439&action=edit Bug 28119: Use full description in layout type selection This patch changes the template for editing label layout so that a full description of label types is shown to the user rather than brief names. To test, apply the patch and go to Tools -> Label creator -> New -> Layout. - On the "Choose layout type" line you should see selections with full descriptions, e.g. "Only the barcode is printed." - Choose a layout type and save the layout. Confirm that your choice was saved correctly. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I agree that having more meaningful descriptions here is much more useful than just the code. Only a really very trivial comment - should the options have a full stop at the end of the sentence? The option descriptions are full sentences and it would normally makes sense to have a full stop. However, it looks a little out of place with all the other drop down lists that don't. Either way, it is a nice improvement over the way it is now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I was going to tell the same as David about the full stop. Owen what do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119558&action=edit Bug 28119: (follow-up) Remove unnecessary punctuation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should it be proceeds or not maybe preceeds? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119439|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119810&action=edit Bug 28119: Use full description in layout type selection This patch changes the template for editing label layout so that a full description of label types is shown to the user rather than brief names. To test, apply the patch and go to Tools -> Label creator -> New -> Layout. - On the "Choose layout type" line you should see selections with full descriptions, e.g. "Only the barcode is printed." - Choose a layout type and save the layout. Confirm that your choice was saved correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119558|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119811&action=edit Bug 28119: (follow-up) Remove unnecessary punctuation Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119810|0 |1 is obsolete| | Attachment #119811|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119947&action=edit Bug 28119: Use full description in layout type selection This patch changes the template for editing label layout so that a full description of label types is shown to the user rather than brief names. To test, apply the patch and go to Tools -> Label creator -> New -> Layout. - On the "Choose layout type" line you should see selections with full descriptions, e.g. "Only the barcode is printed." - Choose a layout type and save the layout. Confirm that your choice was saved correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 28119: (follow-up) Remove unnecessary punctuation Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 --- Comment #11 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #6)
Should it be proceeds or not maybe preceeds?
Nice catch Katrin! It should be "preceeds".. "before" is also an alternative. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement changes release notes| |the display of the drop | |down list when adding and | |editing label layouts | |(Tools > Label creator > | |Layouts) so that a full | |description of label types | |is shown instead of brief | |names. For example: "Only | |the barcode is printed" | |instead of "BAR". Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28119 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org