[Bug 16351] New: Error when trying to receive a new shipment without specifying invoice number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16351 Bug ID: 16351 Summary: Error when trying to receive a new shipment without specifying invoice number Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org Triggers an error if you don't specify an invoice number. This could be avoided by making invoice number a required field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16351 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16351 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50692&action=edit Bug 16351: Making invoice number a required field To test: 1) Go to Acqui -> Do a vendor search 2) Receive a shipment 3) Attempt to click 'Next' without specifying invoice number. Notice error. 4) Go back to vendor search then apply patch. Click Receive shipment 5) Notice you cannot click 'Next' until you put something in invoice number. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16351 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16351 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Please add the "validated" class to the <form> so that the validation plugin can pick up the required fields. I realize it's not strictly necessary because of the browser's built-in handling of required fields, but I think it makes the user's experience more consistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16351 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16351 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50692|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50772&action=edit Bug 16351: Making invoice number a required field EDIT: Added 'validated' class to form and removed 'Required' span (became unnecessary) To test: 1) Go to Acqui -> Do a vendor search 2) Receive a shipment 3) Attempt to click 'Next' without specifying invoice number. Notice error. 4) Go back to vendor search then apply patch. Click Receive shipment 5) Notice you cannot click 'Next' until you put something in invoice number. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16351 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16351 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50772|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 50816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50816&action=edit Bug 16351: Making invoice number a required field EDIT: Added 'validated' class to form and removed 'Required' span (became unnecessary) To test: 1) Go to Acqui -> Do a vendor search 2) Receive a shipment 3) Attempt to click 'Next' without specifying invoice number. Notice error. 4) Go back to vendor search then apply patch. Click Receive shipment 5) Notice you cannot click 'Next' until you put something in invoice number. Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16351 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16351 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16351 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50816|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50836&action=edit [PASSED QA] Bug 16351: Making invoice number a required field EDIT: Added 'validated' class to form and removed 'Required' span (became unnecessary) To test: 1) Go to Acqui -> Do a vendor search 2) Receive a shipment 3) Attempt to click 'Next' without specifying invoice number. Notice error. 4) Go back to vendor search then apply patch. Click Receive shipment 5) Notice you cannot click 'Next' until you put something in invoice number. Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16351 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Passed QA |Signed Off --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Note: Error is only shown when AcqWarnOnDuplicateInvoice is not in use. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16351 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16351 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, should be in the May 2016 release! Thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org