[Bug 18881] New: Use translated description in itemtype circ/ view_holdsqueue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Bug ID: 18881 Summary: Use translated description in itemtype circ/view_holdsqueue.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Translated itemtype description is not used in display of Holds queue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18859 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 [Bug 18859] Warns when accessing Circulation -> Holds Queue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use translated description |Remove comment about |in itemtype |translated description in |circ/view_holdsqueue.pl |itemtype | |circ/view_holdsqueue.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #1 from Marc Véron <veron@veron.ch> --- (In reply to Marc Véron from comment #0)
Translated itemtype description is not used in display of Holds queue
Translated itemtype descriptions display OK, but there is a superfluous comment in circ/view_holdsqueue.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove comment about |Remove comment about |translated description in |translated itemtype |itemtype |description in |circ/view_holdsqueue.pl |circ/view_holdsqueue.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 64726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64726&action=edit Bug 18881: Remove comment about translated itemtype description in circ/view_holdsqueue.pl This patch removes a superfluous FIXME comment. To test: Compare code, verify that comment correctly is removed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Marc Véron from comment #1)
(In reply to Marc Véron from comment #0)
Translated itemtype description is not used in display of Holds queue
Translated itemtype descriptions display OK, but there is a superfluous comment in circ/view_holdsqueue.pl
It is because your description is translated in the first place, or does switching languages actually give a valid translation for each language? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #4 from Marc Véron <veron@veron.ch> --- (In reply to M. Tompsett from comment #3)
(In reply to Marc Véron from comment #1)
(In reply to Marc Véron from comment #0)
Translated itemtype description is not used in display of Holds queue
Translated itemtype descriptions display OK, but there is a superfluous comment in circ/view_holdsqueue.pl
It is because your description is translated in the first place, or does switching languages actually give a valid translation for each language?
To have translated item descriptions you can go to Home > Administration > Item types > Modify item type 'BK' There you have a link 'Translate into other languages' to create translations To test, you can even 'translate' for English to overwrite the original description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Marc Véron from comment #4)
To have translated item descriptions you can go to Home > Administration > Item types > Modify item type 'BK'
There you have a link 'Translate into other languages' to create translations To test, you can even 'translate' for English to overwrite the original description.
But that is by overwriting the actual description. Not by just changing the language selected. I think the comment was about having a way to po-i-size it. Patch is okay, but it's really a commentary on having DB translations, not just templates, I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Did you check the description Marc gave? The value will change with switching the language if you have configured it. It doesn't make sense to have po files for configurable values that are different for each library. The new way to save the translations in a separate table works better, as every library can change it any time. I think Marc's patch is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #7 from Marc Véron <veron@veron.ch> --- (In reply to M. Tompsett from comment #5)
(In reply to Marc Véron from comment #4)
To have translated item descriptions you can go to Home > Administration > Item types > Modify item type 'BK'
There you have a link 'Translate into other languages' to create translations To test, you can even 'translate' for English to overwrite the original description.
But that is by overwriting the actual description. Not by just changing the language selected. I think the comment was about having a way to po-i-size it. Patch is okay, but it's really a commentary on having DB translations, not just templates, I think.
Maybe there is a misunderstanding. - Item types are defined by the library (or loaded together with the example values, in the language choosen for installation). - When defining an item type, the library can define translations for other (installed) languages as well. E.g. in Switzerland a library could define an item type with code 'BUCH' and the description "Buch" for German and the translated descriptions "Livre" for French and "Libro" for Italian - The (translated) description appears (is overlayed) depending on the language selected by the user. - You can not po-i-size that because the library defines the item types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Marc Véron from comment #7)
Maybe there is a misunderstanding.
Perhaps. I'll just remove myself for the conversation. Please continue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mtompset@hotmail.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Needs Signoff |Failed QA --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- If we remove this comment, some day somebody wonders again why we do not use the translated description. So instead of removing I would opt for adding a legitimate reason why we really do not want a translation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove comment about |Change comment about |translated itemtype |translated itemtype |description in |description in |circ/view_holdsqueue.pl |circ/view_holdsqueue.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Summary|Change comment about |Remove dead code in |translated itemtype |circ/view_holdsqueue.pl |description in | |circ/view_holdsqueue.pl | --- Comment #10 from Marc Véron <veron@veron.ch> --- (In reply to Marcel de Rooy from comment #9)
If we remove this comment, some day somebody wonders again why we do not use the translated description. So instead of removing I would opt for adding a legitimate reason why we really do not want a translation.
The translation takes place by overlaying in the template, using the itemtype. The whole line is dead code. Changed bug title as appropriate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64726|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #11 from Marc Véron <veron@veron.ch> --- Created attachment 64761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64761&action=edit Bug 18881: Remove dead code in circ/view_holdsqueue.pl Remove a line of dead code from circ/view_holdsqueue.pl To test: - Apply patch - Go to Home > Circulation > Holds queue - Verify that description in Item type column displays as before - Create a translation for an item type: Home > Administration > Item types > Modify item type 'BK' There you have a link 'Translate into other languages' to create translations To test, you can even 'translate' for English to overwrite the original description. - Verify that the translated descriptions displays when changing the language as appropriate - For an explanation how translation of item types descriptions work and why it is not done with Pootle see comment #7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Applying: Bug 18881: Remove dead code in circ/view_holdsqueue.pl fatal: sha1 information is lacking or useless (circ/view_holdsqueue.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #13 from Marc Véron <veron@veron.ch> --- (In reply to Marcel de Rooy from comment #12)
Applying: Bug 18881: Remove dead code in circ/view_holdsqueue.pl fatal: sha1 information is lacking or useless (circ/view_holdsqueue.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge.
Re-tested, applies cleanly here (on top of Bug 18859). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- *** Bug 18859 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Bug 18881 depends on bug 18859, which changed state. Bug 18859 Summary: Warns when accessing Circulation -> Holds Queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18859 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 [Bug 18859] Warns when accessing Circulation -> Holds Queue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64769&action=edit Bug 18881: Remove dead code from view_holdsqueue.pl Aleisha spotted the typo in $itemtypes and proposed a correction on bug 18859. The description was not even used. Template calls GetDescription. To test: Verify that viewing the holds queue still works as expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 64770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64770&action=edit Bug 18881: [QA Follow-up] Remove even more Removing the commented section from the template: If it does not work, it should not be here. When it works again, put it back in. Since @itemtypesloop is not used, remove it from the script too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Taking the liberty to move this directly into PQA now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #19 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.02 Dead code go to hell ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Severity|trivial |enhancement Resolution|--- |FIXED --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org