[Bug 37328] New: Cannot delete report after using Update and Run SQL button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 Bug ID: 37328 Summary: Cannot delete report after using Update and Run SQL button Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: andrewfh@dubcolib.org QA Contact: testopia@bugs.koha-community.org To recreate: - create a report or edit an existing one - on the edit screen (/cgi-bin/koha/reports/guided_reports.pl?id=XXX&op=edit_form), click "Update and run SQL" - On the resulting page, where you see both your results and the edit form, click Edit and then Delete - Nothing happens. The delete confirm modal doesn't appear, so the deletion doesn't move forward. The url on that results + edit screen is just "/cgi-bin/koha/reports/guided_reports.pl" -- I don't know if that's part of the issue? The report can still be deleted from other pages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org --- Comment #1 from Katie Bliss <kebliss@dmpl.org> --- It also seems that the Rows Per Page button doesn't work after clicking Update and Run SQL. Same as what Andrew describes above, after Update and Run, click on Rows Per Page and select a different number of rows--nothing happens. Though if I rerun the report (with the Run Report button at the top), the Rows Per Page button does work as normal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cj.lynce@westlakelibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 --- Comment #2 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 170872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170872&action=edit Bug 37328: Cannot delete report after using Update and Run SQL button Fixes the ability to delete a report from the report toolbar menu after running the report. To test: 1) Login to staff client 2) Navigate to Reports -> Create from SQL 3) Create a short report (SELECT * FROM items), name it and SAVE it. 4) On the resulting "Edit SQL report' page, click 'Update and run SQL' 5) On the toolbar, click Edit -> Delete Nothing happens 6) Apply patch 7) Return to Reports -> Saved Reports and Edit the report you created. 8) On "Edit SQL report' page, click 'Update and run SQL' 9) On the toolbar, click Edit -> Delete The report is now deleted. Sponsored-by: Westlake Porter Public Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170872|0 |1 is obsolete| | --- Comment #3 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 170874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170874&action=edit Bug 37328: Cannot delete report after using Update and Run SQL button Fixes the ability to delete a report from the report toolbar menu after running the report, including displaying the delete confirm modal. To test: 1) Login to staff client 2) Navigate to Reports -> Create from SQL 3) Create a short report (SELECT * FROM items), name it and SAVE it. 4) On the resulting "Edit SQL report' page, click 'Update and run SQL' 5) On the toolbar, click Edit -> Delete Nothing happens 6) Apply patch 7) Return to Reports -> Saved Reports and Edit the report you created. 8) On "Edit SQL report' page, click 'Update and run SQL' 9) On the toolbar, click Edit -> Delete 10) Confirm the delete modal. The report is now deleted. Sponsored-by: Westlake Porter Public Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.05 |Main --- Comment #4 from CJ Lynce <cj.lynce@westlakelibrary.org> --- It appears that the Rows per page issue has a resolution incoming over on bug_37745 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cj.lynce@westlakelibrary.or |ity.org |g -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 --- Comment #5 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Also, I tried applying this patch on 24.05.03, but it would not work. Turns out, in 24.05, the delete button issue is related to the issue on bug 37763, and that patch fixes the delete button after Update and run SQL. Main also had issues with the delete button, for a completely separate reason, which this patch fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170874|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 171167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171167&action=edit Bug 37328: Cannot delete report after using Update and Run SQL button Fixes the ability to delete a report from the report toolbar menu after running the report, including displaying the delete confirm modal. To test: 1) Login to staff client 2) Navigate to Reports -> Create from SQL 3) Create a short report (SELECT * FROM items), name it and SAVE it. 4) On the resulting "Edit SQL report' page, click 'Update and run SQL' 5) On the toolbar, click Edit -> Delete Nothing happens 6) Apply patch 7) Return to Reports -> Saved Reports and Edit the report you created. 8) On "Edit SQL report' page, click 'Update and run SQL' 9) On the toolbar, click Edit -> Delete 10) Confirm the delete modal. The report is now deleted. Sponsored-by: Westlake Porter Public Library Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes deleting saved release notes| |reports, and adds a | |confirmation message. | |Before this, attempting to | |delete a saved report (Edit | |> Delete) did not do | |anything. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171167|0 |1 is obsolete| | CC| |emmi.takkinen@koha-suomi.fi --- Comment #7 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 171715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171715&action=edit Bug 37328: Cannot delete report after using Update and Run SQL button Fixes the ability to delete a report from the report toolbar menu after running the report, including displaying the delete confirm modal. To test: 1) Login to staff client 2) Navigate to Reports -> Create from SQL 3) Create a short report (SELECT * FROM items), name it and SAVE it. 4) On the resulting "Edit SQL report' page, click 'Update and run SQL' 5) On the toolbar, click Edit -> Delete Nothing happens 6) Apply patch 7) Return to Reports -> Saved Reports and Edit the report you created. 8) On "Edit SQL report' page, click 'Update and run SQL' 9) On the toolbar, click Edit -> Delete 10) Confirm the delete modal. The report is now deleted. Sponsored-by: Westlake Porter Public Library Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 --- Comment #8 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- I think this still needs a minor fix on UI. After applying the patch the "Delete" option on dropdown menus isn't applied neatly to the element. It doesn't have enough margin around it and if I hover to the right side of the menu, I'm unable to select it. I have to move my mouse exactly above the text. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 --- Comment #9 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Emmi Takkinen from comment #8)
I think this still needs a minor fix on UI. After applying the patch the "Delete" option on dropdown menus isn't applied neatly to the element. It doesn't have enough margin around it and if I hover to the right side of the menu, I'm unable to select it. I have to move my mouse exactly above the text.
Forget this, it was a problem with my UI. I didn't remember to run yarn build on my other test environment. On current master this works as expected and UI looks clean. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171715|0 |1 is obsolete| | --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171838&action=edit Bug 37328: Cannot delete report after using Update and Run SQL button Fixes the ability to delete a report from the report toolbar menu after running the report, including displaying the delete confirm modal. To test: 1) Login to staff client 2) Navigate to Reports -> Create from SQL 3) Create a short report (SELECT * FROM items), name it and SAVE it. 4) On the resulting "Edit SQL report' page, click 'Update and run SQL' 5) On the toolbar, click Edit -> Delete Nothing happens 6) Apply patch 7) Return to Reports -> Saved Reports and Edit the report you created. 8) On "Edit SQL report' page, click 'Update and run SQL' 9) On the toolbar, click Edit -> Delete 10) Confirm the delete modal. The report is now deleted. Sponsored-by: Westlake Porter Public Library Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Doesn't apply clean to 24.05.x, please rebase if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot delete report after |Cannot delete report after |using Update and Run SQL |using 'Update and run SQ' |button |button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37328 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43935 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43935 [Bug 43935] data-confirmation-msg not translatable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org