[Bug 8726] New: Did you mean? plugin for broader/narrower/related terms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Priority: P5 - low Change sponsored?: --- Bug ID: 8726 Assignee: jcamins@cpbibliography.com Summary: Did you mean? plugin for broader/narrower/related terms Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins@cpbibliography.com Hardware: All Status: NEW Version: master Component: Searching Depends on: 8209, 8211 Product: Koha Building on the work in bug 8211, we propose adding a "Did you mean?" plugin which will suggest that users review broader, narrower, and related terms when they do subject searches, thus making the functionality usable to the general public. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12008&action=edit Bug 8726: ExplodedTerms suggestion plugin When working with hierarchical subject headings, it is sometimes helpful to do a search for all records with a specific subject, plus broader/narrower/related subjects. This patch adds a suggestion plugin for these "exploded" subject searches to Koha. Note that this patch depends on both bug 8211 AND bug 8209. To test (NOTE: this test plan covers both 8211 and 8726): 1) Make sure you have a bunch of hierarchical subjects. I created geographical subjects for "Arizona," "United States," and "Phoenix," and linked them together using 551s, and made sure I had a half dozen records linking to each (but not all to all three). 2) Do a search for su-br:Arizona (or choose "Subject and broader terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "United States" 3) Do a search for su-na:Arizona (or choose "Subject and narrower terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "Phoenix" 4) Do a search for su-rl:Arizona (or choose "Subject and related terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona," the records with the subject "United States," and the records with the subject "Phoenix" 5) Ensure that other searches still work (keyword, subject, ccl, whatever) 6) Use "Did you mean?" page in admin section to enable ExplodedTerms plugin 7) Do a keyword search on the OPAC, confirm that searching for exploded terms is suggested. 8) Do a subject search on the OPAC, confirm that searching for exploded terms is suggested. 9) Do a non-keyword, non-subject search on the OPAC, confirm that searching for exploded terms is NOT suggested. 10) Disable ExplodedTerms plugin and enable AuthorityFile plugin. 11) Do search on OPAC, confirm suggestions are made from authority file. 12) Sign off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12008|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12091&action=edit Bug 8726: ExplodedTerms suggestion plugin When working with hierarchical subject headings, it is sometimes helpful to do a search for all records with a specific subject, plus broader/narrower/related subjects. This patch adds a suggestion plugin for these "exploded" subject searches to Koha. Note that this patch depends on both bug 8211 AND bug 8209. To test (NOTE: this test plan covers both 8211 and 8726): 1) Make sure you have a bunch of hierarchical subjects. I created geographical subjects for "Arizona," "United States," and "Phoenix," and linked them together using 551s, and made sure I had a half dozen records linking to each (but not all to all three). 2) Do a search for su-br:Arizona (or choose "Subject and broader terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "United States" 3) Do a search for su-na:Arizona (or choose "Subject and narrower terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "Phoenix" 4) Do a search for su-rl:Arizona (or choose "Subject and related terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona," the records with the subject "United States," and the records with the subject "Phoenix" 5) Ensure that other searches still work (keyword, subject, ccl, whatever) 6) Use "Did you mean?" page in admin section to enable ExplodedTerms plugin 7) Do a keyword search on the OPAC, confirm that searching for exploded terms is suggested. 8) Do a subject search on the OPAC, confirm that searching for exploded terms is suggested. 9) Do a non-keyword, non-subject search on the OPAC, confirm that searching for exploded terms is NOT suggested. 10) Disable ExplodedTerms plugin and enable AuthorityFile plugin. 11) Do search on OPAC, confirm suggestions are made from authority file. 12) Sign off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12091|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12099&action=edit Bug 8726: ExplodedTerms suggestion plugin When working with hierarchical subject headings, it is sometimes helpful to do a search for all records with a specific subject, plus broader/narrower/related subjects. This patch adds a suggestion plugin for these "exploded" subject searches to Koha. Note that this patch depends on both bug 8211 AND bug 8209. To test (NOTE: this test plan covers both 8211 and 8726): 1) Make sure you have a bunch of hierarchical subjects. I created geographical subjects for "Arizona," "United States," and "Phoenix," and linked them together using 551s, and made sure I had a half dozen records linking to each (but not all to all three). 2) Do a search for su-br:Arizona (or choose "Subject and broader terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "United States" 3) Do a search for su-na:Arizona (or choose "Subject and narrower terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "Phoenix" 4) Do a search for su-rl:Arizona (or choose "Subject and related terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona," the records with the subject "United States," and the records with the subject "Phoenix" 5) Ensure that other searches still work (keyword, subject, ccl, whatever) 6) Use "Did you mean?" page in admin section to enable ExplodedTerms plugin 7) Do a keyword search on the OPAC, confirm that searching for exploded terms is suggested. 8) Do a subject search on the OPAC, confirm that searching for exploded terms is suggested. 9) Do a non-keyword, non-subject search on the OPAC, confirm that searching for exploded terms is NOT suggested. 10) Disable ExplodedTerms plugin and enable AuthorityFile plugin. 11) Do search on OPAC, confirm suggestions are made from authority file. 12) Sign off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12099|0 |1 is obsolete| | --- Comment #4 from wajasu <matted-34813@mypacks.net> --- Created attachment 12117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12117&action=edit SIGNED-OFF-Bug-8726-ExplodedTerms-suggestion-plugin. I applied: 0001-Bug-8744-Thesaurus-in-authorities-should-not-lock-fi.patch 0002-Bug-8649-Add-unit-test-for-C4-Search.patch 0003-bug-8649-make-sure-C4-Context-is-fully-mocked-up-bef.patch 0004-bug-8649-make-sure-we-can-exit-if-a-test-fails.patch 0005-bug-8649-create-a-temp-directory-for-Zebra-for-C4-Se.patch 0006-bug-8649-quiet-a-variable-use-warning.patch 0007-Bug-8211-Add-exploded-search-options.patch 0008-SIGNED-OFF-Bug-8209-Did-you-mean-from-authorities.patch 0009-Bug-8726-ExplodedTerms-suggestion-plugin.patch As mentioned, the work done in 8211 testing is duplicated here, so I leveraged the authority linked geographical names i had in my db. I applied the updatedatabase.pl I configured the syspref DidYouMean... to Suggest. AND on the main Administration web page, in the bottom right corner, there is a new link "Did you mean?" to configure the suggestion plugins, of which I checked (Exploded Terms, Auhtority file, Both) and did my searches. Suggestion links showed up in the results page, to offer alternate searches, (su-br, su-na, su-rl accordingly) and I got the same results as 8211 provided. The authority file link would show up using my search term as a link, and I had to pull down some biblios for "Smith, John" and use the authority search plugin to link the authority to the biblio item. wajasu Note: You can change the order of the suggestion plugins by using drag n drop of the control in the DidyYouMean configuration page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |matted-34813@mypacks.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Jared, The patch does not apply anymore, please could you provide a new patch ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12117|0 |1 is obsolete| | --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12186&action=edit Bug 8726: ExplodedTerms suggestion plugin When working with hierarchical subject headings, it is sometimes helpful to do a search for all records with a specific subject, plus broader/narrower/related subjects. This patch adds a suggestion plugin for these "exploded" subject searches to Koha. Note that this patch depends on both bug 8211 AND bug 8209. To test (NOTE: this test plan covers both 8211 and 8726): 1) Make sure you have a bunch of hierarchical subjects. I created geographical subjects for "Arizona," "United States," and "Phoenix," and linked them together using 551s, and made sure I had a half dozen records linking to each (but not all to all three). 2) Do a search for su-br:Arizona (or choose "Subject and broader terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "United States" 3) Do a search for su-na:Arizona (or choose "Subject and narrower terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "Phoenix" 4) Do a search for su-rl:Arizona (or choose "Subject and related terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona," the records with the subject "United States," and the records with the subject "Phoenix" 5) Ensure that other searches still work (keyword, subject, ccl, whatever) 6) Use "Did you mean?" page in admin section to enable ExplodedTerms plugin 7) Do a keyword search on the OPAC, confirm that searching for exploded terms is suggested. 8) Do a subject search on the OPAC, confirm that searching for exploded terms is suggested. 9) Do a non-keyword, non-subject search on the OPAC, confirm that searching for exploded terms is NOT suggested. 10) Disable ExplodedTerms plugin and enable AuthorityFile plugin. 11) Do search on OPAC, confirm suggestions are made from authority file. 12) Sign off Signed-off-by: wajasu <matted-34813@mypacks.net> Note that you will need to shift-refresh in order to get the new Javascript after the latest update to jQueryUI. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12214&action=edit overflow I get an overflow issue on wide screen (24"), see screenshot. Moreover when I click on the Intranet AuthorityFile *label*, the checkbox of Opac AuthorityFile become checked or unchecked :) (same for ExplodedTerms) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comments: * 3 perlcritics errors on Koha/SuggestionEngine/Base.pm: Expression form of "eval" at line 137, column 12. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 151, column 12. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 165, column 12. See page 161 of PBP. (Severity: 5) But I don't know how to fix them! * The 2 sysprefs don't appear in a yaml file. I understand why (there is a specific config page) but they appear in the "Local Use" tab :-/ It could be considered as an issue. * It would be great to provide 2 patchs. 1 for the feature and 1 for the jQuery changes. Like that if a problem appears on it, it will be easy to revert the commit. I don't find anything else :) It works great ! I Failed QA for the overflow issue (see previous comment). After that I will be happy to mark it as passed qa. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #8)
QA comments:
* 3 perlcritics errors on Koha/SuggestionEngine/Base.pm: Expression form of "eval" at line 137, column 12. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 151, column 12. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 165, column 12. See page 161 of PBP. (Severity: 5) But I don't know how to fix them!
I'll see if I can figure something out.
* The 2 sysprefs don't appear in a yaml file. I understand why (there is a specific config page) but they appear in the "Local Use" tab :-/ It could be considered as an issue.
I think this is a feature, because that way it is possible to work around not having javascript. My warning makes it very clear that setting those sysprefs directly is a bad idea, though.
* It would be great to provide 2 patchs. 1 for the feature and 1 for the jQuery changes. Like that if a problem appears on it, it will be easy to revert the commit.
I will break the existing patch into two, and do a follow-up for the overflow.
I don't find anything else :) It works great !
I Failed QA for the overflow issue (see previous comment). After that I will be happy to mark it as passed qa.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12186|0 |1 is obsolete| | --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12379&action=edit Bug 8726: ExplodedTerms suggestion plugin (functionality) When working with hierarchical subject headings, it is sometimes helpful to do a search for all records with a specific subject, plus broader/narrower/related subjects. This patch adds a suggestion plugin for these "exploded" subject searches to Koha. Note that this patch depends on both bug 8211 AND bug 8209. To test (NOTE: this test plan covers both 8211 and 8726): 1) Make sure you have a bunch of hierarchical subjects. I created geographical subjects for "Arizona," "United States," and "Phoenix," and linked them together using 551s, and made sure I had a half dozen records linking to each (but not all to all three). 2) Do a search for su-br:Arizona (or choose "Subject and broader terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "United States" 3) Do a search for su-na:Arizona (or choose "Subject and narrower terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "Phoenix" 4) Do a search for su-rl:Arizona (or choose "Subject and related terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona," the records with the subject "United States," and the records with the subject "Phoenix" 5) Ensure that other searches still work (keyword, subject, ccl, whatever) 6) Use "Did you mean?" page in admin section to enable ExplodedTerms plugin 7) Do a keyword search on the OPAC, confirm that searching for exploded terms is suggested. 8) Do a subject search on the OPAC, confirm that searching for exploded terms is suggested. 9) Do a non-keyword, non-subject search on the OPAC, confirm that searching for exploded terms is NOT suggested. 10) Disable ExplodedTerms plugin and enable AuthorityFile plugin. 11) Do search on OPAC, confirm suggestions are made from authority file. 12) Sign off Signed-off-by: wajasu <matted-34813@mypacks.net> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Split into two patches. This patch includes only the functionality. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12380&action=edit Bug 8726: ExplodedTerms suggestion plugin (jQueryUI) When working with hierarchical subject headings, it is sometimes helpful to do a search for all records with a specific subject, plus broader/narrower/related subjects. This patch adds a suggestion plugin for these "exploded" subject searches to Koha. Note that this patch depends on both bug 8211 AND bug 8209. To test (NOTE: this test plan covers both 8211 and 8726): 1) Make sure you have a bunch of hierarchical subjects. I created geographical subjects for "Arizona," "United States," and "Phoenix," and linked them together using 551s, and made sure I had a half dozen records linking to each (but not all to all three). 2) Do a search for su-br:Arizona (or choose "Subject and broader terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "United States" 3) Do a search for su-na:Arizona (or choose "Subject and narrower terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "Phoenix" 4) Do a search for su-rl:Arizona (or choose "Subject and related terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona," the records with the subject "United States," and the records with the subject "Phoenix" 5) Ensure that other searches still work (keyword, subject, ccl, whatever) 6) Use "Did you mean?" page in admin section to enable ExplodedTerms plugin 7) Do a keyword search on the OPAC, confirm that searching for exploded terms is suggested. 8) Do a subject search on the OPAC, confirm that searching for exploded terms is suggested. 9) Do a non-keyword, non-subject search on the OPAC, confirm that searching for exploded terms is NOT suggested. 10) Disable ExplodedTerms plugin and enable AuthorityFile plugin. 11) Do search on OPAC, confirm suggestions are made from authority file. 12) Sign off Signed-off-by: wajasu <matted-34813@mypacks.net> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Split into two patches. This patch includes only the jQueryUI upgrade -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12381&action=edit Bug 8726 follow-up: fix perlcritic issues -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12381|0 |1 is obsolete| | --- Comment #13 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12382&action=edit Bug 8726 follow-up: fix QA issues Fixes several perlcritic complaints, and some overflow in the configuration page. Also notes that Did You Mean is not yet enabled on the staff client. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12382|0 |1 is obsolete| | --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12383&action=edit Bug 8726 follow-up: fix QA issues Fixes several perlcritic complaints, and some overflow in the configuration page. Also notes that Did You Mean is not yet enabled on the staff client. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Apologies for the long delay (and the number of patches I just obsoleted). Fixing the perlcritic warnings was much harder than anticipated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12384&action=edit Bug 8726: Followup FIX save didyoumean syspref -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Unit tests failed now :-/ Marked as Failed QA. Can't use string ("AuthorityFile") as an ARRAY ref while "strict refs" in use at /home/koha/Koha/SuggestionEngine.pm line 91. Can't use string ("ExplodedTerms") as an ARRAY ref while "strict refs" in use at /home/koha/Koha/SuggestionEngine.pm line 91. Can't use string ("ABCD::EFGH::IJKL") as an ARRAY ref while "strict refs" in use at /home/koha/Koha/SuggestionEngine.pm line 91. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12383|0 |1 is obsolete| | --- Comment #18 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12390&action=edit Bug 8726 follow-up: fix QA issues Fixes several perlcritic complaints, and some overflow in the configuration page. Also notes that Did You Mean is not yet enabled on the staff client. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Sorry about the problematic last attempt at uploading. I missed a patch when squashing. It is now included. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12384|0 |1 is obsolete| | --- Comment #19 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12391&action=edit Bug 8726: Followup FIX save didyoumean syspref Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Now all seem good to me. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #21 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 12482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12482&action=edit OPAC screenshot Question: I'm testing this feature, and see the following results on my screen. Is it what I should expect ? ( Note i'm using the cssr theme ) QA comment: you remove the DidYouMeanFromAuthorities from the sysprefs.sql, shouldn't we remove it during updatedatabase also ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #22 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Comment on attachment 12482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12482 OPAC screenshot It looks like the CSS is missing for the opac.css in the ccsr theme. I will do a follow-up. Other than that, yes, that is correct. The DidYouMeanFromAuthorities should probably be taken out of updatedatabase.pl as well. Shall I let you do that? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #23 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12483&action=edit Bug 8726: add CSS to CCSR theme -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_10 --- Comment #24 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Bug 8726 depends on bug 8209, which changed state. Bug 8209 Summary: "Did you mean?" suggestions based on authorities http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #25 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This feature is available in Master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Bug 8726 depends on bug 8211, which changed state. Bug 8211 Summary: Add "subject (broader)," "subject (narrower)," and "subject (related)" options for search http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8211 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org