https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27654 --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 116500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116500&action=edit Bug 27654: Sort module.keys hash when render columns_settings.tt On the "Administration -> Table settings" page, the order of "tables related to pages" sections is different with each page refresh. Cause of that is that Perl gives random order for hash keys where those elements are stored on template render. To avoid that we add a "sort" method where getting keys similarly how it was done previously to display tables always in the same order. To reproduce: 1) Head over to /cgi-bin/koha/admin/columns_settings.pl 2) Open any collapsed module settings, for example "Acquisition tables". Check the order of pages. 3) Reload the page. Check the order of the same elements again. They always come in random order, it's easily distinguishable. 4) Apply the patch. 5) Repeat steps 1-3 again and ensure that the order of pages stays the same no matter how many times you reload the page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27654 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |stalkernoid@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27654 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116500|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 116532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116532&action=edit Bug 27654: Sort module.keys hash when render columns_settings.tt On the "Administration -> Table settings" page, the order of "tables related to pages" sections is different with each page refresh. Cause of that is that Perl gives random order for hash keys where those elements are stored on template render. To avoid that we add a "sort" method where getting keys similarly how it was done previously to display tables always in the same order. To reproduce: 1) Head over to /cgi-bin/koha/admin/columns_settings.pl 2) Open any collapsed module settings, for example "Acquisition tables". Check the order of pages. 3) Reload the page. Check the order of the same elements again. They always come in random order, it's easily distinguishable. 4) Apply the patch. 5) Repeat steps 1-3 again and ensure that the order of pages stays the same no matter how many times you reload the page. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27654 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27654 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |joonas.kylmala@helsinki.fi |y.org | CC| |joonas.kylmala@helsinki.fi -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27654 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27654 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.03 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27654 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | CC| |andrew@bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes.