[Bug 19313] New: Typo in UNIMARC field 130 plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313 Bug ID: 19313 Summary: Typo in UNIMARC field 130 plugin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: dubyk@ukr.net QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Small typo: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet... https://books.google.com.ua/books?id=I9rPDkF0_ZQC&pg=PA195&lpg=PA195&dq=unimarc+130+mixed+emulsion&source=bl&ots=eE7pUi4Arn&sig=bN3mM9Br4QasDN6bnZ8Ph2C_EyI&hl=uk&sa=X&ved=0ahUKEwjIveiup6TWAhUzSJoKHbq7C-sQ6AEILjAB#v=onepage&q=unimarc%20130%20mixed%20emulsion&f=false Exists: 245 [% END %] 246 [% IF ( f7d ) %] 247 <option value="d" selected="selected">unknown</option> 248 [% ELSE %] 249 <option value="d">unknown</option> 250 [% END %] 251 [% IF ( f7u ) %] 252 <option value="u" selected="selected">mixed emulsion</option> 253 [% ELSE %] 254 <option value="u">mixed emulsion</option> 255 [% END %] Must be: 245 [% END %] 246 [% IF ( f7u ) %] 247 <option value="u" selected="selected">unknown</option> 248 [% ELSE %] 249 <option value="u">unknown</option> 250 [% END %] 251 [% IF ( f7v ) %] 252 <option value="v" selected="selected">mixed emulsion</option> 253 [% ELSE %] 254 <option value="v">mixed emulsion</option> 255 [% END %] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |gveranis@dataly.gr |ity.org | Status|NEW |ASSIGNED CC| |gveranis@dataly.gr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313 --- Comment #1 from George Veranis <gveranis@dataly.gr> --- Created attachment 103471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103471&action=edit Bug 19313: Fix typo in template This patch fixes a simple typo Test plan: 1) Go to Administration -> MARC bibliographic framework 2) Select a framework and add plugin unimarc_field_130.pl to 130 field 3) Open cataloguing screen 4) Go to 130 field and check if for subfield a shows value for 'unknown' select it and close the window, check on value on 130$a at position 8 to have the value 'd'. 5) Repeat step 4 and select the value 'mixed emulsion' close the plugin window and check at position 8 to have the value 'u' 6) Apply the patch 7) Go to field 130, open the plugin window and select value 'unknown' close the window and check at position 8 to have the value 'u' 8) Go to field 130, open the plugin window and select value 'mixed emulsion', close the window and check at position 8 to have the value 'v' Mentored-by: Andreas Roussos -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103471|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103882&action=edit Bug 19313: Fix typo in in unimarc_field_130.pl value builder This patch fixes a simple typo Test plan: 1) Go to Administration -> MARC bibliographic framework 2) Select a framework and add plugin unimarc_field_130.pl to 130 field 3) Open cataloguing screen 4) Go to 130 field and check if for subfield a shows value for 'unknown' select it and close the window, check on value on 130$a at position 8 to have the value 'd'. 5) Repeat step 4 and select the value 'mixed emulsion' close the plugin window and check at position 8 to have the value 'u' 6) Apply the patch 7) Go to field 130, open the plugin window and select value 'unknown' close the window and check at position 8 to have the value 'u' 8) Go to field 130, open the plugin window and select value 'mixed emulsion', close the window and check at position 8 to have the value 'v' Mentored-by: Andreas Roussos Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/b_130_up... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've added a link to a UNIMARC documentation I consulted and rephrased the subject of your commit message to be a bit more descriptive :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Awesome work, great to see some mentoring going on.. that's my favourite git trailer :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #6 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org