[Bug 6894] New: Order from suggestion defaulting to wrong currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6894 Bug #: 6894 Summary: Order from suggestion defaulting to wrong currency Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org To reproduce: 1) Create vendor, check currency setting to be not the first one in your list of currencies 2) Create suggestion 3) Create basket 4) Order from suggestoin In 4) currency selected should be the first in your currency list, not the active currency or currency selected for the vendor. For other ordering options this works correctly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6894 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-25 15:44:51 UTC --- Created attachment 6051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6051 Bug 6894: Order from suggestion defaulting to wrong currency This problem turned out to be a bit different, than I initally thought. This patch fixes the currency selections for new orders created in staff. Before this patch, the first currency in the list was selected instead of the active currency. So you needed to change it explicitly. After patch it should work like this: 1) Suggestion created in OPAC - currency defaults to NULL in database 2) Editing a suggestion created in OPAC will default to active currency. 3) Creating a new suggestion in staff will default to active currency. 4) When ordering, the currency will default to the vendor currency, if no currency is set in the suggestion. (still happens, when suggestions are accepted in batch from the list. I hope this is right - comments and testing appreciated. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6894 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff AssignedTo|henridamien@koha-fr.org |katrin.fischer@bsz-bw.de -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6894 --- Comment #2 from Liz Rea <wizzyrea@gmail.com> 2011-10-28 17:09:07 UTC --- Created attachment 6097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6097 Bug 6894: Order from suggestion defaulting to wrong currency This problem turned out to be a bit different, than I initally thought. This patch fixes the currency selections for new orders created in staff. Before this patch, the first currency in the list was selected instead of the active currency. So you needed to change it explicitly. After patch it should work like this: 1) Suggestion created in OPAC - currency defaults to NULL in database 2) Editing a suggestion created in OPAC will default to active currency. 3) Creating a new suggestion in staff will default to active currency. 4) When ordering, the currency will default to the vendor currency, if no currency is set in the suggestion. (still happens, when suggestions are accepted in batch from the list. I hope this is right - comments and testing appreciated. Signed-off-by: Liz Rea <lrea@nekls.org> Verified that in the above places, active currency was displayed or selected. Tested both suggestions entered from the OPAC and from the intranet. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6894 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6894 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6051|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6894 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6894 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch Status|Signed Off |Passed QA Summary|Order from suggestion |Default currency on |defaulting to wrong |Acquisitions suggestion |currency |form --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-23 14:01:10 UTC --- QA Comment This bugreport handles the currency on the suggestion form only; the comment made me look to order from suggestion too. But that part is not touched by the patch. The currency correctly defaults to active currency if no currency was passed via CGI object. ($$suggestion_ref takes its values from input->Vars.) Code looks good. Marking it as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6894 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-24 14:59:37 UTC --- mmm... can't reproduce the step 2 (2) Editing a suggestion created in OPAC will default to active currency.) Here is my database content: portable kohacommunity>select * from suggestions WHERE suggestionid=2\G *************************** 1. row *************************** suggestionid: 2 suggestedby: 1 suggesteddate: 2011-10-26 managedby: 1 manageddate: 2011-11-24 acceptedby: 1 accepteddate: 2011-10-26 rejectedby: NULL rejecteddate: NULL STATUS: ASKED note: author: title: suggestion 6880 copyrightdate: 0 publishercode: date: 2011-11-24 15:57:27 volumedesc: NULL publicationyear: 0 place: isbn: mailoverseeing: 0 biblionumber: NULL reason: blablabla budgetid: NULL branchcode: ANNEXE collectiontitle: itemtype: quantity: NULL currency: NULL <<<<<<<<<<<<<<<<<<<<<<<<<<< price: NULL total: NULL 1 row in set (0.00 sec) portable kohacommunity>SELECT * FROM currency; +----------+--------+---------------------+---------+--------+ | currency | symbol | timestamp | rate | active | +----------+--------+---------------------+---------+--------+ | AA | AA | 2011-11-16 17:45:33 | 2.00000 | 0 | | EURO | � | 2011-08-03 13:36:12 | 1.00000 | 1 | | YEN | Y | 2011-10-20 11:09:14 | 0.06500 | 0 | +----------+--------+---------------------+---------+--------+ If I try to modify suggestion 2, the currency is defaulted to AA (should be EURO) Otherwise, works fine. Katrin or someone else, an idea ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6894 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-27 15:31:01 UTC --- Ignore the Description. At first I thought this problem was happening on the order form and figured out later, that my wrong currencies happened during accpeting the suggestions. I retested 2) - CAD is the first currency in my currency table - EUR is the second currency, also the active currency - I created a suggestion in OPAC - I opened that suggestion in the suggestions module - the pull down for currencies showed EUR as preselected currency Comment on 4) - create suggeston in OPAC - accept suggestion from the list(!) only changing the status to accepted. Currency in the database will still be NULL after that. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6894 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6097|0 |1 is obsolete| | --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-11-27 15:45:29 UTC --- Created attachment 6435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6435 Bug 6894: Order from suggestion defaulting to wrong currency This problem turned out to be a bit different, than I initally thought. This patch fixes the currency selections for new orders created in staff. Before this patch, the first currency in the list was selected instead of the active currency. So you needed to change it explicitly. After patch it should work like this: 1) Suggestion created in OPAC - currency defaults to NULL in database 2) Editing a suggestion created in OPAC will default to active currency. 3) Creating a new suggestion in staff will default to active currency. 4) When ordering, the currency will default to the vendor currency, if no currency is set in the suggestion. (still happens, when suggestions are accepted in batch from the list. I hope this is right - comments and testing appreciated. Signed-off-by: Liz Rea <lrea@nekls.org> Verified that in the above places, active currency was displayed or selected. Tested both suggestions entered from the OPAC and from the intranet. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Verified the existence of the bug, and that the fix works as advertised. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6894 --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-11-27 15:47:42 UTC --- Paul, I can confirm the bug, and the patch works to fix it for me, as well. Regards, Jared -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6894 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-28 11:21:20 UTC --- patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6894 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-01 06:40:53 UTC --- Works on current HEAD. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org