[Bug 24206] New: Change URLs for default options in OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Bug ID: 24206 Summary: Change URLs for default options in OPACSearchForTitleIn Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org URLs are not correct for the default values in the OPACSearchForTitleIn system peference: - Worldcat: now https - BookFinder: now https - OpenLibrary: URL search pattern changed These still work as the sites redirect to the https version, and the new URL pattern for the OpenLibrary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> ---
- Worldcat: now https - BookFinder: now https
I know we can update the installation SQL, but I'm assuming there's not a good way to update existing installations since the library could have customized this preference with their own options?
- OpenLibrary: URL search pattern changed
The current pattern looks correct to me: https://openlibrary.org/search/?author=({AUTHOR})&title=({TITLE}) ...translates to: https://openlibrary.org/search?author=(Heinlein%2C%20Robert%20A.)&title=(Stranger%20in%20a%20strange%20land) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 --- Comment #2 from David Nind <david@davidnind.com> --- There is no / between search and the question mark for the query. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96569&action=edit Bug 24206: Update URLs for default options in OPACSearchForTitleIn - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify changes to the installer files are correct - Bonus: run the web installer for en, de-DE and nb-NO and verfiy the content of OPACSearchForTitleIn is correct -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96570&action=edit Bug 24206: Update content of OpacSearchForTitleIn for existing installations This includes a database update for existing installations. Using the REPLACE function it makes the same changes to the URLs as the previous patch did for new installations: - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify the current content of your preference OpacSearchForTitleIn (without changes from first patch!) - Run the database update - Verify everything still works, but changes have been made -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial CC| |katrin.fischer@bsz-bw.de Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 --- Comment #5 from David Nind <david@davidnind.com> --- Thanks Katrin! This all works as expected. One minor point (and I'm not sure it needs updating), there is an extra space in installer/data/mysql/sysprefs.sql (line 426) between the a and href for the worldcat entry. This shows in the diff and when you click on 'Click to edit' in the staff interface. It doesn't affect it working though, and maybe I'm being too pedantic! Happy to sign-off either way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96569|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96673&action=edit Bug 24206: Update URLs for default options in OPACSearchForTitleIn - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify changes to the installer files are correct - Bonus: run the web installer for en, de-DE and nb-NO and verfiy the content of OPACSearchForTitleIn is correct -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96570|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96674&action=edit Bug 24206: Update content of OpacSearchForTitleIn for existing installations This includes a database update for existing installations. Using the REPLACE function it makes the same changes to the URLs as the previous patch did for new installations: - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify the current content of your preference OpacSearchForTitleIn (without changes from first patch!) - Run the database update - Verify everything still works, but changes have been made -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96674|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96675&action=edit Bug 24206: Update content of OpacSearchForTitleIn for existing installations This includes a database update for existing installations. Using the REPLACE function it makes the same changes to the URLs as the previous patch did for new installations: - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify the current content of your preference OpacSearchForTitleIn (without changes from first patch!) - Run the database update - Verify everything still works, but changes have been made -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Nind from comment #5)
Thanks Katrin!
This all works as expected.
One minor point (and I'm not sure it needs updating), there is an extra space in installer/data/mysql/sysprefs.sql (line 426) between the a and href for the worldcat entry. This shows in the diff and when you click on 'Click to edit' in the staff interface.
It doesn't affect it working though, and maybe I'm being too pedantic!
Happy to sign-off either way.
Hi David, the extra space was there before, but I will remove it now in my updated patch. I feel for you - I like things nice and clean as well :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 --- Comment #10 from David Nind <david@davidnind.com> --- Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96673|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 96768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96768&action=edit Bug 24206: Update URLs for default options in OPACSearchForTitleIn - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify changes to the installer files are correct - Bonus: run the web installer for en, de-DE and nb-NO and verfiy the content of OPACSearchForTitleIn is correct Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96675|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 96769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96769&action=edit Bug 24206: Update content of OpacSearchForTitleIn for existing installations This includes a database update for existing installations. Using the REPLACE function it makes the same changes to the URLs as the previous patch did for new installations: - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify the current content of your preference OpacSearchForTitleIn (without changes from first patch!) - Run the database update - Verify everything still works, but changes have been made Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96768|0 |1 is obsolete| | Attachment #96769|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97186&action=edit Bug 24206: Update URLs for default options in OPACSearchForTitleIn - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify changes to the installer files are correct - Bonus: run the web installer for en, de-DE and nb-NO and verfiy the content of OPACSearchForTitleIn is correct Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97187&action=edit Bug 24206: Update content of OpacSearchForTitleIn for existing installations This includes a database update for existing installations. Using the REPLACE function it makes the same changes to the URLs as the previous patch did for new installations: - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify the current content of your preference OpacSearchForTitleIn (without changes from first patch!) - Run the database update - Verify everything still works, but changes have been made Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Updates URLs for the release notes| |default entries (sites now | |use https, and an update to | |the Open Library's URL | |search pattern). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy |additional_work_needed --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Needs a small follow-up, bug number in updatedatabase is missing: Upgrade to 19.12.00.008 done (Bug XXXXX - Update OpacSearchForTitleIn system preference) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97264&action=edit Bug 24206: Add correct bug reference to update message in udpatedatabase Fixes a small oversight by changing XXXX to 24206. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97265&action=edit k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97265|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 97265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97265 k Wrong bug number! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Already pushed a followup :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #22 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #23 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #24 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Patches will not be backported to 18.11.x series as no one should be installing 18.11.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org