[Bug 42968] New: 505 MARC field label is missing in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42968 Bug ID: 42968 Summary: 505 MARC field label is missing in the staff interface Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: Laura.escamilla@bywatersolutions.com Reporter: Laura.escamilla@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Target Milestone: --- The staff interface displays the contents of the MARC 505 field but does not display the "Contents:" label that appears in the OPAC. This results in an inconsistency between the OPAC and staff interface and makes it less clear what the displayed information represents. To recreate: 1.Create or locate a bibliographic record with data in the MARC 505 field. 2.View the record in the OPAC. 3.Note that the 505 field is displayed with the "Contents:" label. 4.View the same record in the staff interface. 5.Notice that the 505 field is displayed without the "Contents:" label. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42968 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|505 MARC field label is |Show Contents label for 505 |missing in the staff |fields with blank indicator |interface | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42968 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- UPDATED DESCRIPTION: The staff interface and OPAC display a label for MARC 505 formatted contents notes based on the first indicator: - 0 = Contents: - 1 = Incomplete contents: - 2 = Partial contents: However, when the 505 first indicator is blank, no label is displayed before the contents note. This makes the contents note less clear, especially for records where libraries have entered 505 data without indicators. To recreate: 1. Create or locate a bibliographic record with a MARC 505 field. 2. Leave the first indicator blank. 3. Add text to the 505 field. 4. View the record detail page. 5. Notice that the 505 contents display without a label. Expected behavior: When the 505 first indicator is blank, Koha should display a fallback "Contents:" label. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42968 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42968 --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 201387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201387&action=edit Bug 42968: Add fallback label for 505 contents notes To test: 1. Create or locate a bibliographic record with a MARC 505 field. 2. Leave the first indicator blank. 3. Add text to the 505 field. 4. View the record detail page. 5. Notice that the 505 contents display without a label. 6. Apply the patch 7. Refresh the record detail page. Notice that the 505 content displays a label now. 8. Sign off and have a lovely day! :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42968 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42968 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201387|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42968 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 201405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201405&action=edit Bug 42968: Add fallback label for 505 contents notes To test: 1. Create or locate a bibliographic record with a MARC 505 field. 2. Leave the first indicator blank. 3. Add text to the 505 field. 4. View the record detail page. 5. Notice that the 505 contents display without a label. 6. Apply the patch 7. Refresh the record detail page. Notice that the 505 content displays a label now. 8. Sign off and have a lovely day! :D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42968 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |The staff interface and release notes| |OPAC display a label for | |MARC21 505 formatted | |contents notes based on the | |first indicator: | | | |- 0 = Contents: | |- 1 = Incomplete contents: | |- 2 = Partial contents: | | | |However, when the 505 first | |indicator is blank, no | |label was displayed before | |the contents note. This | |makes the contents note | |less clear, especially for | |records where libraries | |have entered 505 data | |without indicators. | | | |Now, when the 505 first | |indicator is blank, Koha | |shows a fallback | |"Contents:" label. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42968 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42968 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|victor@tuxayo.net |andrew@bywatersolutions.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42968 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201405|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42968 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 204505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204505&action=edit Bug 42968: Add fallback label for 505 contents notes To test: 1. Create or locate a bibliographic record with a MARC 505 field. 2. Leave the first indicator blank. 3. Add text to the 505 field. 4. View the record detail page. 5. Notice that the 505 contents display without a label. 6. Apply the patch 7. Refresh the record detail page. Notice that the 505 content displays a label now. 8. Sign off and have a lovely day! :D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42968 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |pedro.amorim@openfifth.co.u | |k --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi guys, there appears to be a pre-existing bug here, the label xsl:choose tests @ind1 against the whole record instead of the current field in the for-each, so a record with multiple 505s and different indicators gets one label applied to all of them. This patch's new xsl:otherwise branch is added into that same xsl:choose, inheriting that same existing bug. 1) Log into the staff interface at http://localhost:8081/cgi-bin/koha/mainpage.pl 2) Go to 'Cataloguing' and create or edit a bib record 3) Add two 505 fields: - First 505: leave first indicator blank, subfield 'a' = "General contents note" - Second 505: set first indicator to '2' (Partial contents), subfield 'a' = "Partial contents note" 4) Save the record 5) View the record's detail page (/cgi-bin/koha/catalogue/detail.pl?biblionumber=X) 6) Confirm both 505 blocks are labeled 'Partial contents:' — the blank-indicator field should show 'Contents:' but instead inherits the label from the second field, because the label is picked once for the whole record instead of per-field. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org