[Bug 33802] New: On OPAC authority detail page, usage count in erroneous
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 Bug ID: 33802 Summary: On OPAC authority detail page, usage count in erroneous Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: frederic@tamil.fr QA Contact: testopia@bugs.koha-community.org On OPAC opac-authoritiesdetail.pl page, usage count is wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 --- Comment #1 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 151553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151553&action=edit Bug 33802: On OPAC authority detail page, usage count in erroneous If QueryAutoTruncate is enabled, the biblio usage count of an authority displayed on OPAC may be wrong. This is due to the fact that the authid search being automatically truncated, a search for biblios using authority 22 will retrieved also biblios using authorities 222, 22*. TO TEST: 1. On a Koha with authorities, enable QueryAutoTruncate. 2. Go on opac-authoritiesdetail.pl page for an authority with the lowest possible authid. Let say 1. 3. Confirm that you have a large biblios usage count, and that by clicking on the link to see linked biblios, you get far less biblios than expected. 4. Apply the patch. Repeat 2-3. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I couldn't replicate the issue when using Zebra, but can when using Elasticsearch. So is this Elasticsearch specific? After the patch is applied, it fixes things for Elasticsearch, and I noticed no changes when using Zebra. Testing notes using koha-testing-docker and the sample data: 1. I'm assuming by enable QueryAutoTruncate, this means to set it to 'automatically' (the default in KTD). 2. I can't replicate the issue using Zebra: for authid=1 there are no results (as expected). 3. However, I can replicate the issue when using Elasticsearch: for authid=1 the details page shows 152 usages, clicking on the link shows no results; using authid=11 I get 12 usages, but only one actual result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- Yes, it's ES specific. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the usage count release notes| |shown on authority details | |pages in the OPAC (and the | |staff interface) - "Number | |of records used in: X". | |Previously, where | |QueryAutoTruncate is | |enabled, the usage count | |for an authority may have | |been wrong as the search | |was automatically truncated | |(for example, a search for | |records using authority 22 | |also retrieved using | |authorities 222, 22*, and | |so on). --- Comment #4 from David Nind <david@davidnind.com> --- (In reply to Frédéric Demians from comment #3)
Yes, it's ES specific.
Thanks! Sign off coming for this patch that fixes the OPAC (and staff interface). I also noticed that this is occurring on the staff interface as well. This bug fixes the display for the staff interface authority details page - "Used in X records". But it doesn't fix the actual results. For example, authid=3 shows used in 1 record, but you get 44 records in the actual results. I vaguely remember testing a similar bug a while ago, but can't find it now... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the usage count |This fixes the usage count release notes|shown on authority details |shown on authority details |pages in the OPAC (and the |pages in the OPAC (and the |staff interface) - "Number |staff interface) - "Number |of records used in: X". |of records used in: X". |Previously, where |Note: This only occurs when |QueryAutoTruncate is |using the Elasticsearch or |enabled, the usage count |Open Search search engine. |for an authority may have |Previously, where |been wrong as the search |QueryAutoTruncate is |was automatically truncated |enabled, the usage count |(for example, a search for |for an authority may have |records using authority 22 |been wrong as the search |also retrieved using |was automatically truncated |authorities 222, 22*, and |(for example, a search for |so on). |records using authority 22 | |also retrieved using | |authorities 222, 22*, and | |so on). Summary|On OPAC authority detail |On OPAC authority detail |page, usage count in |page, usage count in wrong |erroneous |(when using Elasticsearch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151553|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 151675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151675&action=edit Bug 33802: On OPAC authority detail page, usage count in erroneous If QueryAutoTruncate is enabled, the biblio usage count of an authority displayed on OPAC may be wrong. This is due to the fact that the authid search being automatically truncated, a search for biblios using authority 22 will retrieved also biblios using authorities 222, 22*. TO TEST: 1. On a Koha with authorities, enable QueryAutoTruncate. 2. Go on opac-authoritiesdetail.pl page for an authority with the lowest possible authid. Let say 1. 3. Confirm that you have a large biblios usage count, and that by clicking on the link to see linked biblios, you get far less biblios than expected. 4. Apply the patch. Repeat 2-3. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32707 CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24143 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Like said in Bug 24143 search on 'an' should never use auto-truncate. This is a more general issue. I bet this change needs a UT. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We made this change in other spots, so no issue with that, but a unit test/regression test indeed would be nice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Obsolete since Bug 32707 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 --- Comment #9 from David Nind <david@davidnind.com> --- (In reply to Fridolin Somers from comment #8)
Obsolete since Bug 32707 ?
My testing shows that this is no longer an issue in main (for the OPAC and staff interface). However, one I tested was C (Computer program language) (Topical Term) - authid=2 (<opac-url>:8080/cgi-bin/koha/opac-authoritiesdetail.pl?authid=2). It shows as not used any records. However, it is used in record 4 (The C programming language / Brian W. Kernighan, Dennis M. Ritchie.). Probably this is another issue or related to the record details. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #10 from David Cook <dcook@prosentient.com.au> --- Certainly an interesting one I may come back to at some point... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33802 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org