[Bug 35823] New: When uploading a MARC file to a basket it is showing inactive funds without them being selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Bug ID: 35823 Summary: When uploading a MARC file to a basket it is showing inactive funds without them being selected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: Laura.escamilla@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1) Create two budgets -- let's say 'Active Budget 2024' and 'Inactive Budget 2024' 2) Create 'Fund1' in Active Budget 2024 and 'Fund2' in Inactive Budget 2024. 3) Mark Inactive Budget 2024 as inactive. 4) Create a vendor and new basket if not already available. Add to the basket using either a new MARC file or a staged MARC file. 5) When adding the items to the order click on "Fund" and notice that 'Fund2' is appearing in the dropdown despite the "Show inactive funds" box not being ticked. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35824 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35824 [Bug 35824] Statistic 1 and Statistic 2 dropdowns are not showing when uploading to a basket using MARC files -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Alexandre <alexandre.noel@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35254 CC| |alexandre.noel@inlibro.com, | |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35254 [Bug 35254] Adding files to basket from a staged file uses wrong inputs for order information when not all records are selected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Alexandre <alexandre.noel@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 --- Comment #1 from Alexandre <alexandre.noel@inlibro.com> --- Created attachment 167865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167865&action=edit Bug 35823: When uploading a MARC file to a basket it is showing inactive funds without the show checkbox button selected Prerequisites: - Have at least 2 budgets with funds 1. Add several budgets ("Acquisitions" > "Budget") with funds ("Actions" > "Add fund") 2. Keep one budget active (check the "Make Budget active" box in the budget edit page) - Have at least one file of records imported into Koha ("Cataloging" > "Stage records for import" > "Upload a file") To test: 1. Go to Acquisitions page. 2. Create a vendor and new basket if not already available. 3. In your vendor, "Add to the basket" > "From a staged MARC file". 4. Click "Add orders" of one of the MARC file. 5. Check the checkbox in the "Select for import" tab. 6. In the dropdown menu of the "Fund" field, verify the budget names. --> Ensure Koha displays all inactive budgets even if the "Show inactive funds" checkbox is not checked. 7. Apply patch, and refresh the page (crtl + F5) 8. Verify the budgets in the "Fund" dropdown menu and test it with the "Show inactive funds" checked and uncheked" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Thibault Keromnès <thibault.keromnes@univ-paris8.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibault.keromnes@univ-pari | |s8.fr Status|Needs Signoff |Signed Off --- Comment #2 from Thibault Keromnès <thibault.keromnes@univ-paris8.fr> --- Tried on a sandbox, it worked :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167865|0 |1 is obsolete| | --- Comment #3 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 167945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167945&action=edit Bug 35823: When uploading a MARC file to a basket it is showing inactive funds without the show checkbox button selected Prerequisites: - Have at least 2 budgets with funds 1. Add several budgets ("Acquisitions" > "Budget") with funds ("Actions" > "Add fund") 2. Keep one budget active (check the "Make Budget active" box in the budget edit page) - Have at least one file of records imported into Koha ("Cataloging" > "Stage records for import" > "Upload a file") To test: 1. Go to Acquisitions page. 2. Create a vendor and new basket if not already available. 3. In your vendor, "Add to the basket" > "From a staged MARC file". 4. Click "Add orders" of one of the MARC file. 5. Check the checkbox in the "Select for import" tab. 6. In the dropdown menu of the "Fund" field, verify the budget names. --> Ensure Koha displays all inactive budgets even if the "Show inactive funds" checkbox is not checked. 7. Apply patch, and refresh the page (crtl + F5) 8. Verify the budgets in the "Fund" dropdown menu and test it with the "Show inactive funds" checked and uncheked" Signed-off-by: Thibault Keromnès <thibault.keromnes@univ-paris8.fr> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |alexandre.noel@inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- The patch here adds a new class, and adds it to the selectors - the problem stems from bug 35254 which updated the select name, but not the jQuery selectors. This patch works, but either: 1 - We should remove the old 'name="budget_id"' selector as it is not working and just use the new one 2 - Don't add a new class, but update the selector to match the current name: 'name^="budget_id_"' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 --- Comment #5 from Alexandre Noel <alexandre.noel@inlibro.com> --- (In reply to Nick Clemens (kidclamp) from comment #4)
The patch here adds a new class, and adds it to the selectors - the problem stems from bug 35254 which updated the select name, but not the jQuery selectors.
This patch works, but either: 1 - We should remove the old 'name="budget_id"' selector as it is not working and just use the new one 2 - Don't add a new class, but update the selector to match the current name: 'name^="budget_id_"'
You're right, it will be cleaner that way. I'm making the changes now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Alexandre Noel <alexandre.noel@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Alexandre Noel <alexandre.noel@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167945|0 |1 is obsolete| | --- Comment #6 from Alexandre Noel <alexandre.noel@inlibro.com> --- Created attachment 168145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168145&action=edit Bug 35823: When uploading a MARC file to a basket it is showing inactive funds without the show checkbox button selected Prerequisites: - Have at least 2 budgets with funds 1. Add several budgets ("Acquisitions" > "Budget") with funds ("Actions" > "Add fund") 2. Keep one budget active (check the "Make Budget active" box in the budget edit page) - Have at least one file of records imported into Koha ("Cataloging" > "Stage records for import" > "Upload a file") To test: 1. Go to Acquisitions page. 2. Create a vendor and new basket if not already available. 3. In your vendor, "Add to the basket" > "From a staged MARC file". 4. Click "Add orders" of one of the MARC file. 5. Check the checkbox in the "Select for import" tab. 6. In the dropdown menu of the "Fund" field, verify the budget names. --> Ensure Koha displays all inactive budgets even if the "Show inactive funds" checkbox is not checked. 7. Apply patch, and refresh the page (crtl + F5) 8. Verify the budgets in the "Fund" dropdown menu and test it with the "Show inactive funds" checked and uncheked" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168145|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 168304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168304&action=edit Bug 35823: When uploading a MARC file to a basket it is showing inactive funds without the show checkbox button selected Prerequisites: - Have at least 2 budgets with funds 1. Add several budgets ("Acquisitions" > "Budget") with funds ("Actions" > "Add fund") 2. Keep one budget active (check the "Make Budget active" box in the budget edit page) - Have at least one file of records imported into Koha ("Cataloging" > "Stage records for import" > "Upload a file") To test: 1. Go to Acquisitions page. 2. Create a vendor and new basket if not already available. 3. In your vendor, "Add to the basket" > "From a staged MARC file". 4. Click "Add orders" of one of the MARC file. 5. Check the checkbox in the "Select for import" tab. 6. In the dropdown menu of the "Fund" field, verify the budget names. --> Ensure Koha displays all inactive budgets even if the "Show inactive funds" checkbox is not checked. 7. Apply patch, and refresh the page (crtl + F5) 8. Verify the budgets in the "Fund" dropdown menu and test it with the "Show inactive funds" checked and uncheked" Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168304|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168324&action=edit Bug 35823: When uploading a MARC file to a basket it is showing inactive funds without the show checkbox button selected Prerequisites: - Have at least 2 budgets with funds 1. Add several budgets ("Acquisitions" > "Budget") with funds ("Actions" > "Add fund") 2. Keep one budget active (check the "Make Budget active" box in the budget edit page) - Have at least one file of records imported into Koha ("Cataloging" > "Stage records for import" > "Upload a file") To test: 1. Go to Acquisitions page. 2. Create a vendor and new basket if not already available. 3. In your vendor, "Add to the basket" > "From a staged MARC file". 4. Click "Add orders" of one of the MARC file. 5. Check the checkbox in the "Select for import" tab. 6. In the dropdown menu of the "Fund" field, verify the budget names. --> Ensure Koha displays all inactive budgets even if the "Show inactive funds" checkbox is not checked. 7. Apply patch, and refresh the page (crtl + F5) 8. Verify the budgets in the "Fund" dropdown menu and test it with the "Show inactive funds" checked and uncheked" Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Simple clean fix, thanks everyone. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35823 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #14 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- This fixes a bug, nothing to change in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org