[Bug 21536] New: t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 Bug ID: 21536 Summary: t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mirko@abunchofthings.net QA Contact: testopia@bugs.koha-community.org t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled if WebService::ILS is not available. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 --- Comment #1 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 80353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80353&action=edit Bug 21536: t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled if WebService::ILS is not available. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Assignee|chris@bigballofwax.co.nz |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17602 Depends on| |17602 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 [Bug 17602] Integrate support for RecordedBooks (formerly OneClickDigital) API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- Test plan: - have a system without Webservice::ILS available - in koha-shell, do prove t/Koha_ExternalContent_RecordedBooks.t - tests should be skipped and tests count as "passed" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80353|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80476&action=edit Bug 21536: t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled if WebService::ILS is not available. Test plan: - have a system without Webservice::ILS available - in koha-shell, do prove t/Koha_ExternalContent_RecordedBooks.t - tests should be skipped and tests count as "passed" Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80476|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 80502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80502&action=edit Bug 21536: t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled if WebService::ILS is not available. Test plan: - have a system without Webservice::ILS available - in koha-shell, do prove t/Koha_ExternalContent_RecordedBooks.t - tests should be skipped and tests count as "passed" Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial patch, works as expected. Passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed for 18.11. Thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Caused by bug 17602 not in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org