[Bug 6298] New: Profile pictures in the OPAC next to review authors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 Bug #: 6298 Summary: Profile pictures in the OPAC next to review authors Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: fmarier@gmail.com QAContact: koha-bugs@lists.koha-community.org Created attachment 4035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4035 Screenshot of user reviews on book with avatars Adding Libravatar (http://www.libravatar.org) support to the OPAC will make it possible to display photos next to the reviewers' name as long as that patron has an email address on file. This is actually pretty simple to do since the Gravatar::URL CPAN package includes a module called Libravatar::URL: http://search.cpan.org/~fmarier/Gravatar-URL-1.04/lib/Libravatar/URL.pm which is in Debian as of wheezy. Otherwise: sudo apt-get install libnet-dns-perl libtest-warn-perl sudo cpan Gravatar::URL My branch is here: https://gitorious.org/~fmarier/koha/francois-sandbox/commits/libravatar_supp... and I will submit it to the mailing list for review once it's ready. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |nengard@gmail.com AssignedTo|oleonard@myacpl.org |fmarier@gmail.com --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2011-05-04 12:25:30 UTC --- I would note that you should also edit the recent comments page with this code so that they're consistent. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 --- Comment #2 from Francois Marier <fmarier@gmail.com> 2011-05-04 12:33:59 UTC --- Nicole, I quickly looked around but I couldn't find that recent comments page. Is it in the OPAC or on the admin side? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 --- Comment #3 from Nicole C. Engard <nengard@gmail.com> 2011-05-04 12:54:06 UTC --- http://YOURCATALOG/cgi-bin/koha/opac-showreviews.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 --- Comment #4 from Francois Marier <fmarier@gmail.com> 2011-05-05 11:47:14 UTC --- Created attachment 4038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4038 Screenshot of the recent reviews page with avatars I have added (smaller) avatars to the recent reviews page as per Nicole's suggestion. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> 2011-05-05 11:50:04 UTC --- Awesome!! :) Can't wait to see and test the patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-05-06 14:53:31 UTC --- Francois, the patches for this apply just fine, but I'm not seeing the avatars (I have fake patrons with fake email addresses - so I need to get some real addresses in there). I was thinking though that you don't have a preference for this. So that means if the library isn't showing patron names you're still showing avatars and if the library doesn't want to show avatars due to potentially offensive pictures showing they have no way to turn it off. There should be two edits: 1 - a preference to turn this on and off 2 - a check to see if the names are showing and if not then don't show the pictures either I'm off to add some of my friends email addresses to my test system so I can see some avatars ;) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 --- Comment #7 from Nicole C. Engard <nengard@gmail.com> 2011-05-06 14:58:35 UTC --- Francois, I tried using your email address in a patron record and still don't see the avatar on the review. Where are you looking for the email? Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #8 from Nicole C. Engard <nengard@gmail.com> 2011-05-06 17:26:24 UTC --- I tested again with Magnus's email and still no avatars. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 --- Comment #9 from Francois Marier <fmarier@gmail.com> 2011-05-07 06:35:52 UTC --- I have just sent a revised patchset to the list: - checks to see if ShowReviewer is ON - adds a new ShowReviewerPhoto pref - add Gravatar::URL >= 1.03 to list of optional perl dependencies The email address that's used for each patron is the "Primary Email" (under "Contact"). Have you got the extra Perl module that's required? (Gravatar::URL version 1.03 or later)? If it's not installed then the photos don't show up but no errors are thrown. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 --- Comment #10 from Francois Marier <fmarier@gmail.com> 2011-05-07 06:37:04 UTC --- Created attachment 4055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4055 add ShowReviewerPhoto pref to the manual Here is a quick patch for the Koha documentation to add the new system preference. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 --- Comment #11 from Francois Marier <fmarier@gmail.com> 2011-05-07 06:38:58 UTC --- Created attachment 4056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4056 manual: explain where the reviewer photos come from and how to get one Here is a rough idea for the manual: a small explanation of where the reviewer photos come from. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 --- Comment #12 from Nicole C. Engard <nengard@gmail.com> 2011-05-07 21:58:17 UTC --- You did say that I needed that dependency right there is the first comment didn't you :) I'll install that now and test. Thanks for taking my suggestions into consideration! This is gonna be a cool enhancement. Testing now. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 --- Comment #13 from Nicole C. Engard <nengard@gmail.com> 2011-05-07 22:06:40 UTC --- Question about manual updates - are they for the master branch or the 3.4 branch? Also, patches for the manual can be sent to the docs mailing list (https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-docs) in the future. I don't always look for them in the bug reports (I just saw these cause I'm testing things). Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 --- Comment #14 from Nicole C. Engard <nengard@gmail.com> 2011-05-07 22:12:58 UTC --- Created attachment 4058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4058 no avatar if it's 'my' comment This patch works as long as the comment isn't my own. Is it supposed to show your own avatar if you're logged in? Or just show your avatar to others? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 --- Comment #15 from Nicole C. Engard <nengard@gmail.com> 2011-05-07 22:13:38 UTC --- Created attachment 4059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4059 works if i'm logged out Of course that's not my picture ;) but that handsome man shows only if I'm logged out because it's attached to my account. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 --- Comment #16 from Nicole C. Engard <nengard@gmail.com> 2011-05-07 22:15:19 UTC --- Created attachment 4060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4060 avatar shows on 'my' comments on recent comments When on the recent comments page and I'm logged in I see my avatar. So this confirms that it should show on the bib detail as well if I'm logged in. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #17 from Nicole C. Engard <nengard@gmail.com> 2011-05-07 22:20:03 UTC --- Okay, I tested all 5 patches and they work beautifully except for the issue of my avatar not showing on the bib detail if I'm logged in. Fix that and I'm ready to sign off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 --- Comment #18 from Nicole C. Engard <nengard@gmail.com> 2011-05-07 22:24:28 UTC --- Also, in updatedatabase you should have this line: $DBversion = "3.05.00.002"; reading $DBversion = "3.05.00.XXX"; The RM will assign a version number and kohaversion.pl shouldn't be updated by anyone but the RM. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 --- Comment #19 from Francois Marier <fmarier@gmail.com> 2011-05-07 22:55:13 UTC --- The manual patches were for the master branch. I'll add the "me" pictures when logged in (I must have forgotten to test that), remove the DB version and then submit the update patches to the list. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 --- Comment #20 from Nicole C. Engard <nengard@gmail.com> 2011-05-07 22:56:57 UTC --- Awesome. And thanks so very very much for the manual patches!! It would be awesome if everyone wrote the manual bits for their devs :) hint hint. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 Francois Marier <fmarier@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff --- Comment #21 from Francois Marier <fmarier@gmail.com> 2011-05-07 23:23:09 UTC --- New patch submitted to the list (and pushed to my Gitorious branch): - don't bump kohaversion - show your own avatar on the bib detail page -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #22 from Nicole C. Engard <nengard@gmail.com> 2011-05-08 00:09:11 UTC --- Signed off and submitted to the list!! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 --- Comment #23 from Nicole C. Engard <nengard@gmail.com> 2011-05-08 00:10:38 UTC --- Created attachment 4061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4061 5 signed off patches -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #24 from Chris Cormack <chris@bigballofwax.co.nz> 2011-07-05 03:03:58 UTC --- Pushed to master, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6298 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org