[Bug 28353] New: regression: Batch Item Deletion no longer shows which items were not removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Bug ID: 28353 Summary: regression: Batch Item Deletion no longer shows which items were not removed Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdonna@gmail.com QA Contact: testopia@bugs.koha-community.org In 19.11 when using the batch item deletion tool, the confirmation screen included the total number of items and bibs deleted, and listed the items that could not be deleted, such as if they were checked out, etc. In 20.05 the user only sees the number of items and bibs deleted and no message that items in the batch were not deleted. The results page should show a list of items in the batch that were not able to be deleted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 LeeAnn Nilsson <lnilsson@lewistonschools.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lnilsson@lewistonschools.ne | |t --- Comment #1 from LeeAnn Nilsson <lnilsson@lewistonschools.net> --- This is a big problem for our libraries. I do cataloging for multiple libraries and librarians send me large lists of barcodes to delete. The new feature is not efficient. When I use this tool, I need the warnings on the results page to say which barcodes were not deleted and why, so I can refer those items back to the librarians to follow up on. Thanks, LeeAnn -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 --- Comment #2 from Lisette Scheer <lisetteslatah@gmail.com> --- (In reply to Donna from comment #0)
The results page should show a list of items in the batch that were not able to be deleted.
+1 This would be much more helpful than the current setup. Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121089&action=edit Bug 28353: Display a list of items that cannot be deleted We used to display a list of items that cannot be deleted (checked out or on hold) on the Batch item deletion tool. With bug 8132 we improve the error handling, but the info is spread in the table. This patch adds, at the top of the page, the list of items (barcode) that cannot be removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Version|20.05 |unspecified --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- With this patch I get: https://snipboard.io/phjBsA.jpg Would that work for you? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8132 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 [Bug 8132] Batch delete tool deletes items with holds on them -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 --- Comment #5 from LeeAnn Nilsson <lnilsson@lewistonschools.net> --- Yes that is helpful. Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to LeeAnn Nilsson from comment #5)
Yes that is helpful. Thanks
Hi Leann, would you be able to sign this off? The sandboxes should work in this case and we just updated the instructions :) https://wiki.koha-community.org/wiki/Sandboxes Also happy to help if you have any questions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|regression: Batch Item |Regression: Batch item |Deletion no longer shows |deletion no longer shows |which items were not |which items were not |removed |removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121089|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 121504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121504&action=edit Bug 28353: Display a list of items that cannot be deleted We used to display a list of items that cannot be deleted (checked out or on hold) on the Batch item deletion tool. With bug 8132 we improve the error handling, but the info is spread in the table. This patch adds, at the top of the page, the list of items (barcode) that cannot be removed. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker). Test plan: 1. Place a hold for an item and note the barcode 2. Check out an item and note the barcode 3. Go to the batch delete item tool (Tools > Catalog > Batch item deletion) and in the barcode list enter: . The barcodes from step 1 and 2 . An invalid barcode (such as 'XYZ'), . A barcode for an item that can be deleted (= not checked out, not on hold) and click 'Continue' 5. The batch item deletion page will show this message: . 'Warning, the following barcodes were not found:", followed by a list of barcodes (it should list the invalid barcode entered in step 3) 6. Select all the items and click 'Delete selected items' 7. The message says: '1 item(s) deleted' 8. Apply the patch 9. Repeat step 3: 10. The batch item deletion page will show these messages: . 'Warning, the following barcodes were not found:", followed by a list of barcodes - "Warning, the following items cannot be deleted:", followed by a list of barcodes 11. Click 'Delete selected items", the resulting mesage says '1 item(s) deleted' 12. Sign off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121504|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 121577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121577&action=edit Bug 28353: Display a list of items that cannot be deleted We used to display a list of items that cannot be deleted (checked out or on hold) on the Batch item deletion tool. With bug 8132 we improve the error handling, but the info is spread in the table. This patch adds, at the top of the page, the list of items (barcode) that cannot be removed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual Text to go in the| |This restores and improves release notes| |the messages displayed when | |batch deleting items (Tools | |> Catalog > Batch item | |deletion). | | | |The messages | |displayed are: | |- "Warning, | |the following barcodes were | |not found:", followed by a | |list of barcodes | |- | |"Warning, the following | |items cannot be deleted:", | |followed by a list of | |barcodes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.01,20.11.07 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 LeeAnn Nilsson <lnilsson@lewistonschools.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|FIXED |--- --- Comment #15 from LeeAnn Nilsson <lnilsson@lewistonschools.net> --- This has a closed fixed status, but has regressed again. The only warning given is an unclicked box and when deleting long lists it is hard to notice. The follow up page use to have a notification stating some barcodes were not deleted, please help. Thanks, LeeAnn -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to LeeAnn Nilsson from comment #15)
This has a closed fixed status, but has regressed again. The only warning given is an unclicked box and when deleting long lists it is hard to notice. The follow up page use to have a notification stating some barcodes were not deleted, please help. Thanks, LeeAnn
Hi LeeAnn, please report this as a new bug. When a bug has been closed and was part of a release, this is always the way to go. With a new bug, the problem will show properly in the release notes and RMaints will be alerted that they need to backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ... you can use the 'Depends on' in the new bug to link to this one! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31630 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28353 LeeAnn Nilsson <lnilsson@lewistonschools.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31630 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31630 [Bug 31630] Batch item deletion no longer shows which items were not removed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org