[Bug 30584] New: Cannot add field mappings to Elasticsearch configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584 Bug ID: 30584 Summary: Cannot add field mappings to Elasticsearch configuration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com bug 29893 redraws the table before submission - this appears to remove any rows we have added To test: 1 - Browse to Administration -> Catalog -> Search engine configuration (Elasticsearch) 2 - Click on 'Bibliographic records' tab 3 - Scroll to bottom and enter a new mapping and click '+Add' button at far right 4 - Click 'Save' button at bottom 5 - You may notice your new row disappears, then the page reloads 6 - Check for your new mapping - it has not been added -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 [Bug 29893] ElasticSearch Config UI deletes mappings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This template is a nightmare... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133595&action=edit Bug 30584: Fix ES mapping creation We need to tell DT that we are adding/removing row, not only deal manually with the DOM. This patch also fixes the following bug: if you add or remove a row from the "biblio" tab, then go to another tab and back to "biblio", all changes were gone (bug existed prior to bug 29893). Test plan: Add, edit and remove mappings, switch from tabs and save. Use the filters, save (29893 regression test) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Severity|major |critical Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Keywords| |rel_21_11_candidate --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Upping severity, it impacts stable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133595|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 133657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133657&action=edit Bug 30584: Fix ES mapping creation We need to tell DT that we are adding/removing row, not only deal manually with the DOM. This patch also fixes the following bug: if you add or remove a row from the "biblio" tab, then go to another tab and back to "biblio", all changes were gone (bug existed prior to bug 29893). Test plan: Add, edit and remove mappings, switch from tabs and save. Use the filters, save (29893 regression test) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Holding of on release of 21.11.05 until this has been pushed to master so I can backport it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133657|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133800&action=edit Bug 30584: Fix ES mapping creation We need to tell DT that we are adding/removing row, not only deal manually with the DOM. This patch also fixes the following bug: if you add or remove a row from the "biblio" tab, then go to another tab and back to "biblio", all changes were gone (bug existed prior to bug 29893). Test plan: Add, edit and remove mappings, switch from tabs and save. Use the filters, save (29893 regression test) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30584 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34695 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org