[Bug 22047] New: set_password should have an 'unsafe' param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Bug ID: 22047 Summary: set_password should have an 'unsafe' param Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- On removing traces of update_password in the codebase, I noticed the use case in Auth_with_ldap.pm which basically skips any password quality check. I'm not sure if that 'feature' is or should be used. For now, we should provide this alternate behaviour. The best approach is adding an 'unsafe' param. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21178 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21178 [Bug 21178] Add Koha::Patron::set_password method -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21547 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21547 [Bug 21547] Use set_password in opac-passwd and remove sub goodkey -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21992 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 [Bug 21992] Remove Koha::Patron::update_password -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 83491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83491&action=edit Bug 22047: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 83492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83492&action=edit Bug 22047: Add 'skip_validation' param to Koha::Patron->set_password This patch makes Koha::Patron->set_password expect a hashref as param and adds support for an 'skip_validation' param to be passed. Its purpose is to make the method skip the relevant password strength checks if required. It targets the Auth_with_ldap.pm usage when the 'update_password' flag is set in the configuration. The tests on this bug cover this use case so, to test: - Apply the tests patch - Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => FAIL: Tests fail, code doesn't work as expected - Apply this patch - Run: k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests pass! Yay! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 83493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83493&action=edit Bug 22047: Fix opac/opac-passwd.pl call -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Summary|set_password should have an |set_password should have a |'unsafe' param |'skip_validation' param -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|21992 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21992 [Bug 21992] Remove Koha::Patron::update_password -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22048 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048 [Bug 22048] Use set_password instead of update_password in the codebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83491|0 |1 is obsolete| | Attachment #83492|0 |1 is obsolete| | Attachment #83493|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83582&action=edit Bug 22047: Unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83583&action=edit Bug 22047: Add 'skip_validation' param to Koha::Patron->set_password This patch makes Koha::Patron->set_password expect a hashref as param and adds support for an 'skip_validation' param to be passed. Its purpose is to make the method skip the relevant password strength checks if required. It targets the Auth_with_ldap.pm usage when the 'update_password' flag is set in the configuration. The tests on this bug cover this use case so, to test: - Apply the tests patch - Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => FAIL: Tests fail, code doesn't work as expected - Apply this patch - Run: k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests pass! Yay! - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83584&action=edit Bug 22047: Fix opac/opac-passwd.pl call Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83582|0 |1 is obsolete| | Attachment #83583|0 |1 is obsolete| | Attachment #83584|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 83594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83594&action=edit Bug 22047: Unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 83595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83595&action=edit Bug 22047: Add 'skip_validation' param to Koha::Patron->set_password This patch makes Koha::Patron->set_password expect a hashref as param and adds support for an 'skip_validation' param to be passed. Its purpose is to make the method skip the relevant password strength checks if required. It targets the Auth_with_ldap.pm usage when the 'update_password' flag is set in the configuration. The tests on this bug cover this use case so, to test: - Apply the tests patch - Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => FAIL: Tests fail, code doesn't work as expected - Apply this patch - Run: k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests pass! Yay! - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 83596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83596&action=edit Bug 22047: Fix opac/opac-passwd.pl call Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Bug 22047 depends on bug 21547, which changed state. Bug 21547 Summary: Use set_password in opac-passwd and remove sub goodkey https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21547 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Patch doesn't apply --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Minor rebase needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83595|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83596|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84422&action=edit Bug 22047: Unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84423&action=edit Bug 22047: Add 'skip_validation' param to Koha::Patron->set_password This patch makes Koha::Patron->set_password expect a hashref as param and adds support for an 'skip_validation' param to be passed. Its purpose is to make the method skip the relevant password strength checks if required. It targets the Auth_with_ldap.pm usage when the 'update_password' flag is set in the configuration. The tests on this bug cover this use case so, to test: - Apply the tests patch - Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => FAIL: Tests fail, code doesn't work as expected - Apply this patch - Run: k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests pass! Yay! - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84424&action=edit Bug 22047: Fix opac/opac-passwd.pl call Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Invisible enhancement, I'm choosing to backport this to the 18.11.x series for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17006 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 [Bug 17006] Add route to change patron's password -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22047 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependency for 18.05.x will not backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org