[Bug 18014] New: Make auth_header.authid AUTO_INCREMENT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Bug ID: 18014 Summary: Make auth_header.authid AUTO_INCREMENT Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make auth_header.authid |Working title |AUTO_INCREMENT | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Working title |AddAuthority should respect | |AUTO_INCREMENT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |MARC Authority data support |and plumbing | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12722 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722 [Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59663&action=edit Bug 18014: General update of AuthoritiesMarc.t Test plan: Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59664&action=edit Bug 18014: Add test to AuthoritiesMarc.t to expose problem in AddAuthority Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59665&action=edit Bug 18014: AddAuthority should respect AUTO_INCREMENT Instead of using the MAX(authid)+1 logic, AddAuthority should just save the record and get the new id. The authid column is an autoincrement. This eliminates problems where a newly assigned authid also refers to a previously deleted record. (And it will not cause problems when refining the dontmerge functionality on report 9988.) Note: ModAuthority also calls AddAuthority to update an existing record; in that case we should not create a new record even if the record should not be found any more (which should be exceptional). This patch also simplifies handling of 001 in the authority record: in all cases this field is updated now; no need to check its contents. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t [2] Add a new authority record via the interface Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- *** Bug 12734 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59663|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59667&action=edit Bug 18014: General update of AuthoritiesMarc.t Modern::Perl, Koha::Database, etc. Test plan: Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59664|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59668&action=edit Bug 18014: Add test to AuthoritiesMarc.t to expose problem in AddAuthority Since AddAuthority uses max(id)+1 logic to produce the next authid, authority id's will be reused when you delete the last record. This may be a source of problems and will be addressed on the next patch. This patch add a test to expose the problem. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59665|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59669&action=edit Bug 18014: AddAuthority should respect AUTO_INCREMENT Instead of using the MAX(authid)+1 logic, AddAuthority should just save the record and get the new id. The authid column is an autoincrement. This eliminates problems where a newly assigned authid also refers to a previously deleted record. (And it will not cause problems when refining the dontmerge functionality on report 9988.) Note: ModAuthority also calls AddAuthority to update an existing record; in that case we should not create a new record even if the record should not be found any more (which should be exceptional). This patch also simplifies handling of 001 in the authority record: in all cases this field is updated now; no need to check its contents. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t [2] Add a new authority record via the interface Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 [Bug 17908] Authority merge omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 59669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59669 Bug 18014: AddAuthority should respect AUTO_INCREMENT Review of attachment 59669: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18014&attachment=59669) ----------------------------------------------------------------- ::: t/db_dependent/AuthoritiesMarc.t @@ +201,5 @@
my $id2 = AddAuthority( $record, undef, 'GEOGR_NAME' ); + isnt( $id1, $id2, 'Do not return the same id again' ); + t::lib::Mocks::mock_preference( 'marcflavour', 'UNIMARC' ); + my $id3 = AddAuthority( $record, undef, 'GEOGR_NAME' ); + is( $id3 > 0, 1, 'Tested AddAuthority with UNIMARC' );
ok($id3>0,'...') would have been better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 59669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59669 Bug 18014: AddAuthority should respect AUTO_INCREMENT Review of attachment 59669: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18014&attachment=59669) ----------------------------------------------------------------- ::: t/db_dependent/AuthoritiesMarc.t @@ -198,5 @@
my $record = C4::AuthoritiesMarc::GetAuthority(1); my $id1 = AddAuthority( $record, undef, 'GEOGR_NAME' ); DelAuthority( $id1 ); my $id2 = AddAuthority( $record, undef, 'GEOGR_NAME' ); - is( $id1, $id2, 'FIXME: Got the same id back, let\'s fix that behavior' );
This should have been isnt in the first place, and the second patch should be expecting a failure. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59667|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59700&action=edit Bug 18014: General update of AuthoritiesMarc.t Modern::Perl, Koha::Database, etc. Test plan: Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59668|0 |1 is obsolete| | --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59701&action=edit Bug 18014: Add test to AuthoritiesMarc.t to expose problem in AddAuthority Since AddAuthority uses max(id)+1 logic to produce the next authid, authority id's will be reused when you delete the last record. This may be a source of problems and will be addressed on the next patch. This patch add a test to expose the problem. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59669|0 |1 is obsolete| | --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59702&action=edit Bug 18014: AddAuthority should respect AUTO_INCREMENT Instead of using the MAX(authid)+1 logic, AddAuthority should just save the record and get the new id. The authid column is an autoincrement. This eliminates problems where a newly assigned authid also refers to a previously deleted record. (And it will not cause problems when refining the dontmerge functionality on report 9988.) Note: ModAuthority also calls AddAuthority to update an existing record; in that case we should not create a new record even if the record should not be found any more (which should be exceptional). This patch also simplifies handling of 001 in the authority record: in all cases this field is updated now; no need to check its contents. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t [2] Add a new authority record via the interface Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtompset@hotmail.com --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Didn't test just the first patch by itself, but tested 1&2 together and all three together. That's why I commented like I dd in comment #8 and comment #9. But the end product is good. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to M. Tompsett from comment #13)
Didn't test just the first patch by itself, but tested 1&2 together and all three together. That's why I commented like I dd in comment #8 and comment #9. But the end product is good. :)
Thanks for your feedback and signoff ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59700|0 |1 is obsolete| | Attachment #59701|0 |1 is obsolete| | Attachment #59702|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 59869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59869&action=edit Bug 18014: General update of AuthoritiesMarc.t Modern::Perl, Koha::Database, etc. Test plan: Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 59870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59870&action=edit Bug 18014: Add test to AuthoritiesMarc.t to expose problem in AddAuthority Since AddAuthority uses max(id)+1 logic to produce the next authid, authority id's will be reused when you delete the last record. This may be a source of problems and will be addressed on the next patch. This patch add a test to expose the problem. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 59871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59871&action=edit Bug 18014: AddAuthority should respect AUTO_INCREMENT Instead of using the MAX(authid)+1 logic, AddAuthority should just save the record and get the new id. The authid column is an autoincrement. This eliminates problems where a newly assigned authid also refers to a previously deleted record. (And it will not cause problems when refining the dontmerge functionality on report 9988.) Note: ModAuthority also calls AddAuthority to update an existing record; in that case we should not create a new record even if the record should not be found any more (which should be exceptional). This patch also simplifies handling of 001 in the authority record: in all cases this field is updated now; no need to check its contents. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t [2] Add a new authority record via the interface Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59869|0 |1 is obsolete| | --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 59880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59880&action=edit Bug 18014: General update of AuthoritiesMarc.t Modern::Perl, Koha::Database, etc. Test plan: Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59870|0 |1 is obsolete| | --- Comment #19 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 59881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59881&action=edit Bug 18014: Add test to AuthoritiesMarc.t to expose problem in AddAuthority Since AddAuthority uses max(id)+1 logic to produce the next authid, authority id's will be reused when you delete the last record. This may be a source of problems and will be addressed on the next patch. This patch add a test to expose the problem. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59871|0 |1 is obsolete| | --- Comment #20 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 59882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59882&action=edit Bug 18014: AddAuthority should respect AUTO_INCREMENT Instead of using the MAX(authid)+1 logic, AddAuthority should just save the record and get the new id. The authid column is an autoincrement. This eliminates problems where a newly assigned authid also refers to a previously deleted record. (And it will not cause problems when refining the dontmerge functionality on report 9988.) Note: ModAuthority also calls AddAuthority to update an existing record; in that case we should not create a new record even if the record should not be found any more (which should be exceptional). This patch also simplifies handling of 001 in the authority record: in all cases this field is updated now; no need to check its contents. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t [2] Add a new authority record via the interface Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #21 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 59883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59883&action=edit Bug 18014: QA follow-up: Use ok() instead of is() for '>' comparison Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #22 from Julian Maurice <julian.maurice@biblibre.com> --- Oops, I didn't see Nick already did QA earlier. I will obsolete my patches (except for the followup) and de-obsolete Nick's patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59869|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59870|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59871|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59880|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59881|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59882|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Julian, Marcel! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 'Smells' a bit of possible behaviour change. Marcel, what do you think? Not pushing this for 16.11.04, might reconsider later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #24)
'Smells' a bit of possible behaviour change. Marcel, what do you think? Not pushing this for 16.11.04, might reconsider later.
Fixing a bug is on itself a behavior change :) The only change is a good one: the deleted authid will no longer be reused. We may assume that no one relies on such wrong behavior. This would be imo an candidate for backporting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Bit hard to admit, because you said noone would do that... But actually we enforce auth_id to be the ID from the union catalog - that way we can import the records "prelinked" as the number in $9 of the bibliographic record matches the auth_id of Koha. I admit, this is not a totally recommendable way of doing things... but there might be other strange things out there. Not sure if it would affect our workflow at the moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #26)
Bit hard to admit, because you said noone would do that... But actually we enforce auth_id to be the ID from the union catalog - that way we can import the records "prelinked" as the number in $9 of the bibliographic record matches the auth_id of Koha. I admit, this is not a totally recommendable way of doing things... but there might be other strange things out there. Not sure if it would affect our workflow at the moment.
Never say never :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- *** Bug 17980 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org