http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8622 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11563&action=edit Bug 8622: Fix theme fallback This patch does the following: 1) Enables fallback for includes between different themes and different languages (with the exact same precedence as for .tt files) 2) Enable fallback for XSLT files between different themes and different languages (again, same precedence) 3) Change the semantics of the TT [% themelang %] variable so that it always refers to the preferred theme and language, rather than the fallback theme/language. As a result, all themes must include all javascript, css and image resources they use. Note that these changes actually have no impact whatsoever on an installation where the default (prog) themes are in use. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8622 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- To test: 1) Ensure that images, CSS, and Javascript load normally with the prog theme. 2) View an XSLT-generated block in English and another language, and ensure that the XSLT is rendered in both. 3) [optional] Either create a new theme or add the theme created by bug 8597, switch to the new theme, and ensure that images, CSS and Javascript load normally. 4) [optional] In this other theme, view an XSLT-generated block in English and another language, and ensure that they render. If there are any problems with this patch, it will be readily apparent because most assets will not load. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8622 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11563|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11580&action=edit Bug 8622: Fix theme fallback This patch does the following: 1) Enables fallback for includes between different themes and different languages (with the exact same precedence as for .tt files) 2) Enable fallback for XSLT files between different themes and different languages (again, same precedence) 3) Change the semantics of the TT [% themelang %] variable so that it always refers to the preferred theme and language, rather than the fallback theme/language. As a result, all themes must include all javascript, css and image resources they use. Note that these changes actually have no impact whatsoever on an installation where the default (prog) themes are in use. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8622 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #5 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #4)

SO'd. Leaving as "Needs Signoff" for more testing. Tested cases 1 & 2.

i'll add a 2nd sign-off for cases 3 and 4. they work OK too :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8622 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- All cases have now been tested, switching to signed off. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8622 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master Could not see any difference between before and after the patch, which what we expect when we use prog theme (what most libraries does) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8622 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Theme fallback is now working on master. -- You are receiving this mail because: You are watching all bug changes.