[Bug 10404] New: Add previous/next browsing to staff client search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Bug ID: 10404 Summary: Add previous/next browsing to staff client search results Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: new feature Priority: P5 - low Component: Staff Client Assignee: jcamins@cpbibliography.com Reporter: jcamins@cpbibliography.com CC: gmcharlt@gmail.com There is currently no way to go to the next record in a search result list on the staff client, and there really should be some sort of previous/next browse functionality. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 20025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20025&action=edit Bug 10404: add previous/next browsing to staff client Although previous/next browsing was added for searches in the OPAC in 2011, the staff client has been without any sort of search browsing. Until now. This patch is an all-singing, all-dancing, all-compatible implementation of search browsing that will work across multiple browser tabs and on any browser since IE7 (though the staff client layout is broken on IE7). To test: 1) Perform a search that will bring up multiple results. 2) View one of the results. 3) Use the Previous and Next links to browse along the search results. 4) Use the "Return to results" button to check that you end up at the correct page of results, even if you page through more than 20 records. 5) Sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Two comments I made in IRC that I will copy here so they are not forgotten: - I would put browser.js in intranet-tmpl/js rather than intranet-tmpl/lib/koha. Generally speaking /lib/ is for 3rd-party libraries, /js/ is for scripts written for Koha. - There is commented-out code in results.tt, [% dumper.dump(SEARCH_RESULTS) %] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20025|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 20132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20132&action=edit Bug 10404: add previous/next browsing to staff client Although previous/next browsing was added for searches in the OPAC in 2011, the staff client has been without any sort of search browsing. Until now. This patch is an all-singing, all-dancing, all-compatible implementation of search browsing that will work across multiple browser tabs and on any browser since IE7 (though the staff client layout is broken on IE7). To test: 1) Perform a search that will bring up multiple results. 2) View one of the results. 3) Use the Previous and Next links to browse along the search results. 4) Use the "Return to results" button to check that you end up at the correct page of results, even if you page through more than 20 records. 5) Sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20132|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20176&action=edit [SIGNED-OFF] Bug 10404: add previous/next browsing to staff client Although previous/next browsing was added for searches in the OPAC in 2011, the staff client has been without any sort of search browsing. Until now. This patch is an all-singing, all-dancing, all-compatible implementation of search browsing that will work across multiple browser tabs and on any browser since IE7 (though the staff client layout is broken on IE7). To test: 1) Perform a search that will bring up multiple results. 2) View one of the results. 3) Use the Previous and Next links to browse along the search results. 4) Use the "Return to results" button to check that you end up at the correct page of results, even if you page through more than 20 records. 5) Sign off. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20177&action=edit Bug 10404 [CSS follow-up] Add previous/next browsing to staff client search results This patch slightly modifies the styles of the previous/next links in a way that I think is simpler and clearer. To test, apply the patch and clear your browser cache if necessary. Perform a search in the staff client, click any result, and look at the prevous/next links. If you think this is an improvement, sign off! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Medium patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20177|0 |1 is obsolete| | --- Comment #6 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 20215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20215&action=edit Bug 10404 [CSS follow-up] [SIGNED-OFF] Add previous/next browsing to staff client search results This patch slightly modifies the styles of the previous/next links in a way that I think is simpler and clearer. To test, apply the patch and clear your browser cache if necessary. Perform a search in the staff client, click any result, and look at the prevous/next links. If you think this is an improvement, sign off! Signed-off-by: Magnus Enger <magnus@enger.priv.no> Looks like an improvement to me! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20176|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20225&action=edit Bug 10404: add previous/next browsing to staff client Although previous/next browsing was added for searches in the OPAC in 2011, the staff client has been without any sort of search browsing. Until now. This patch is an all-singing, all-dancing, all-compatible implementation of search browsing that will work across multiple browser tabs and on any browser since IE7 (though the staff client layout is broken on IE7). To test: 1) Perform a search that will bring up multiple results. 2) View one of the results. 3) Use the Previous and Next links to browse along the search results. 4) Use the "Return to results" button to check that you end up at the correct page of results, even if you page through more than 20 records. 5) Sign off. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20225|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20226&action=edit Bug 10404 [CSS follow-up] Add previous/next browsing to staff client search results This patch slightly modifies the styles of the previous/next links in a way that I think is simpler and clearer. To test, apply the patch and clear your browser cache if necessary. Perform a search in the staff client, click any result, and look at the prevous/next links. If you think this is an improvement, sign off! Signed-off-by: Magnus Enger <magnus@enger.priv.no> Looks like an improvement to me! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20215|0 |1 is obsolete| | --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Comment on attachment 20215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20215 Bug 10404 [CSS follow-up] [SIGNED-OFF] Add previous/next browsing to staff client search results Looks like wrong patch was marked obsolete during the final QA round, fixing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20225|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jared! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11369 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11817 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12261 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11890 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org