[Bug 41861] New: ILL request cost and price paid don't show if 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 Bug ID: 41861 Summary: ILL request cost and price paid don't show if 0 Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com, pedro.amorim@openfifth.co.uk, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k CC| |andrew.auld@openfifth.co.uk | |, | |edith.speller@ukhsa.gov.uk, | |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.evans@ukhsa.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193316&action=edit Bug 41861: Update how cost and price_paid show 1) Enabled ILLModule 2) Create a new ILL request, set a title, '42' for cardnumber and any library: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) (k-t-d required, cost is not editable in UI, but backends may set it) Run the following query: koha-mysql kohadev update illrequests set cost = 1; 4) Notice cost shows, now run the same but set to 0: update illrequests set cost = 1; 5) Notice it doesn't show. 6) Apply patch. Refresh. Notice is shows '0' now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193316|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 193366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193366&action=edit Bug 41861: Update how cost and price_paid show 1) Enabled ILLModule 2) Create a new ILL request, set a title, '42' for cardnumber and any library: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) (k-t-d required, cost is not editable in UI, but backends may set it) Run the following query: koha-mysql kohadev update illrequests set cost = 1; 4) Notice cost shows, now run the same but set to 0: update illrequests set cost = 1; 5) Notice it doesn't show. 6) Apply patch. Refresh. Notice is shows '0' now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates how an ILL release notes| |request cost and price paid | |are shown - if the amount | |is $0, then it is now | |shown. Previously, the | |fields were not shown if | |the amount was $0. | | | |(Note: These fields aren't | |editable in the user | |interface, but the backend | |used may set the value.) CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This updates how an ILL |This updates how an ILL release notes|request cost and price paid |request cost and price paid |are shown - if the amount |are shown - if the amount |is $0, then it is now |is $0, then it is now |shown. Previously, the |shown. Previously, the |fields were not shown if |fields were not shown if |the amount was $0. |the amount was $0. | | |(Note: These fields aren't |(Note: 'Cost' is not |editable in the user |editable in the user |interface, but the backend |interface, but the backend |used may set the value.) |used may set the value. | |'Price paid' is editable | |through the 'Edit request' | |action) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193366|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 193486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193486&action=edit Bug 41861: Update how cost and price_paid show 1) Enabled ILLModule 2) Create a new ILL request, set a title, '42' for cardnumber and any library: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) (k-t-d required, cost is not editable in UI, but backends may set it) Run the following query: koha-mysql kohadev update illrequests set cost = 1; 4) Notice cost shows, now run the same but set to 0: update illrequests set cost = 1; 5) Notice it doesn't show. 6) Apply patch. Refresh. Notice is shows '0' now. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 --- Comment #4 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- David I've added a sign-off line for our customer who has tested this. I've also added yours as it appears you signed off but didn't add your line. Let me know if not please. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to Pedro Amorim from comment #4)
David I've added a sign-off line for our customer who has tested this. I've also added yours as it appears you signed off but didn't add your line. Let me know if not please. Thanks.
Thanks Pedro! Not sure why I missed doing that! (And thanks for the edit to the release note.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193486|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 197006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197006&action=edit Bug 41861: Update how cost and price_paid show 1) Enabled ILLModule 2) Create a new ILL request, set a title, '42' for cardnumber and any library: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) (k-t-d required, cost is not editable in UI, but backends may set it) Run the following query: koha-mysql kohadev update illrequests set cost = 1; 4) Notice cost shows, now run the same but set to 0: update illrequests set cost = 1; 5) Notice it doesn't show. 6) Apply patch. Refresh. Notice is shows '0' now. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197006|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 --- Comment #7 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 197202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197202&action=edit Bug 41861: Update how cost and price_paid show 1) Enabled ILLModule 2) Create a new ILL request, set a title, '42' for cardnumber and any library: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) (k-t-d required, cost is not editable in UI, but backends may set it) Run the following query: koha-mysql kohadev update illrequests set cost = 1; 4) Notice cost shows, now run the same but set to 0: update illrequests set cost = 1; 5) Notice it doesn't show. 6) Apply patch. Refresh. Notice is shows '0' now. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41861 --- Comment #9 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org