https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42287 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42287 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196791&action=edit Bug 42287: Tidy all script tags - members In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the members/patrons module. The 2 main changes are in the following files: * moremember.tt => Trivial, simply moving the existing JS variable to a separate script tag * update-child.tt => Trivial, only a single variable created: 'patron_id' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42287 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41653 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 [Bug 41653] Stores for permissions and sysprefs should be under the Koha namespace -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42287 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196791|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42287 --- Comment #3 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 197658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197658&action=edit Bug 42287: Tidy all script tags - members In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the members/patrons module. The 2 main changes are in the following files: * moremember.tt => Trivial, simply moving the existing JS variable to a separate script tag * update-child.tt => Trivial, only a single variable created: 'patron_id' Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42287 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |bibliothek@th-wildau.de |y.org | CC| |bibliothek@th-wildau.de -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42287 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42287 --- Comment #5 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 198275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198275&action=edit Bug 42287: Tidy all script tags - members In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the members/patrons module. The 2 main changes are in the following files: * moremember.tt => Trivial, simply moving the existing JS variable to a separate script tag * update-child.tt => Trivial, only a single variable created: 'patron_id' Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42287 --- Comment #7 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 198277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198277&action=edit Bug 42287: (QA follow-up) Split JS to seperate TT and tidy This splits the script tag in two_factor_auth.tt and member-flags.tt to have a seperate part for interploated TT variables. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42287 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42466 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42466 [Bug 42466] UseCashRegisters gets ignored on paycollect when change > 0 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42287 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.