https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |tomascohen@gmail.com Depends on| |17467 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467 [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 56673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56673&action=edit Bug 17468: Create koha-*-zebra as symlinks to koha-zebra for backwards compatibility -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56673|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 56703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56703&action=edit Bug 17468: Create koha-*-zebra as symlinks to koha-zebra for backwards compatibility -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |4880 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4880 [Bug 4880] koha-remove sometimes fails because user is logged in -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18114 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18114 [Bug 18114] koha-start-* and koha-stop-* should be replaced with the new command style -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #8)

Hi Tomas, can you pleas add a test plan and instructions on how to test with kohadevbox? I seem to remember I need to copy the files somewhere.

You need to have the dependency bug, run reset _all, delete the koha-*-zebra (excluding rebuild) scripts, and create links to koha-zebra, named as the deleted commands. Then test the 'legacy' commands still work. The dep bug, implementing koha-zebra is the juicy one. He -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20048 CC| |mtompset@hotmail.com --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Bug 20048 was added as a see also, because the --status flag was uncheckable while testing this. This, however, does seem to work just fine as a replacement for the koha-stop-zebra, koha-start-zebra, and koha-restart-zebra scripts. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20234 [Bug 20234] Make maintenance scripts use koha-zebra instead of koha-*-zebra -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56702|0 |1 is obsolete| | Attachment #56703|0 |1 is obsolete| | --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 71885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71885&action=edit [Backwards compatible] Bug 17468: Remove koha-*-zebra scripts and its traces This patch removes traces from the (deprecated) koha-*-zebra scripts. To test: - Apply the patch - Verify no traces of koha-*-zebra remain on the codebase (besides Release Notes and the koha-zebra script): $ cd kohaclone $ git grep koha-start-zebra $ git grep koha-stop-zebra $ git grep koha-restart-zebra => SUCCESS: No traces! - Create the following symlinks: $ sudo ln -s /usr/sbin/koha-zebra /usr/sbin/koha-start-zebra $ sudo ln -s /usr/sbin/koha-zebra /usr/sbin/koha-stop-zebra $ sudo ln -s /usr/sbin/koha-zebra /usr/sbin/koha-restart-zebra - Try the koha-*-zebra commands: $ sudo koha-stop-zebra kohadev $ sudo koha-start-zebra kohadev $ sudo koha-restart-zebra kohadev => SUCCESS: They all work as expected! - Sign off :-D! Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I consolidated this work on a single patch. But added two optional in¡mplementations: - [Backwards compatible]: This one removes all the koha-*-zebra things, and makes use of the backward-compatibility baked inside koha-zebra so people can still use the old scripts, but will receive a gentle warning suggesting the use of koha-zebra instead. - The second option removes everything, including the koha-zebra backwards compatibility option. I'm more in favour of the backwards compatible version. I wished it was included in 17.11 so we had at least one release for people to see the warnings and get used to the change. koha-*-sip will have the same future. My only problem with backwards compatibility is that I would like Mirko's opinion on the way I handled it. We can move forward anyway (it works, follows Debian's instructions, etc). Katrin: I amended the test steps so it is easy to try the backwards compatibility. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 --- Comment #15 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to Tomás Cohen Arazi from comment #14)

My only problem with backwards compatibility is that I would like Mirko's opinion on the way I handled it. We can move forward anyway (it works, follows Debian's instructions, etc).

+1 for backwards compatibility. I have not tested the patch yet, but the implementation makes sense to me. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The new koha-zebra release notes| |maintenance script replaces | |the old koha-start-zebra, | |koha-stop-zebra and | |koha-restart-zebra scripts. | |This patch removes them, | |while keeping backwards | |compatibility (i.e. you can | |still run them until you | |get used to the new | |syntax). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 Bug 17468 depends on bug 20234, which changed state. Bug 20234 Summary: Make maintenance scripts use koha-zebra instead of koha-*-zebra https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20234 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.