[Bug 35997] New: Cancelling a hold should remove the hold form the queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Bug ID: 35997 Summary: Cancelling a hold should remove the hold form the queue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com
From bug 35357 - a cancelled hold remains in the hold queue until rebuilt
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cancelling a hold should |Cancelling a hold should |remove the hold form the |remove the hold from the |queue |queue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 161766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161766&action=edit Bug 35997: Cancelling a hold should remove the hold from the queue Test plan: 1) Place a hold for a record for a patron 2) Build the holds queue 3) Note the holds queue contains a match for that patron and record 4) Cancel the holds queue 5) Reload the holds queue page, note the match for that patron and record is gone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161766|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 161767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161767&action=edit Bug 35997: Cancelling a hold should remove the hold from the queue Test plan: 1) Place a hold for a record for a patron 2) Build the holds queue 3) Note the holds queue contains a match for that patron and record 4) Cancel the holds queue 5) Reload the holds queue page, note the match for that patron and record is gone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161767|0 |1 is obsolete| | --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 161794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161794&action=edit Bug 35997: Cancelling a hold should remove the hold from the queue Test plan: 1) Place a hold for a record for a patron 2) Build the holds queue 3) Note the holds queue contains a match for that patron and record 4) Cancel the holds queue 5) Reload the holds queue page, note the match for that patron and record is gone! Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #4 from Brendan Lawlor <blawlor@clamsnet.org> --- Testing notes 1. Placed holds 2. Find the script and run it: git grep build_holds_queue cd misc/cronjobs/holds/ perl build_holds_queue.pl 3. Check http://localhost:8081/cgi-bin/koha/circ/view_holdsqueue.pl 4. Cancel holds and refresh the page The holds were removed from the queue! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Is the join on borrowernumber, biblionumber[1], item_level_request, holdingbranch[1] needed? `itemnumber` is not the primary key of tmp_holdsqueue so is it possible that twice the same itemnumber would be in the table? Even with 5 record level holds for the same patron on a record that has 4 item there is no duplication of itemnumber tmp_holdsqueue. Neither with multiple item level holds on the same item for different patrons. [1] these are 100% sure to be redundant. itemnumber implies biblionumber and holdingbranch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 162257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162257&action=edit Bug 35997: Add tests Test plan: see next patch Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161794|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 162258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162258&action=edit Bug 35997: Cancelling a hold should remove the hold from the queue Test plan: 1) Place a hold for a record for a patron 2) Build the holds queue 3) Note the holds queue contains a match for that patron and record 4) Cancel the holds queue 5) Reload the holds queue page, note the match for that patron and record is gone! Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Meanwhile, here is a 2nd signoff :) And commits were split to allow testing the tests alone to confirm they fail without implementation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162257|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 163175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163175&action=edit Bug 35997: Add tests Test plan: see next patch Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162258|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 163176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163176&action=edit Bug 35997: Cancelling a hold should remove the hold from the queue Test plan: 1) Place a hold for a record for a patron 2) Build the holds queue 3) Note the holds queue contains a match for that patron and record 4) Cancel the holds queue 5) Reload the holds queue page, note the match for that patron and record is gone! Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 163177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163177&action=edit Bug 35997: (QA follow-up) Number of tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|victor@tuxayo.net |m.de.rooy@rijksmuseum.nl CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.04 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35997 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org