[Bug 39029] New: When a basket contains an order transferred from another basket some info is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 Bug ID: 39029 Summary: When a basket contains an order transferred from another basket some info is incorrect Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When a basket has orders transferred from another basket we do this: [% IF (books_loo.transferred_from) %] [% basket = books_loo.transferred_from.basket %] [% bookseller = books_loo.transferred_from.bookseller %] [% timestamp = books_loo.transferred_from.timestamp %] But later when building the 'Add to basket' modal - we have this: <div id="addtoBasket" class="modal" tabindex="-1" role="dialog" aria-labelledby="addtoBasketLabel" aria-hidden="true" data-basketno="[% basket.basketname | html %]"> We are using the wrong basket now to pull info -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- To recreate: 1 - Create a new basket - 'Gonna transfer' 2 - Add an order to the basket 3 - Create another basket 'Has the transfer' 4 - Return to first basket and transfer order to second 5 - Return to second basket, click 'Add to basket' and inspect the modal 6 - Note basketno says 'Gonna transfer' It should have correct name, and maybe be renamed to 'basketname' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 Imani <imani.thomas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |imani.thomas@bywatersolutio | |ns.com --- Comment #2 from Imani <imani.thomas@bywatersolutions.com> --- I have changes for this but am running into some errors trying to attach my patch. Traceback (most recent call last): File "/usr/bin/git-bz", line 2845, in <module> do_attach(*args) File "/usr/bin/git-bz", line 2171, in do_attach add_url(bug, commits) File "/usr/bin/git-bz", line 1719, in add_url add_url_to_head_commit(commit, bug) File "/usr/bin/git-bz", line 1682, in add_url_to_head_commit git.commit(file="-", amend=True, _input=input) File "/usr/bin/git-bz", line 197, in f o = git_run(command, *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/bin/git-bz", line 167, in git_run output, error = process.communicate(input) ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/subprocess.py", line 1207, in communicate stdout, stderr = self._communicate(input, endtime, timeout) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/subprocess.py", line 2039, in _communicate input_view = memoryview(self._input) ^^^^^^^^^^^^^^^^^^^^^^^ I tried doing a fresh ktd pull but still the same error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 Imani <imani.thomas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 --- Comment #3 from Imani <imani.thomas@bywatersolutions.com> --- Created attachment 177978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177978&action=edit Bug 39029: When a basket contains an order transferred from another basket some info is incorrect. To test: 1 - Create a new basket - 'Gonna transfer' 2 - Add an order to the basket 3 - Create another basket 'Has the transfer' 4 - Return to first basket and transfer order to second 5 - Return to second basket, click 'Add to basket' and inspect the modal 6 - Note basketno says 'Gonna transfer' 7 - apply the patch 8 - redo steps 1 through 6 with fresh baskets and the modal should have the correct values -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Assignee|koha-bugs@lists.koha-commun |imani.thomas@bywatersolutio |ity.org |ns.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177978|0 |1 is obsolete| | --- Comment #4 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Created attachment 180473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180473&action=edit Bug 39029: When a basket contains an order transferred from another basket some info is incorrect. To test: 1 - Create a new basket - 'Gonna transfer' 2 - Add an order to the basket 3 - Create another basket 'Has the transfer' 4 - Return to first basket and transfer order to second 5 - Return to second basket, click 'Add to basket' and inspect the modal 6 - Note basketno says 'Gonna transfer' 7 - apply the patch 8 - redo steps 1 through 6 with fresh baskets and the modal should have the correct values Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@openfifth.co.uk --- Comment #5 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Works like a charm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180473|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182270&action=edit Bug 39029: When a basket contains an order transferred from another basket some info is incorrect. To test: 1 - Create a new basket - 'Gonna transfer' 2 - Add an order to the basket 3 - Create another basket 'Has the transfer' 4 - Return to first basket and transfer order to second 5 - Return to second basket, click 'Add to basket' and inspect the modal 6 - Note basketno says 'Gonna transfer' 7 - apply the patch 8 - redo steps 1 through 6 with fresh baskets and the modal should have the correct values Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When a basket contains an |When a basket contains an |order transferred from |order transferred from |another basket some info is |another basket some |incorrect |information is incorrect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Good catch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|caroline.cyr-la-rose@inlibr | |o.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|25.05.00 |25.05.00,24.11.10 released in| | --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39029 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix to restore expected behaviour. Noting to add or edit in the Koha manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org